From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#5936: 23.1.95; fix a bug in abbrev--before-point Date: Mon, 12 Apr 2010 16:19:37 +0100 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1271086163 30872 80.91.229.12 (12 Apr 2010 15:29:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Apr 2010 15:29:23 +0000 (UTC) To: 5936@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 12 17:29:21 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O1LZh-0008CS-6m for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Apr 2010 17:29:21 +0200 Original-Received: from localhost ([127.0.0.1]:55162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1LZg-0004hG-Ip for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Apr 2010 11:29:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1LZN-0004ZI-VU for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:29:02 -0400 Original-Received: from [140.186.70.92] (port=35656 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1LZK-0004Y5-PI for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:29:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O1LZD-0007wU-4V for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:28:58 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39630) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1LZC-0007wI-Hx for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:28:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O1LQg-0007fJ-Op; Mon, 12 Apr 2010 11:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Apr 2010 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 5936 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.127108558829449 (code B ref -1); Mon, 12 Apr 2010 15:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Apr 2010 15:19:48 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1LQS-0007ew-8m for submit@debbugs.gnu.org; Mon, 12 Apr 2010 11:19:48 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1LQQ-0007eq-BI for submit@debbugs.gnu.org; Mon, 12 Apr 2010 11:19:46 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:35450) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O1LQL-0005oY-6C for submit@debbugs.gnu.org; Mon, 12 Apr 2010 11:19:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1LQK-0007s0-9c for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:19:40 -0400 Original-Received: from [140.186.70.92] (port=50844 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1LQI-0007qy-Nt for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:19:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O1LQH-0006B7-6R for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:19:38 -0400 Original-Received: from ppsw-31.csi.cam.ac.uk ([131.111.8.131]:52529 helo=ppsw-1.csi.cam.ac.uk) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1LQH-0006Ax-0t for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:19:37 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Original-Received: from wlan-gw.st-edmunds.cam.ac.uk ([131.111.223.101]:52055 helo=Victoria.local) by ppsw-1.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.151]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1O1LQG-0008Vw-58 (Exim 4.70) for bug-gnu-emacs@gnu.org (return-path ); Mon, 12 Apr 2010 16:19:36 +0100 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 12 Apr 2010 11:20:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36207 Archived-At: If you use the :regexp property in an abbrev table, all abbrevs in that table will fail except those with only one char. This is because of a regexp match in abbrev--before-point which only looks back one char. BTW, the doc string of looking-back seems irrelevant if by default it only looks back one char, that can't be slower than looking-at. diff --git a/lisp/abbrev.el b/lisp/abbrev.el index b72bdbb..d3b95cb 100644 --- a/lisp/abbrev.el +++ b/lisp/abbrev.el @@ -681,7 +681,7 @@ then ABBREV is looked up in that table only." (setq start (point)) (forward-word 1) (setq end (min (point) lim))) - (when (looking-back re (line-beginning-position)) + (when (looking-back re (line-beginning-position) t) (setq start (match-beginning 1)) (setq end (match-end 1))))) (setq name (buffer-substring start end))