From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51606: 29.0.50; [PATCH] Show offscreen context with properties Date: Fri, 05 Nov 2021 13:57:08 +0100 Message-ID: References: <86y263hrds.fsf@gnu.org> <835yt6ero5.fsf@gnu.org> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40075"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (darwin) Cc: Arash Esbati , 51606@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 05 13:59:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1miyoe-000AEI-U5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 13:59:33 +0100 Original-Received: from localhost ([::1]:57788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1miyod-00062O-MZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 08:59:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miynC-0005QZ-CD for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 08:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33547) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1miynB-0006OR-Tv for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 08:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1miynB-0005Gz-SV for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 08:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Nov 2021 12:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51606 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51606-submit@debbugs.gnu.org id=B51606.163611704320207 (code B ref 51606); Fri, 05 Nov 2021 12:58:01 +0000 Original-Received: (at 51606) by debbugs.gnu.org; 5 Nov 2021 12:57:23 +0000 Original-Received: from localhost ([127.0.0.1]:45087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miymY-0005Fm-Fz for submit@debbugs.gnu.org; Fri, 05 Nov 2021 08:57:22 -0400 Original-Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]:40805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1miymW-0005FV-7x for 51606@debbugs.gnu.org; Fri, 05 Nov 2021 08:57:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1636117034; bh=xhg81jsS/ypDc92mXt3yQ+opJsFIgmb+1TAA7cOLWOA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=VBTnZB92dOBcWoFWcbnNsMNON4L80u8vuTuKWrmYN302+F/1W2O4m0ZZFmk671NOcDgIimtKxEqYvWiZX0dIMD09I48Syq28SkR7jUCdlDTIX6SL5PCKurztlt9P2aA7yK47vN6mVtaigj2r9v3bylKspBb7COQ+TrKY7KqXuCKpR+FQt16grwIBzi7BLrbv2XtJh4oGHzCaWrWWei5H7qCvRiy3MCAQwMM8IvT9Wmf3QtkdaaT6kzZ/53eNkr+RpNovy6sEHgNZu0945pyccNQtWPClthqi4JKNXWVvlnr7Tps30C8R+lFLbNDakaRR30DIQ4wrfLYf/+llmaRk6w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636117034; bh=SHT0o2MsM9uy6FyuKs7eceKBTqp5EkOCO7GZ3kTQ85R=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Pw1c5dlxSnGyvsguIwbgHXR0PK05yxA8LH1Rb1wlqMN+0dfDeH4V7J3Bd+GEMPiEmkonK77dywil1QeD5xlFkU4O/N9PjuLjheRHDCPJhFgrrWQkFOPfq6DhcENwaBY8+AyqJOQJoafp2gN8MiOCsFdMhxLqve5QlHwwR9JPhxDLNHTuB4Z4llvs0SjeKXMtrKS4yepY+5P4II+27nnvhGd8uLZ1fA54YDyYiRGKUSCYCE5Dneqn45QicnYDfr74qeBi0sBUsU1cr2SHAWTohrLGsMk2cJHJWWKNo8uAUtXi92zqtrmWoErr+AZ07UPYBuzJG0qtTXSyJ+VMKX4NIg== X-YMail-OSG: Q6fZeIsVM1kM.AaBdmhgxQf01Bqknt76mN7uUrqYaAfiH0rULik0PrUlcfXTrpH nThisLX3RpaGXMgWslzuSFtDcHbsSKfRBU086xZAV87.p4V0zm4gt32tn1sPPISCwFa2VcYM9UuC UyZ6Y7oLjuUSibaPpW4EH5T15m3zSjWn0bRf_fGpeDjvBR9iOOeFdzRkA8WM2kiBGqR.eUYxfUQk iF7dOkox7kcxZPkJL1uy3HKZEBVtJTk_lt7P12HA2nlxfTQpFpb33x2ix3PZ5aEKe5aBlvlZ8c_f ohAuyxytnNedw3EStNi7Mt4HzS_QNkjfKDS_RZcXbcib_Z61d9ctiJjSaJTDFxNOD.7Hvcyz1zE3 ttgKbEK8v7LJox_ppUHqwPFPE7i0jysuWV8l4yictxF70cutYRX9jWrH5Ow1KUBGHUzLLnDCEXSi JB.rJqN9FGWHPYqYh9RhDlUxOK_tbR3BeF5Tv.q16qsRgf4rkev9zpBq8wk4CcLAWPNIoznwvOyP lmj393YFTu5WCDJCrag2woliRdHhP7Zib6GmtAo1vC_QNbmucxzGI6RI3fCmGUhYWL6Oo3faroyd PK_wcZjp_r3Hce6vPDmAQplPEFjWuGn9c1vuGSr.CsqZQiGJFU1XPvOXG6Q5tyRnoo6MK5E4.cq. 9gK4zH5HildUJrujokaqYxZlmH7uULQ6gLl69WlMjMW9UEbaz0jgZjbphXNfh77.4KL7G1kimS81 bMA178yLPOlxzI9FEa493inJ71AwqpSB89AdwYzLDkSqrU7ixwOXBUKw7lLapTJ4_cAjuvFLN7E0 MabCaKvACOw_6B6ch4SNJUm9xdqiX3dBk0dx.fqxgu X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Fri, 5 Nov 2021 12:57:14 +0000 Original-Received: by kubenode516.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 1cfaa734044e291c56cca8040b1be81e; Fri, 05 Nov 2021 12:57:10 +0000 (UTC) In-Reply-To: <835yt6ero5.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Nov 2021 14:02:50 +0200") X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218990 Archived-At: Eli Zaretskii writes: >> From: Arash Esbati >> Date: Fri, 05 Nov 2021 10:40:47 +0100 >> >> paren.el now can show the context in minibuffer when >> `show-paren-context-when-offscreen' is non-nil (introduced in this >> change 9f505c476e). Is it possible to extend this that text properties >> are not stripped? I'm thinking about something like this: > > Why do we remove the properties in the first place? Daniel, any > special reasons? No reason other than being cautious and "follow the traditional behavior of blink-matching-open". The code that I extracted from blink-matching-open to reuse it for show-paren-mode removed the text properties (see https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/simple.el?h=emacs-28#n8608). If I'm not mistaken, this was apparently introduced in 2005 by Richard Stallman (https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-28&id=1d0e3fc84f058248515f242c0484a0dabfac95aa), but I don't know the reasons for the change. Perhaps it didn't look good on some TTY frames?