From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68213: 30.0.50; completion-preview-tests failure in --without-x build Date: Tue, 02 Jan 2024 18:20:20 +0100 Message-ID: References: <87ttnvr7x7.fsf@pub.pink> <83plyjzmlv.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36855"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: john muhl , 68213@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 02 18:21:43 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rKiSU-0009LP-QH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Jan 2024 18:21:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rKiRp-0002ya-V1; Tue, 02 Jan 2024 12:21:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKiRn-0002y5-Ng for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2024 12:20:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rKiRn-0006dH-Bv for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2024 12:20:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rKiRp-00008F-RX for bug-gnu-emacs@gnu.org; Tue, 02 Jan 2024 12:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jan 2024 17:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68213 X-GNU-PR-Package: emacs Original-Received: via spool by 68213-submit@debbugs.gnu.org id=B68213.1704216029458 (code B ref 68213); Tue, 02 Jan 2024 17:21:01 +0000 Original-Received: (at 68213) by debbugs.gnu.org; 2 Jan 2024 17:20:29 +0000 Original-Received: from localhost ([127.0.0.1]:51164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKiRJ-00007H-Co for submit@debbugs.gnu.org; Tue, 02 Jan 2024 12:20:29 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:44248 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKiRG-000078-B8 for 68213@debbugs.gnu.org; Tue, 02 Jan 2024 12:20:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1704216023; bh=wGiLcFKhXwmxv/23hf8YbQmyxcKAR/WNLkjKYTDy6cE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Tl0PE7JAxU5BV+ZaCbLh2F4b8oEIGc9hPx5Ja481uc2DCyBdOw5fTSbmhgFkfUVyE PUSthCdhAh/r2f2BBZBsLxRVTsfX0ZKFNKHLqW16bEXVbfBgEJba2DSO3XPkr5StKN I3KhTQFtBx9nARDk/cfxd/179CERxd+v2q9TBcMoOw9nXJIo1xOyAc+W8iB3qLiHd6 V8LZSUjDPVZ1pWMbnsKObFFctYbPzCr3KRPrDo3Mf1IsPLJvkQrNLHxFQVJACDFgXd nQzdxD6AzK+ge5l+rwBI2i787kufpfVfmmDrKrsS542fcWiZQ0pB6h436PrXXpZhKH RLjQPL670Ra/g== In-Reply-To: <83plyjzmlv.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Jan 2024 19:11:40 +0200") X-Hashcash: 1:20:240102:eliz@gnu.org::CjrVJsP3bdTHpqG5:0s5d X-Hashcash: 1:20:240102:68213@debbugs.gnu.org::QKmYMrMhcCfHpnAI:0U/1 X-Hashcash: 1:20:240102:jm@pub.pink::1YjyjdHAllL7pzNe:5VI9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277251 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi John, Eli, Eli Zaretskii writes: >> Date: Tue, 02 Jan 2024 10:42:59 -0600 >> From: john muhl via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Running =E2=80=98make -k -C test check-lisp=E2=80=99 on master with a bu= ild >> configured without X produces the following error: >>=20 >> cd emacs >> ./autogen.sh >> ./configure --without-x >> make -j$(nproc) >> make -k -C test check-lisp >> =E2=80=A6 >> In toplevel form: >> lisp/completion-preview-tests.el:23:2: Error: Symbol's value >> as variable is void: mouse-wheel-up-event >> make[3]: *** [Makefile:159: lisp/completion-preview-tests.elc] Error 1 >> make[3]: Target 'lisp/completion-preview-tests.log' not remade because= of errors. > > Thanks, please try again, I hope I fixed this. FWIW, I was going to suggest the attached patch, following how flymake.el handles this. But if the current solution works, that seems just as good. Thanks, Eshel --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Explicitly-require-mwheel-in-completion-preview.el.patch >From e4c13af2cc6c3a9839af5fb11b9e1a9e7da87475 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Tue, 2 Jan 2024 18:13:33 +0100 Subject: [PATCH] Explicitly require 'mwheel' in completion-preview.el * lisp/completion-preview.el: Require 'mwheel' in favor of '--without-x' builds. (Bug#68213) --- lisp/completion-preview.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el index da4afb8f66a..26e5af1287d 100644 --- a/lisp/completion-preview.el +++ b/lisp/completion-preview.el @@ -52,6 +52,8 @@ ;;; Code: +(require 'mwheel) + (defgroup completion-preview nil "In-buffer completion preview." :group 'completion) -- 2.42.0 --=-=-=--