From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74727: [PATCH] ; * lisp/apropos.el (apropos-library): Fix typo. Date: Sun, 08 Dec 2024 17:37:14 +0100 Message-ID: References: Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6782"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74727@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 08 17:38:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tKKIQ-0001bV-Vf for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Dec 2024 17:38:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKKIG-0006fB-DW; Sun, 08 Dec 2024 11:38:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKKIF-0006f1-Aa for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 11:38:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKKIE-0001mn-WE for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 11:38:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=2T/Az72QEUuiDVS4MEjlWmxw2Ryeyw+WciGznNRQ/OI=; b=N3k48NkbxicGBeGb04mXU+NdyOSJ87yDnETiZfrzqFYaLXSZKat/3iLUSmn5yRNKsXkqW2tRzcyfm1SHDAPshj/OR5jwi3hZrQfMULkDD719ER5QEIJ9vTNX6qPcT+d+cebSTXL5Nf3E/aMJSlL6pWudmAco0XYuZnD/dRP+trRXVOFSRcR3LOLd/attsN0GRdsP/BCULgBrUH/U3jBUaLWQitqO6eGsoiUfVdPlJ8NMKR6NFPYTwR+LkTTPu/CnrX7tISdmZJTG+IH9mQE+7m1m0U8p5DMREx6TRXDCMr9MT3LShx1+lKxougaTX353CwVppr+ADBu42Kn2dFtOCg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKKIE-0002Nn-Hh for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 11:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2024 16:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74727-submit@debbugs.gnu.org id=B74727.17336758449109 (code B ref 74727); Sun, 08 Dec 2024 16:38:02 +0000 Original-Received: (at 74727) by debbugs.gnu.org; 8 Dec 2024 16:37:24 +0000 Original-Received: from localhost ([127.0.0.1]:51497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKKHc-0002Mr-AJ for submit@debbugs.gnu.org; Sun, 08 Dec 2024 11:37:24 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:48504 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKKHZ-0002Mh-7M for 74727@debbugs.gnu.org; Sun, 08 Dec 2024 11:37:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1733675840; bh=fblmA7DVIGJDamH2uP4iWozHcsW4he2fAMzS1vMT/EM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=N0KSCA3xiYzH6tOqP8TuJAbzJCmeZmkFsBr3ng5ZnyfVdH5qKE5Vuh4WXcWHWma8Q +q/RnhYL58HEcC5bHGO9xLf01H0DFiNGwZKfK2i496RHG6W733lyGHG3rUp9I3h0Qx CuTaEacIYrrUkymBEk8NVLAp+2wWGSvRi6J33ZeLZ5Grxvq/8fGDpd+g47NeG/on0B qAN4Ja4xatdXtxwtOUYN7XJlMyM0QeGD8sItKtZHurZ7y+1cNmmHQY0l0R31xoLul3 Q6kEuJXDhlTChqmmnMPApqLplH9Uy0oDwaYn/kMyh/DJ1QjN935C3tKBAqkGrNEI7D rPSaER9KpiHUg== In-Reply-To: (Dmitry Gutov's message of "Sun, 8 Dec 2024 03:54:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296648 Archived-At: Dmitry Gutov writes: > Hi Eshel, > > On 07/12/2024 15:31, Eshel Yaron wrote: >> This patch fixes the issue described below, which IIUC originates in a >> mere typo in commit 671862f6b3089c3a503c1b6936a821ad54429359 >> >> 1. emacs -Q >> 2. M-x apropos-library elisp-mode RET >> 3. The*Apropos* buffer incorrectly lists methods that elisp-mode.el >> defines as if they were_features_ provided by the library. >> Accordingly, clicking on one of those references yields an error such >> as "Unknown library `xref-backend-definitions'" > > Thanks! That's a good suggestion. > > If you've started testing this area, though, do you know of a case when > dropping this case - like: > > diff --git a/lisp/apropos.el b/lisp/apropos.el > index 0655fecd0e8..9af8a7269ae 100644 > --- a/lisp/apropos.el > +++ b/lisp/apropos.el > @@ -733,7 +733,7 @@ apropos-library > ('t nil) ; Skip "was an autoload" entries. > ;; FIXME: Print information about each individual method: both > ;; its docstring and specializers (bug#21422). > - ('cl-defmethod (push (cadr x) provides)) > + ;; ('cl-defmethod (push (cadr x) provides)) > ;; FIXME: Add extension point (bug#72616). > (_ (let ((sym (or (cdr-safe x) x))) > (and sym (symbolp sym) > > ...does not work just as well? Yes, that seems to work too, and it doesn't produce duplicate entries for these definitions, so that's even better :) > From what I see now, any 'cl-defmethod' entry in load-history is > accompanied by a 'defun' entry anyway. And the original report > (https://debbugs.gnu.org/21422) was about an error being raised, but I > can't reproduce it now after commenting this line out. Same here. Eshel