From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51606: 29.0.50; [PATCH] Show offscreen context with properties Date: Fri, 26 Nov 2021 20:01:28 +0100 Message-ID: References: <86y263hrds.fsf@gnu.org> <835yt6ero5.fsf@gnu.org> <8335oaem70.fsf@gnu.org> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5016"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (darwin) Cc: arash@gnu.org, Richard Stallman , 51606@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 26 20:02:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqgU6-00017F-Co for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Nov 2021 20:02:11 +0100 Original-Received: from localhost ([::1]:54408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqgU5-0000Ww-Aj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Nov 2021 14:02:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqgTy-0000Wb-AE for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2021 14:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49014) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqgTy-0005jj-08 for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2021 14:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqgTx-0000Ql-MN for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2021 14:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Nov 2021 19:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51606 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 51606-submit@debbugs.gnu.org id=B51606.16379533031613 (code B ref 51606); Fri, 26 Nov 2021 19:02:01 +0000 Original-Received: (at 51606) by debbugs.gnu.org; 26 Nov 2021 19:01:43 +0000 Original-Received: from localhost ([127.0.0.1]:60557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqgTf-0000Pw-0z for submit@debbugs.gnu.org; Fri, 26 Nov 2021 14:01:43 -0500 Original-Received: from sonic301-22.consmr.mail.ir2.yahoo.com ([77.238.176.99]:45302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqgTc-0000Pf-Ai for 51606@debbugs.gnu.org; Fri, 26 Nov 2021 14:01:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1637953294; bh=F3GSBPRJuI+JCwuhL2j4Uf0/ZHcJTGf5WSxIC1rhwv8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=q0Nr8MwhJl+JE1XEcqFQy22Q8ggXSQigsPh4qKFUBby+Uup1+HHaBq6pFtBr3AOnUYetFWdRVYbuhzNZhoQY7idF9736OvcH7Ei6sILo2N2SdG38R5epLnfqZURzT6434BEuWvnjmcybWicQU6+3j9F5HJ2hjSoHaQmijuPDBw9DM1gufr0WegvSyir4M2HvgNPwCOkPDDPglKMhkZmWOf8sODoXM/KTq55POUXAEJUR0Ac6H9D4aJG/v3R4b4kOz+spAIMri+UAONP/0wskjhu4TKp2aBw8uP/tO5SkWc0Az1A9/QVNWCX9l+iakzXe88Ob0VWDaOijzbQIdPNLoQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1637953294; bh=JiZ3l6JLV5QUaEjlofz/rBA8rR4MZuP76w0cC6WCxmG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=aC1HkrYa2A6/qd7MeUIaN1trtpo6dazhxDox2v7/JNxPQQkx3wJ5Qb6AvtUEVaRTG5PgBFlUp2hjQ1PSxLn+oVtzVEph1TCUGZcD4JmHoCTDXMj5+hl3ObLNhOdt0I+svzlvKI8Cj2YO94EEsjjn4wXKw9CSOMlbgX9h6vt60fvbpQxKYfOsx7tlgPIy9mIH/ueVq0C41OfuaOQdr9CElNGtZXoJX5zBqjTZzaW3TBjntf1dZHFpP4A86CRI6XGZV454h+NjhdPyQFq7TnJ3fFi491f3gvCrGrbNfQ9Kx8b0AqtbvXIvmjr8HWo8FiczXmbdGzFtX0T3tCHvcyetSA== X-YMail-OSG: iiSo2CQVM1mZK6dWJav3zgQIpvkLOE4D_GFHA1GZvJr9lz6z2.CxUbara4TJovq JZuGnnGr4WC0qoDGtKSUQWn87DzTVfmFNm2oS3T0RRwQWaRArddj7Tfqev6tjcNKJeQ9VNxsrhs4 wkPNO1hNnLMFLutyQ2Q9xSWbfgb_YeB8jIjyipooB.GurpDuNUH2asdwEE5Ny6yYPkWgnH4Xesaz GE2H97aC6ZwHvky6RGdYlPsJnBSFs7X16vnZlgZAwfocIje.bqG3cnFH_G.p.0JsRs1pK6TnyWwD R1OjtyDOmHue0vsZxbcSW11pnBKiytG0kmoRaOw_SnbRINkYCOqJPUgqTiaTijSmolHFXEmwmNzS 13NAk6igXHU8eWKBx5N_JNz88CI0zb.QGmmjIC0WLYCZQGAWOc5_Tbp.haWppJ0pDFCdfR9it7Bu VfKpQWkZRWyuuDmDbpJvf6dNrIwB2470qqfPG9UIZNBzFYNF7Ekr50RU7Rm2hIG6Tm3fT1ySo3eC GlKDgiXzdKq0E.wcqAlJQKFhSu5NJIs5aH1QyffODNCYAQNtYlRj8wKYSnL4sWGUpOi1MiYXOdVf bB99b6UV5WzOmCZvIW7gn8Nlk32twuMIhiEJctVH8pC9EZypM5tOInrP8MF68vNREOJSSC4Gz712 VltEbRK3MlHfHeQWU4m6h6m_e21mgtEFuR0npw2tvpBQep9pwB_u6szRFewsJpNvKEdXFCK83zEP yr9voHXBRZ3LKGzdZt1gC9c2i1mUGG07jhQUSdlzbLqIvCHYZjEYtfZ9y.1dUXPviqyo_MX61UKV 9YlBgtnRXpuZWPkZhbbawO7N.VH2QKYbuqneQ4rpmx X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Fri, 26 Nov 2021 19:01:34 +0000 Original-Received: by kubenode514.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 1a21d61de17269017a4c62294d46242b; Fri, 26 Nov 2021 19:01:30 +0000 (UTC) In-Reply-To: <8335oaem70.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Nov 2021 16:01:07 +0200") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220886 Archived-At: Eli Zaretskii writes: >> > >> > Why do we remove the properties in the first place? Daniel, any >> > special reasons? >> >> No reason other than being cautious and "follow the traditional behavior >> of blink-matching-open". The code that I extracted from >> blink-matching-open to reuse it for show-paren-mode removed the text >> properties (see >> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/simple.el?h=emacs-28#n8608). >> If I'm not mistaken, this was apparently introduced in 2005 by Richard >> Stallman >> (https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-28&id=1d0e3fc84f058248515f242c0484a0dabfac95aa), >> but I don't know the reasons for the change. Perhaps it didn't look >> good on some TTY frames? > > I'd be surprised. > > Richard, do you remember why you removed text properties from the > blink-matching-open text it shows in the echo-area? BTW, the patch looks good to me. But if keeping the text properties is not a problem, I'd do that unconditionally, without adding another customization option. WDYT?