From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62453: 30.0.50; Semicolon in view-lossage yields wrong alignment Date: Sun, 26 Mar 2023 12:39:13 +0300 Message-ID: References: <83wn33ams3.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28280"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , 62453@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 26 11:40:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgMrS-00073C-71 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Mar 2023 11:40:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgMr7-0003bK-1p; Sun, 26 Mar 2023 05:40:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgMr5-0003az-4Q for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 05:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgMr4-0004a5-SE for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 05:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgMr4-0008N5-81 for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 05:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62453 X-GNU-PR-Package: emacs Original-Received: via spool by 62453-submit@debbugs.gnu.org id=B62453.167982356032108 (code B ref 62453); Sun, 26 Mar 2023 09:40:02 +0000 Original-Received: (at 62453) by debbugs.gnu.org; 26 Mar 2023 09:39:20 +0000 Original-Received: from localhost ([127.0.0.1]:44074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgMqN-0008Ln-JZ for submit@debbugs.gnu.org; Sun, 26 Mar 2023 05:39:19 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:40478 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgMqL-0008Lf-OT for 62453@debbugs.gnu.org; Sun, 26 Mar 2023 05:39:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1679823557; bh=DL0NtvPySUHCsrkSxM/iMd2ehe2Yq4ytW9iqn+cIopg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tNAM8CmsZ2Jtwl/0cekQUlk5frdoPkL8ojl5mkItp0Z04e9y8sKqdmi5YkrDVQtBh QSHYE1+25V2uarmJvIyifYJmAnaGo6E1LVSmm2fkFPbyGAkJRERWQvWuZ2HrP+Qd2m DlzJi4U4M2HP6G0gNZe6ak/9Ppp+mF9tO9JCwMu9FPsKyE+dQXx1bRKI6I3cHnMoVW D+wJ3IgCX5ZoqWEVaEZq41yWkpFGBFiMXjb4PwY5UdTBY2MB/yGL4LXAKcKLJYw8AZ ImwlbPLeMamza4HE01pY+K6JHGtVpdkGHUYZMOrkeC0hRA4uChMV8mI0F78YvU6+0z O2YfrWO7mYWYQ== In-Reply-To: <83wn33ams3.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Mar 2023 12:23:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258664 Archived-At: Eli Zaretskii writes: >> Date: Sun, 26 Mar 2023 08:33:18 +0300 >> From: Eshel Yaron via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> It seems like key sequences that end with a semicolon hinder the >> alignment in the `view-lossage` output buffer. This is a regression >> with respect to the (IMO correct) behavior in Emacs 27. >> >> [...] > > Does the patch below give good results? Thanks, that works well AFAICT from a few experiments. > Stefan, any better ideas? It looks like relying on comment-indent is > quite fragile here, as keys can include a semi-colon, which will be > interpreted as beginning a comment in too many places. I wonder > whether the two extra bindings I add below really plug all the holes. > > diff --git a/lisp/help.el b/lisp/help.el > index 3e94b50..13e61c0 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -689,6 +689,10 @@ view-lossage > (with-current-buffer standard-output > (goto-char (point-min)) > (let ((comment-start ";; ") > + ;; Prevent 'comment-indent' from handling a single > + ;; semicolon as the beginning of a comment. > + (comment-start-skip ";; ") > + (comment-use-syntax nil) > (comment-column 24)) > (while (not (eobp)) > (comment-indent)