From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sun, 08 Dec 2024 21:56:33 +0100 Message-ID: References: <86zflay7hh.fsf@gnu.org> <86jzcey3cu.fsf@gnu.org> <8634j1n9nx.fsf@gnu.org> <86ldwrkeiy.fsf@gnu.org> <865xnviliv.fsf@gnu.org> <86wmgbgxjx.fsf@gnu.org> <86ttbfgvyr.fsf@gnu.org> <86r06jgv1j.fsf@gnu.org> <86jzcafcj6.fsf@gnu.org> <867c8af514.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38096"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: trevor.m.murphy@gmail.com, monnier@iro.umontreal.ca, aaronjensen@gmail.com, 73862@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 08 21:57:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tKOL3-0009jj-VL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Dec 2024 21:57:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKOKu-0003iY-6p; Sun, 08 Dec 2024 15:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKOKs-0003iN-T7 for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 15:57:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKOKs-0003Nk-L8 for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 15:57:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ml+C0dXv5g571BWr3yEXCRMR8lf509wvYc7sk7QxZ0M=; b=hEZ89R3NidNZynNKwhkplumPAjFh0uKT24jDK/u/y6VurlMFfKgjZ2xUwdYZjwuxhVGnWFbWhh4phdKfBqQBxoT6NoPvVNV/HcwPGKRRFQA2VDQ2ieNM3HpL2F9QXIkAjfxF8SzWotUAwWxT12YJLeadLnI9JZu18jFyByFDpUctZDftg7nvLCaaTszjg/AINL3u05dKuaGtJXkQduCvzVubLQcwRoxo8ZN+ttkA+Bfh0805Yee+oqzHzkw4dTbyH1P7snxH4sIIKaG0wShiNyetJ94ApdP06ZSDknA3XNJVkpTR2b2kVKKW71t2r3LuUMkgPay792mKLehhbbuHSw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKOKs-0006rA-Eq for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2024 15:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2024 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173369139926314 (code B ref 73862); Sun, 08 Dec 2024 20:57:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 8 Dec 2024 20:56:39 +0000 Original-Received: from localhost ([127.0.0.1]:51852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKOKU-0006qK-Kn for submit@debbugs.gnu.org; Sun, 08 Dec 2024 15:56:39 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:58968 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKOKS-0006qC-HI for 73862@debbugs.gnu.org; Sun, 08 Dec 2024 15:56:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1733691396; bh=1Z60hxz7jgRkRuwGF5CugAkESuggacu1atWylabdBZI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ONj9tqA4AWX+C+7Uy1CeuUpmrk5Irkw0qpeiPWT9ihqO6MbFfFElKtxW8jA/qK+R9 uIYZIb4TWqrnzI3A5bc8xKokEOqDqemhp9QeSCDNOhud1bAs528Fd9UMUM7MZDqx+w roDC8setgtbM0FmiHhuznRluBi+x6R/uRxzJlwmBV36XtnH0GrNwdLcKMCFqYEyTvM fte9LWiPERqwDPSmzNtc2/hL448zwGtnsIk2zD5ZaT5yWPiqJeGvZZjEC2ZCZK9w8r rXX8JbOITB6rGwRv4kT9AuoJMQmVvZ/SatIohpnLpL0zAdpUCu7NlumgHB8ZSxG1Qh LN7vxWSwdGWqg== In-Reply-To: <867c8af514.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Dec 2024 19:39:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296668 Archived-At: Hi, Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: aaronjensen@gmail.com, monnier@iro.umontreal.ca, >> trevor.m.murphy@gmail.com, 73862@debbugs.gnu.org >> Date: Sun, 08 Dec 2024 17:29:04 +0100 >> >> Eli Zaretskii writes: >> >> > Did you try the patch I posted, and if you did, did it resolve your >> > original problems? >> >> I did now, and it doesn't entirely solve the problem: with this patch, >> after remapping header-line in one buffer, the remapping now works for >> that buffer as expected, but it still also "spreads" to other buffers, >> which is unexpected. > > What do you mean by "spreads to other buffers"? When you remapped > header-line face before this change on master, did it behave > differently, and if so, how? Yes, before the introduction of header-line-(in)active, remapping header-line buffer-locally in buffer A with face-remap-add-relative would only affect the appearance of the header line in windows that show buffer A. Now, with this change and your patch, doing so can also affect header lines in other windows, that display other buffers. Aaron shared a recipe to reproduce this behavior, copied here: --8<---------------cut here---------------start------------->8--- (setq header-line-format "Some header") (face-remap-set-base 'header-line 'highlight) (switch-to-buffer-other-window "new") ;; In new buffer/window: (setq header-line-format "Some header") (other-window 1) ;; In original buffer/window: (set-face-attribute 'default nil :height (+ (face-attribute 'default :height) 10)) --8<---------------cut here---------------end--------------->8--- Eshel