From: Leo <sdl.web@gmail.com>
To: 7548@debbugs.gnu.org
Cc: Karl Fogel <kfogel@red-bean.com>,
Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: bug#7548: 23.2.90; bookmark-default-handler wrong documentation
Date: Sun, 05 Dec 2010 14:14:21 +0000 [thread overview]
Message-ID: <m1mxok9uiq.fsf@cam.ac.uk> (raw)
In-Reply-To: <m1d3pif5v2.fsf@cam.ac.uk> (Leo's message of "Sat, 04 Dec 2010 05:45:53 +0000")
On 2010-12-04 05:45 +0000, Leo wrote:
> As far as I can tell the arg BMK-RECORD to bookmark-default-handler is
> not a bookmark record but a BOOKMARK. This is probably leftover. Could
> someone correct this? Thanks.
>
> Leo
Posted on Theirry's behalf.
================================
Leo <sdl.web@gmail.com> writes:
> Hello Thierry,
>
> I am wondering if you have time to comment on
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7548.
Yes indeed, in bookmark-default-handler but also on other places in
bookmark.el, the argument "bookmark" is confusing.
It refer sometime to a "bookmark-name" and sometimes to a
"bookmark-record".
That is a vestige of old version of `bookmark-prop-get' that was
accepting only "bookmark-record".
But now `bookmark-prop-get' accept both, so such comments in docstring
are no more needed.
Also the arg "bookmark" should be "bookmark-name" or "bookmark-record"
instead of "bookmark".
All functions bookmark-get-* are calling `bookmark-prop-get'.
,----[ Exemple ]
| (bookmark-prop-get '("Any comment on bug #7548 "
| (visits . 0)
| (time . 1291556487.101218)
| (position . 219)
| (location . "Gnus-art nnimap+gmail:INBOX:12912:<m1vd389yjo.fsf@cam.ac.uk>")
| (group . "nnimap+gmail:INBOX")
| (article . 12912)
| (message-id . "<m1vd389yjo.fsf@cam.ac.uk>")
| (handler . gnus-summary-bookmark-jump))
| 'handler)
| ==>gnus-summary-bookmark-jump
|
| (bookmark-prop-get "Any comment on bug #7548 " 'handler)
| ==>gnus-summary-bookmark-jump
`----
Maybe you can forward this to emacs-bug?
> Thanks.
>
> Leo
--
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
================================
next prev parent reply other threads:[~2010-12-05 14:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 5:45 bug#7548: 23.2.90; bookmark-default-handler wrong documentation Leo
2010-12-05 14:14 ` Leo [this message]
2010-12-08 8:12 ` bug#7548: [FIXED] " Karl Fogel
2010-12-10 8:55 ` Leo
2010-12-12 16:58 ` Karl Fogel
2010-12-12 20:26 ` Eli Zaretskii
2010-12-12 20:47 ` Karl Fogel
2010-12-12 22:28 ` Eli Zaretskii
2010-12-12 22:31 ` Eli Zaretskii
2010-12-13 0:35 ` Glenn Morris
2010-12-13 2:56 ` Glenn Morris
2010-12-13 17:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1mxok9uiq.fsf@cam.ac.uk \
--to=sdl.web@gmail.com \
--cc=7548@debbugs.gnu.org \
--cc=kfogel@red-bean.com \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).