From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Date: Sun, 29 May 2011 12:04:36 +0800 Message-ID: References: <87pqn2xw82.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306641917 13277 80.91.229.12 (29 May 2011 04:05:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 29 May 2011 04:05:17 +0000 (UTC) Cc: 8463@debbugs.gnu.org, Daniel Colascione To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 29 06:05:13 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QQXFU-0006Fz-FB for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2011 06:05:08 +0200 Original-Received: from localhost ([::1]:34053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQXFT-0003XO-Ly for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2011 00:05:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:42752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQXFQ-0003Vx-GX for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 00:05:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQXFP-0006l6-Ap for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 00:05:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQXFP-0006ky-5E for bug-gnu-emacs@gnu.org; Sun, 29 May 2011 00:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QQXFO-0002Ih-5j; Sun, 29 May 2011 00:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2011 04:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8463 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8463-submit@debbugs.gnu.org id=B8463.13066418978831 (code B ref 8463); Sun, 29 May 2011 04:05:02 +0000 Original-Received: (at 8463) by debbugs.gnu.org; 29 May 2011 04:04:57 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQXFI-0002IO-EV for submit@debbugs.gnu.org; Sun, 29 May 2011 00:04:56 -0400 Original-Received: from mail-pw0-f44.google.com ([209.85.160.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QQXFF-0002ID-UO for 8463@debbugs.gnu.org; Sun, 29 May 2011 00:04:54 -0400 Original-Received: by pwi5 with SMTP id 5so1281568pwi.3 for <8463@debbugs.gnu.org>; Sat, 28 May 2011 21:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=m2hjAnl04QKtC7dz8iQsJ3yHXJRmQbgvr+/mY2zdA4I=; b=oLxRBpVVHiPUWtB/JcuV1/WDGGfBPxLYvddzBs33yClDYnhfsVoLQ/cseo5Dt7gdCe Fp2w0J3rqsisBypu1s8C0ql8vidojv+ZsPKNKFwm596LJDCqXzGd/KAWRx8taei/VH57 ZGkRsVQeckRxKvLYuIM9xFgxdJpMI3PodNMHo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=U/9ysx1NUpsQs4Z2ikt06UnNhFlfzoc0O5ihRDjc8hpu6jd5xDir6yNujp3HVpDVE/ tNkW4NNdSl7fIc7jJCOapo2TlRHJrLOiGu4uAq9O3Q6Bo7rDgem1EZX4YbuovJ5Bo7XE mN/izRMP2gYuZTv39X8T8+bAIN31jny/w98x8= Original-Received: by 10.68.0.7 with SMTP id 7mr1635885pba.188.1306641888033; Sat, 28 May 2011 21:04:48 -0700 (PDT) Original-Received: from localhost ([123.114.55.92]) by mx.google.com with ESMTPS id i7sm1780529pbj.90.2011.05.28.21.04.43 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 28 May 2011 21:04:46 -0700 (PDT) In-Reply-To: <87pqn2xw82.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 28 May 2011 19:05:01 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 29 May 2011 00:05:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46777 Archived-At: On 2011-05-29 07:05 +0800, Chong Yidong wrote: [snipped 11 lines] > Looks good. I've made a couple of tweaks, and have committed it to > trunk. The C-c c-c binding was removed in favor of just C-x C-q, as > Stefan suggested. For now, I also left out the part where C-x C-q in > Occur Edit mode saves the associated buffers, because this doesn't seem > to be properly thought out; what if the buffers have no associated > files? > > Also, I added a small fix to occur-after-change-function to avoid > screwing up the Occur Edit buffer when multi-line text is inserted. > Since we can't create new Occur entries, this just ignores everything > after the inserted newline. If you want to try and handle this properly > (i.e. by inserting a new Occur entry for each inserted line), go ahead. Yidong, many thanks for the tweaks and fixes. Let's keep this bug open for a bit longer. I am thinking of generalising occur-edit-mode (probably rename it to match-line-edit) so that it covers buffers from grep and the like. Leo