From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#10934: 24.0.94; cperl system abbrevs fix Date: Sun, 04 Mar 2012 12:31:33 +0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330835673 20934 80.91.229.3 (4 Mar 2012 04:34:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Mar 2012 04:34:33 +0000 (UTC) To: 10934@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 04 05:34:33 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S439O-0006oA-49 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Mar 2012 05:34:26 +0100 Original-Received: from localhost ([::1]:38218 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S439N-0002AU-HU for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Mar 2012 23:34:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S439J-0002AD-JW for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:34:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S439H-0004ZJ-4B for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:34:21 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S439G-0004Z6-UU for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:34:19 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S4390-00015O-MK; Sat, 03 Mar 2012 23:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Mar 2012 04:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10934 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.13308355974121 (code B ref -1); Sun, 04 Mar 2012 04:34:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Mar 2012 04:33:17 +0000 Original-Received: from localhost ([127.0.0.1]:60523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S438C-00014B-5x for submit@debbugs.gnu.org; Sat, 03 Mar 2012 23:33:17 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52398) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S437v-00013T-3F for submit@debbugs.gnu.org; Sat, 03 Mar 2012 23:33:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S437F-00045C-7y for submit@debbugs.gnu.org; Sat, 03 Mar 2012 23:32:14 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:60782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S437F-000455-1n for submit@debbugs.gnu.org; Sat, 03 Mar 2012 23:32:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S437D-0001US-0z for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:32:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S436p-0003zr-9G for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:32:10 -0500 Original-Received: from mail-iy0-f169.google.com ([209.85.210.169]:60898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S436p-0003zg-1p for bug-gnu-emacs@gnu.org; Sat, 03 Mar 2012 23:31:47 -0500 Original-Received: by iajr24 with SMTP id r24so4954884iaj.0 for ; Sat, 03 Mar 2012 20:31:45 -0800 (PST) Received-SPF: pass (google.com: domain of sdl.web@gmail.com designates 10.50.193.226 as permitted sender) client-ip=10.50.193.226; Authentication-Results: mr.google.com; spf=pass (google.com: domain of sdl.web@gmail.com designates 10.50.193.226 as permitted sender) smtp.mail=sdl.web@gmail.com; dkim=pass header.i=sdl.web@gmail.com Original-Received: from mr.google.com ([10.50.193.226]) by 10.50.193.226 with SMTP id hr2mr3132104igc.34.1330835505283 (num_hops = 1); Sat, 03 Mar 2012 20:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; bh=s1aXYocNUkALHyVIbnhlcHYkBVtrLclrc1xZ3BKKlQM=; b=lGMtYc1V2fVLjS2/3CwTlKLAF32e+YQShR7OsmrjapD1kfXF/CE2Kf81BAyTW6IfOp F+bd5E4DPMExmzmm1BDulS9JYP5KBCckKUM328zb/ZzPA7dabsK7jAAa2QectkkvC6oJ iikIL1Pt0DgOYSZFLe33GiUrfLlQc0vSvrbgkRdpekV8oY4c0GVAvkeVNU0kaHMh6CPy RhXvkZRUBmAJ1ebIew3Q9nYwYniDuw0nEvjoOPG4Yedv2hOOD1FYSykcfBPa5TiqmjzZ /3fP6OiyW+Bz4tgQ861cnTq6wnVQrgUdde08A9r2zPFHjZvN63MyMhsZdqQcKDt2Ao8P H6Ew== Original-Received: by 10.50.193.226 with SMTP id hr2mr2608040igc.34.1330835505245; Sat, 03 Mar 2012 20:31:45 -0800 (PST) Original-Received: from localhost ([111.194.103.246]) by mx.google.com with ESMTPS id dl10sm7117270igb.9.2012.03.03.20.31.39 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Mar 2012 20:31:44 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57474 Archived-At: In cperl-mode it uses a hack to avoid having programmably-defined abbrevs written to the abbrev file. This is not safe i.e. those abbrevs can still be saved to disk, and users might be tricked to edit them but lose their editing because they are redefined by cperl-mode. I think the following patch is due. commit 0d5a31c8fc9faf708e98bee32913bc2dfe31bf7d Date: Fri Apr 16 21:09:01 2010 +0100 Fix cperl-mode abbrevs See http://permalink.gmane.org/gmane.emacs.devel/123752. --- lisp/progmodes/cperl-mode.el | 44 ++++++++++++++++++++---------------------- 1 file changed, 21 insertions(+), 23 deletions(-) Modified lisp/progmodes/cperl-mode.el diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index eb881d01..3a332b24 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -1714,29 +1714,27 @@ (defun cperl-mode () [(control c) (control h) f]))) (setq major-mode cperl-use-major-mode) (setq mode-name "CPerl") - (let ((prev-a-c abbrevs-changed)) - (define-abbrev-table 'cperl-mode-abbrev-table '( - ("if" "if" cperl-electric-keyword 0) - ("elsif" "elsif" cperl-electric-keyword 0) - ("while" "while" cperl-electric-keyword 0) - ("until" "until" cperl-electric-keyword 0) - ("unless" "unless" cperl-electric-keyword 0) - ("else" "else" cperl-electric-else 0) - ("continue" "continue" cperl-electric-else 0) - ("for" "for" cperl-electric-keyword 0) - ("foreach" "foreach" cperl-electric-keyword 0) - ("formy" "formy" cperl-electric-keyword 0) - ("foreachmy" "foreachmy" cperl-electric-keyword 0) - ("do" "do" cperl-electric-keyword 0) - ("=pod" "=pod" cperl-electric-pod 0) - ("=over" "=over" cperl-electric-pod 0) - ("=head1" "=head1" cperl-electric-pod 0) - ("=head2" "=head2" cperl-electric-pod 0) - ("pod" "pod" cperl-electric-pod 0) - ("over" "over" cperl-electric-pod 0) - ("head1" "head1" cperl-electric-pod 0) - ("head2" "head2" cperl-electric-pod 0))) - (setq abbrevs-changed prev-a-c)) + (define-abbrev-table 'cperl-mode-abbrev-table + '(("if" "if" cperl-electric-keyword 0 t) + ("elsif" "elsif" cperl-electric-keyword 0 t) + ("while" "while" cperl-electric-keyword 0 t) + ("until" "until" cperl-electric-keyword 0 t) + ("unless" "unless" cperl-electric-keyword 0 t) + ("else" "else" cperl-electric-else 0 t) + ("continue" "continue" cperl-electric-else 0 t) + ("for" "for" cperl-electric-keyword 0 t) + ("foreach" "foreach" cperl-electric-keyword 0 t) + ("formy" "formy" cperl-electric-keyword 0 t) + ("foreachmy" "foreachmy" cperl-electric-keyword 0 t) + ("do" "do" cperl-electric-keyword 0 t) + ("=pod" "=pod" cperl-electric-pod 0 t) + ("=over" "=over" cperl-electric-pod 0 t) + ("=head1" "=head1" cperl-electric-pod 0 t) + ("=head2" "=head2" cperl-electric-pod 0 t) + ("pod" "pod" cperl-electric-pod 0 t) + ("over" "over" cperl-electric-pod 0 t) + ("head1" "head1" cperl-electric-pod 0 t) + ("head2" "head2" cperl-electric-pod 0 t))) (setq local-abbrev-table cperl-mode-abbrev-table) (if (cperl-val 'cperl-electric-keywords) (abbrev-mode 1))