unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#11499: 24.0.96; function arglist regression
@ 2012-05-17  7:57 Leo
  2012-05-17 15:16 ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Leo @ 2012-05-17  7:57 UTC (permalink / raw)
  To: 11499

Stefan,

,----[ C-h f registerv-make RET ]
| registerv-make is a compiled Lisp function in `register.el'.
| 
| (registerv-make (DATA &key PRINT-FUNC JUMP-FUNC INSERT-FUNC))
| 
[snipped 12 lines]
| [back]
`----

I remembered you fixed some bug about the arglist long ago and I just
realised there is one extra pair of () around the args. Instead it
should be:

(registerv-make DATA &key PRINT-FUNC JUMP-FUNC INSERT-FUNC)

Leo





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#11499: 24.0.96; function arglist regression
  2012-05-17  7:57 bug#11499: 24.0.96; function arglist regression Leo
@ 2012-05-17 15:16 ` Stefan Monnier
  2012-05-17 15:54   ` Leo
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2012-05-17 15:16 UTC (permalink / raw)
  To: Leo; +Cc: 11499-done

Version: 24.1

> | (registerv-make (DATA &key PRINT-FUNC JUMP-FUNC INSERT-FUNC))

I believe the patch below fixed it, thanks,


        Stefan


=== modified file 'lisp/emacs-lisp/cl-macs.el'
--- lisp/emacs-lisp/cl-macs.el	2012-05-06 15:38:30 +0000
+++ lisp/emacs-lisp/cl-macs.el	2012-05-17 15:11:30 +0000
@@ -318,8 +318,9 @@
                         (require 'help-fns)
                         (cons (help-add-fundoc-usage
                                (if (stringp (car hdr)) (pop hdr))
-                               (format "(fn %S)"
-                                       (cl--make-usage-args orig-args)))
+                               (format "%S"
+                                       (cons 'fn
+                                             (cl--make-usage-args orig-args))))
                               hdr)))
 		    (list (nconc (list 'let* bind-lets)
 				 (nreverse bind-forms) body)))))))






^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#11499: 24.0.96; function arglist regression
  2012-05-17 15:16 ` Stefan Monnier
@ 2012-05-17 15:54   ` Leo
  2012-05-18 18:00     ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Leo @ 2012-05-17 15:54 UTC (permalink / raw)
  To: 11499

On 2012-05-17 23:16 +0800, Stefan Monnier wrote:
> Version: 24.1

Seems installed on trunk instead of the emacs-24 branch.

Leo





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#11499: 24.0.96; function arglist regression
  2012-05-17 15:54   ` Leo
@ 2012-05-18 18:00     ` Stefan Monnier
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2012-05-18 18:00 UTC (permalink / raw)
  To: Leo; +Cc: 11499

>> Version: 24.1
> Seems installed on trunk instead of the emacs-24 branch.

That's just an optical illusion.


        Stefan





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-05-18 18:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-17  7:57 bug#11499: 24.0.96; function arglist regression Leo
2012-05-17 15:16 ` Stefan Monnier
2012-05-17 15:54   ` Leo
2012-05-18 18:00     ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).