From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48884: 28.0.50; Possible memory leak in window-text-pixel-size (bidi cache) Date: Sun, 06 Jun 2021 23:38:45 +0200 Message-ID: References: Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25287"; mail-complaints-to="usenet@ciao.gmane.io" To: 48884@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 06 23:40:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lq0VG-0006KN-80 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 23:40:18 +0200 Original-Received: from localhost ([::1]:59412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lq0VE-00047r-PG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Jun 2021 17:40:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq0V0-00047c-Vz for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 17:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lq0V0-0007CP-Oe for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 17:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lq0V0-0002tf-Ko for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 17:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jun 2021 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48884 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162301554211053 (code B ref -1); Sun, 06 Jun 2021 21:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Jun 2021 21:39:02 +0000 Original-Received: from localhost ([127.0.0.1]:54068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lq0U2-0002sC-6s for submit@debbugs.gnu.org; Sun, 06 Jun 2021 17:39:02 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lq0Tz-0002rw-PW for submit@debbugs.gnu.org; Sun, 06 Jun 2021 17:39:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq0Tz-0003jA-Gm for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 17:38:59 -0400 Original-Received: from sonic316-12.consmr.mail.bf2.yahoo.com ([74.6.130.122]:42754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lq0Tv-0006V7-Uz for bug-gnu-emacs@gnu.org; Sun, 06 Jun 2021 17:38:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1623015532; bh=HCd7UCPxIkAoF2Y3cEQPFmjVuLbA7qqPqYcehMpM3ts=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=ueJpJiR2IpriVVE08H4G4ao1+Qrn0QvSRd8kYuVCMwcgsbjuyT+uq4/m/IGEy/vAqHSA1HRnsVu1omdSBDaDc9jFdMmoH4qbyNeKxf0lrBxYHvL/mLsSqu9kyfmkuHjaY0Z5FpyUiIF/Nr0m9dYGF5Y5QvwVm9t81N9i+LdVhI1XZweEARUcSRA79znWiW6rm+tDOBm3Q5j9ERX5hvghKJLkoeuPOdNkuN1Mr1Aa8iP+aJ8VLuBa1/R3j5Mq7woGQqPAQdQcv0+Jio4Sw72FPsyzaMYg2HLkFIHQBR+l2iG37b3MCBcj+9LIOBDzL/OnW0f5D1MYrMj6R5Y4aPVBlA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1623015533; bh=Pdq8OVmOgw+wgR2Zzuv7hkUq3Sc7b8IimXgzrNia0kc=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=c1kisQ0WGmpI8g8gBZQJ3s3QQaAWNHPvSK3Kyx0KHxG19vi8r/NOACX8i6w/nSTCAYh1kVtX/8WQf4qWpMNU/qNnhIGzLhdoWFi0vYO5XoqluvIpb+dJ9zYgV1TNUOy4vVDOHgarFi1N6h0RI8uQEQiDsBfvdUSoUz3Y5ZJ3bwMeHKvlw6e2nLnSlMuisoeLzTFb/vz0i2DjccZTVLawgxkIkOQpuykXuzutSo+uvsZ4ZN511FJVMncKCFQllNcACsXy/ydQljU8fdoeFmMFQjgdexea4/r3EJh3zSGUIlw7QYsbGup2pysIc+pU9OJbtkbDeI7d9dX9X8cWdlpTzw== X-YMail-OSG: CcvUO1kVM1nc2frBguzwutFyHfqafRyfy7dA7rvWk.rPP6lwXWIcpcZiYeIxzrl wu0Gh9SIdo9uS.k_k7zDcbNf393EQ8yr25CFU0.1BVFAzKetdb.OCr.M.ADdHusov3rKE1AMzELB kkkYSaSBVhqig4u_f6sz1mUWDAOig9UxWwjdEkx3wA.COid76..UFakdbWI0wZsdajZK7cGaWzlN D2WM1mRyHRBp3xw0fUDtxnWrCD2l8jTXnZU8WdkGY9FRUXuSplolo2w2W8F3guD5O3l.g7uob_mQ n7UqGWaRZ0q4ePT2hZp3nvGdf6m9uiihXZVn_RJPLbuV0UWS7RTbS_yI10AcKPxGZkN04wKpFy2o bBu3XCgAXjxLfsHQ26n0KALU9STum5OaImxsjHFk_tfk9jG7L_VOuMxOJ3pzY8pjvXlBJFkNZ4kJ THjWYpWErC5VD_j6vMuRj0A2.Lw.foiQAG8FcikMsAnl2bLrtfWzGeydc2MuNDyMgOocDMuaN1.c p0UxglpY52eR4jYbG_Ul_Yu27v06nPLwmNjYE6OBwNZwIt_mIH7.iMQhAHbWKs3XFhN3Lz8rUBP3 J1Hqx6k3P0nL9jW5sxCs78e0t3flNY86mpA0EeJ7fpkqTm.b2e3C0VXkDzWkMK2SSUikPZ7lGHDT BZkpcHHJuyRN8c_B2K_fCBxJarA9xLKVHe1TUDdk0H2PsteXNcIsahXX66tMvY.RvHCuMaNAprCd VAWd9dbEYeZtNTYWSU8DEdRBA73Dq08oY5eL.wJ37bnpe2_7hFE.tDwNWQg.TS02QhIAC1J6ZGSS wYii10.xHSffNwqCnLXyk2sYXm_8UBK7ty9ovD8wBc X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.bf2.yahoo.com with HTTP; Sun, 6 Jun 2021 21:38:52 +0000 Original-Received: by kubenode531.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID cb1f906fc1d7f33575287d8a747dbc19; Sun, 06 Jun 2021 21:38:47 +0000 (UTC) X-Mailer: WebService/1.1.18368 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=74.6.130.122; envelope-from=mardani29@yahoo.es; helo=sonic316-12.consmr.mail.bf2.yahoo.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_05=-0.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208162 Archived-At: I'm investigating how Emacs handles memory and I think I've found a memory leak in window-text-pixel-size. This function is called by minibuffer completion packages like selectrum or vertico, so even if each leak is around 7,5 KB per minibuffer interaction on my system, users interact a lot with the minibuffer in a typical Emacs session, so the amount of leaked memory may be substantial if an Emacs session spans weeks. I don't have a minimum program to reproduce it yet, but here's what I see when I trace the code when I use one of the aforementioned packages: In line 10775 of xdisp.c, SAVE_IT allocates some data and makes it2data point to it. if (IT_CHARPOS (it) > end) returns false if (!NILP (x_limit)) returns false if (it.current_y > start_y) returns true and sets start_x = 0; if (y > max_y) returns false if (EQ (mode_and_header_line, Qtab_line) || EQ (mode_and_header_line, Qt)) returns false. The same for the header line and mode line. bidi_unshelve_cache (itdata, false) unshelves the cache pointed by itdata (not it2data). if (old_b) returns false The function exits and the pointer variable it2data goes out of scope, leaking the memory it points to. Thanks.