From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72759: 31.0.50; Emacs hangs with open-paren-in-column-0-is-defun-start set to nil Date: Thu, 22 Aug 2024 19:08:23 +0200 Message-ID: References: <868qwou8pv.fsf@gnu.org> <861q2gu56u.fsf@gnu.org> <86msl4slwv.fsf@gnu.org> <86ed6gsfm3.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4949"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72759@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 22 19:09:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shBJi-00014n-FN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Aug 2024 19:09:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shBJR-0002au-Rc; Thu, 22 Aug 2024 13:09:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shBJE-0002Yi-E2 for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 13:09:16 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shBJE-0005zA-2m for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 13:09:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=y1db9q7NxzYk+jwcV/djA3itjU/nCFZZcbZ0ENvW8tA=; b=Q5w1JQ768fvp9Zr2DaSRvKBbjdpdPLQrR1RC7CBP63lkzelrZXSUrPNzwRPW1CMjOr/dvsEBIlgKoDKJlC79xmLzcFIl+R2oLaDdiR+P7D9najuBzVBeKnHuXU+N3WoEu/u9c3TNvY0ma8R5rVMiUhTOVYaMlX+XRq86+GJ9aQLeRYb3ujwWKRSNI85E6gwrSIIwLP4Sl9fmUciBcjrygciVc3slT4usZT/xKwqkFIz25F/7Cd4u/T0M3Os8ZZcg8PaRny+GlDU2bIW8B7M4nG5+P31+YUepndItmClqPHRc0OHVV83dDeGx9HiFt0cqmUsexHKIdbLxX7xS8ES9/g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shBJy-0000Pq-2r for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Aug 2024 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72759 X-GNU-PR-Package: emacs Original-Received: via spool by 72759-submit@debbugs.gnu.org id=B72759.17243465551532 (code B ref 72759); Thu, 22 Aug 2024 17:10:02 +0000 Original-Received: (at 72759) by debbugs.gnu.org; 22 Aug 2024 17:09:15 +0000 Original-Received: from localhost ([127.0.0.1]:38280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shBJD-0000Oe-BM for submit@debbugs.gnu.org; Thu, 22 Aug 2024 13:09:15 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:35460 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shBJA-0000OW-RI for 72759@debbugs.gnu.org; Thu, 22 Aug 2024 13:09:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1724346506; bh=DRKNdn96tIdOPm/PHglHVL86+ftiat67GxgOc1Ktcw8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dP2s38H3LXuKGLYoA1Czto7Fd0pLy9n9ssgd29YGMTz55Ucb7zZ7PTvz+KvqkolCV bMRFxRQIHEiDcZVk2DqzfVJ5Hb4H18bDSLB27iwl7EQm6UMFCswa06a7W6yJDbKrgx K0OrTp36GMUUkYO97xxFUKlv0hyMI9NcpNcHRtD4k/Yi2qnbPyCMQrqfHfyfXVDILr ZEb3bjQCCTgIcYPwPVTjTCGIIRcLtH58xuc03Fdo6CyBCeeVPDahQGoCdcwfWS88W1 SpjWRvEid1SE2RY9Cs3qA26ivPz2dPVz27pPIZtxUxXLe2Wo4DxzXrbRw/7Y4vyy/z 10AjtjLMwlFSw== In-Reply-To: <86ed6gsfm3.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 22 Aug 2024 19:10:28 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290549 Archived-At: Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: 72759@debbugs.gnu.org >> Date: Thu, 22 Aug 2024 17:49:22 +0200 >> >> After taking another look, ISTM that the problem is that checkdoc >> assumes that beginning-of-defun either advances point or returns nil, >> but since beginning-of-defun unconditionally moves to the beginning of >> the line, it can in fact find a defun ahead of point (and thus return >> non-nil) but then move back to the beginning of the line, so point is >> unchanged. So the assumption in checkdoc doesn't always hold when >> open-paren-in-column-0-is-defun-start is nil. This assumption should >> still hold, however, for beginning-of-defun-raw, which doesn't go back >> to the beginning of the line. >> >> This suggests the following change, which indeed seems to fix the hang: >> >> >> diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el >> index 949ca6b74ad..65226d8ee44 100644 >> --- a/lisp/emacs-lisp/checkdoc.el >> +++ b/lisp/emacs-lisp/checkdoc.el >> @@ -981,7 +981,7 @@ checkdoc-next-docstring >> Return nil if there are no more doc strings." >> (let (found) >> (while (and (not (setq found (checkdoc--next-docstring))) >> - (beginning-of-defun -1))) >> + (beginning-of-defun-raw -1))) >> found)) > > But the doc string of beginning-of-defun-raw says, inter alia: > > This is identical to function `beginning-of-defun', except that point > does not move to the beginning of the line when `defun-prompt-regexp' > is non-nil. ^^^^^^^^^^^^^^^^^^^^^^^^^^ > ^^^^^^^^^^ > > Does that mean defun-prompt-regexp was non-nil in your case? The > default is nil. No, defun-prompt-regexp was (and is) the default, nil.