From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#9453: 23.3; rcirc: INVITE command handled incorrectly Date: Wed, 07 Sep 2011 10:27:52 +0800 Message-ID: References: <87pqjd76tx.fsf@nexoid.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315362565 32408 80.91.229.12 (7 Sep 2011 02:29:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 7 Sep 2011 02:29:25 +0000 (UTC) Cc: 9453@debbugs.gnu.org To: "Peter Feigl" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 07 04:29:21 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R17tB-0006r5-HK for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Sep 2011 04:29:21 +0200 Original-Received: from localhost ([::1]:48054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R17tA-00083B-Ng for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 22:29:20 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:44464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R17t7-00082p-Bg for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 22:29:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R17t2-0006WM-OI for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 22:29:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R17t2-0006WI-Mp for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 22:29:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R17wk-0008CA-FN; Tue, 06 Sep 2011 22:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Sep 2011 02:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9453-submit@debbugs.gnu.org id=B9453.131536274031448 (code B ref 9453); Wed, 07 Sep 2011 02:33:02 +0000 Original-Received: (at 9453) by debbugs.gnu.org; 7 Sep 2011 02:32:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R17w3-0008B9-NU for submit@debbugs.gnu.org; Tue, 06 Sep 2011 22:32:20 -0400 Original-Received: from mail-pz0-f47.google.com ([209.85.210.47]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R17w1-0008B2-Fa for 9453@debbugs.gnu.org; Tue, 06 Sep 2011 22:32:18 -0400 Original-Received: by pzk2 with SMTP id 2so9437874pzk.20 for <9453@debbugs.gnu.org>; Tue, 06 Sep 2011 19:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=YgwrvZxs4KpcpURacCau7mCdU8lIJuUprTMn7p391xo=; b=esBs7ow3Nl1rLT6BN07wfuvL5/0VXdfJeX5cvIZDNnQglA5IqbwEJXAHHLca7MOkXv wVnhesbZmaU9yDQLE4avEXSzEJbQ3RrEt8oO6E7WlQC4c+XAYXyCTyKlJ2EgePgyyQdf +l20ZUEfpg2oiXe3xiny2JLcgwGcRKI68GgYQ= Original-Received: by 10.68.1.104 with SMTP id 8mr3694034pbl.91.1315362506428; Tue, 06 Sep 2011 19:28:26 -0700 (PDT) Original-Received: from localhost ([114.247.10.82]) by mx.google.com with ESMTPS id i4sm1574536pbr.4.2011.09.06.19.28.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 06 Sep 2011 19:28:25 -0700 (PDT) In-Reply-To: <87pqjd76tx.fsf@nexoid.at> (Peter Feigl's message of "Tue, 06 Sep 2011 22:29:30 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.8) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 06 Sep 2011 22:33:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50652 Archived-At: On 2011-09-07 04:29 +0800, Peter Feigl wrote: > According to RFC 2812 the INVITE command has two parameters: the user > and the channel. If I connect to any server via M-x rcirc, join a > channel and type "/invite user #channel", RCIRC incorrectly > sends "INVITE :user #channel". It should instead send "INVITE user > #channel" (note the missing colon). This leads to the server rejecting > the incorrect invite. My reading of the code seems to suggest all commands that take more than one params must be defined by defun-rcirc-command otherwise are incorrectly handled. Could you try the following patch (against emacs-23.3)? Changes in HEAD lisp/net/rcirc.el | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) Modified lisp/net/rcirc.el diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 2baaa951..c0333313 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -2042,6 +2042,16 @@ (defun-rcirc-command join (channel) (when (not (eq (selected-window) (minibuffer-window))) (switch-to-buffer buffer)))) +(defun-rcirc-command invite (nick-channel) + "Invite NICK to CHANNEL." + (interactive (list + (concat + (completing-read "Invite nick: " + (with-rcirc-server-buffer rcirc-nick-table)) + " " + (read-string "Channel: ")))) + (rcirc-send-string process (concat "INVITE " nick-channel))) + ;; TODO: /part #channel reason, or consider removing #channel altogether (defun-rcirc-command part (channel) "Part CHANNEL."