From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#16804: 24.3.50; [PATCH] fix with-silent-modifications Date: Thu, 20 Feb 2014 13:57:59 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1392875956 9684 80.91.229.3 (20 Feb 2014 05:59:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Feb 2014 05:59:16 +0000 (UTC) Cc: 16804@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 20 06:59:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WGMfL-0007xP-DD for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Feb 2014 06:59:23 +0100 Original-Received: from localhost ([::1]:36380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGMfK-0003SH-RL for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Feb 2014 00:59:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGMf8-0003D2-Sp for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2014 00:59:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGMf1-0001ke-Hn for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2014 00:59:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGMf1-0001ka-E6 for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2014 00:59:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WGMf0-0007Kk-Iu for bug-gnu-emacs@gnu.org; Thu, 20 Feb 2014 00:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Feb 2014 05:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16804-submit@debbugs.gnu.org id=B16804.139287589928122 (code B ref 16804); Thu, 20 Feb 2014 05:59:02 +0000 Original-Received: (at 16804) by debbugs.gnu.org; 20 Feb 2014 05:58:19 +0000 Original-Received: from localhost ([127.0.0.1]:32893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGMeH-0007JU-J5 for submit@debbugs.gnu.org; Thu, 20 Feb 2014 00:58:18 -0500 Original-Received: from mail-pa0-f41.google.com ([209.85.220.41]:33006) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGMeE-0007JE-JV for 16804@debbugs.gnu.org; Thu, 20 Feb 2014 00:58:15 -0500 Original-Received: by mail-pa0-f41.google.com with SMTP id fa1so1460339pad.14 for <16804@debbugs.gnu.org>; Wed, 19 Feb 2014 21:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=MxhRKsYVEAuov14QNnumxnLRLL4H7fMduMRFL86Uj9Q=; b=HL3Y9pnewKLJ3Rp5vq42/wy+HOdMcXfOz/JbDtTJUCMQdCaF02zi9RpMM8AIaApPUb dv3dyspGGgEIlAFRvm9HyKhb9JSLmu126jpjMDY7KrBjidWP9rBY8S+abKgEGZQazt5p B2o8ittKdgB4QiSBccJx6hEpGBAOyh4/gc3SsNhk4Q+wo0F65rk5bO5nHYGNa+Ni6hSt SB10SUb3/tFrF4Tx0zw3uV5lpfPbO957+NbFpXP/tsxSEsZFcRXp/p0z7n1Kw6phCkaI fWfYj6pWXwQfbGcuv66LbCjnx2m0VZoPcycM0nJ0bFfKo28xhQ1MnjB/Xf2/ELaRSaiQ GtEA== X-Received: by 10.66.145.166 with SMTP id sv6mr45028689pab.31.1392875888032; Wed, 19 Feb 2014 21:58:08 -0800 (PST) Original-Received: from Zeuss-MacBook.local ([123.122.50.191]) by mx.google.com with ESMTPSA id hr2sm6957710pbb.8.2014.02.19.21.58.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Feb 2014 21:58:07 -0800 (PST) Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Wed, 19 Feb 2014 23:57:54 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:85927 Archived-At: On 2014-02-20 12:57 +0800, Stefan Monnier wrote: > That doesn't change anything to the fact that calling something like > sit-for from within a with-silent-modifications is a problem, regardless > of buffer-file-name. E.g. it will cause the process filter not to mark > the new text for highlighting, so it can screw up *compilation*. I see. Could you help document the delicacy of with-silent-modifications, or people will not correctly use it? >>> Again, a backtrace would be much more useful. >> There is no backtrace. > > Of course there is. I know there is no error signaled, but you can > still get a backtrace by calling (backtrace), or (debug). I see and sorry I misunderstood. Since input-pending-p is changed in 24.4 not to run timers by default, the backtrace is obtained in 24.3 and as expected: ...... timer-event-handler([t 0 0 200000 t #[...] nil idle 0]) input-pending-p() js2-parse-statement() js2-parse-function-body([cl-struct-js2-function-node 108 3537 1 nil nil n= il ((once . [cl-struct-js2-symbol 121 "once" [cl-struct-js2-name-node 39 0 = 4 nil [cl-struct-js2-var-init-node 121 4 106 nil [cl-struct-js2-var-decl-no= de 121 0 110 nil [cl-struct-js2-expr-stmt-node 132 120 111 nil [cl-struct-j= s2-block-node 128 3571 1 nil nil ...] #6] (#5) 121] #4 [cl-struct-js2-call-= node 38 7 99 nil #5 [cl-struct-js2-prop-get-node 33 0 6 nil #6 3703 [cl-str= uct-js2-name-node 39 0 1 nil #7 "_" nil] [cl-struct-js2-name-node 39 2 4 ni= l #7 "once" nil]] ([cl-struct-js2-function-node 108 7 91 nil #6 nil nil #0 = nil nil nil nil 0 nil nil 0 FUNCTION FUNCTION_EXPRESSION nil nil nil [cl-st= ruct-js2-block-node 128 11 80 nil #8 ...] 8 9 t t nil nil]) 6 98]] "once" n= il]]) (self . [cl-struct-js2-symbol 121 "self" [cl-struct-js2-name-node 39 = 0 4 nil [cl-struct-js2-var-init-node 121 4 11 nil [cl-struct-js2-var-decl-n= ode 121 0 15 nil [cl-struct-js2-expr-stmt-node 132 97 16 nil [cl-struct-js2= -block-node 128 3571 1 nil nil ...] #6] (#5) 121] #4 [cl-struct-js2-keyword= -node 43 7 4 nil #5]] "self" nil]]) (context . [cl-struct-js2-symbol 86 "co= ntext" [cl-struct-js2-name-node 39 25 7 nil #0 "context" nil]]) (callback .= [cl-struct-js2-symbol 86 "callback" [cl-struct-js2-name-node 39 15 8 nil #= 0 "callback" nil]]) (name . [cl-struct-js2-symbol 86 "name" [cl-struct-js2-= name-node 39 9 4 nil #0 "name" nil]])) nil nil nil nil nil 0 nil nil 0 FUNC= TION FUNCTION_EXPRESSION nil ([cl-struct-js2-name-node 39 9 4 nil #0 "name"= nil] [cl-struct-js2-name-node 39 15 8 nil #0 "callback" nil] [cl-struct-js= 2-name-node 39 25 7 nil #0 "context" nil]) nil nil 8 32 t nil nil nil]) js2-parse-function(FUNCTION_EXPRESSION 3537 nil nil) js2-parse-function-expr() js2-parse-primary-expr() js2-parse-member-expr(t) js2-parse-unary-expr() js2-parse-mul-expr() js2-parse-add-expr() js2-parse-shift-expr() js2-parse-rel-expr() js2-parse-eq-expr() js2-parse-bit-and-expr() ...... nxml has both input-pending-p and sit-for, see rng-validate-while-idle-continue-p in rng-valid.el > Stefan Is there something better than let-binding buffer-file-name and buffer-file-truename? Leo