From: Leo Liu <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16804@debbugs.gnu.org
Subject: bug#16804: 24.3.50; [PATCH] fix with-silent-modifications
Date: Thu, 20 Feb 2014 13:57:59 +0800 [thread overview]
Message-ID: <m1iosae36g.fsf@gmail.com> (raw)
In-Reply-To: <jwvvbwamlj4.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Wed, 19 Feb 2014 23:57:54 -0500")
On 2014-02-20 12:57 +0800, Stefan Monnier wrote:
> That doesn't change anything to the fact that calling something like
> sit-for from within a with-silent-modifications is a problem, regardless
> of buffer-file-name. E.g. it will cause the process filter not to mark
> the new text for highlighting, so it can screw up *compilation*.
I see. Could you help document the delicacy of
with-silent-modifications, or people will not correctly use it?
>>> Again, a backtrace would be much more useful.
>> There is no backtrace.
>
> Of course there is. I know there is no error signaled, but you can
> still get a backtrace by calling (backtrace), or (debug).
I see and sorry I misunderstood.
Since input-pending-p is changed in 24.4 not to run timers by default,
the backtrace is obtained in 24.3 and as expected:
......
timer-event-handler([t 0 0 200000 t #[...] nil idle 0])
input-pending-p()
js2-parse-statement()
js2-parse-function-body([cl-struct-js2-function-node 108 3537 1 nil nil nil ((once . [cl-struct-js2-symbol 121 "once" [cl-struct-js2-name-node 39 0 4 nil [cl-struct-js2-var-init-node 121 4 106 nil [cl-struct-js2-var-decl-node 121 0 110 nil [cl-struct-js2-expr-stmt-node 132 120 111 nil [cl-struct-js2-block-node 128 3571 1 nil nil ...] #6] (#5) 121] #4 [cl-struct-js2-call-node 38 7 99 nil #5 [cl-struct-js2-prop-get-node 33 0 6 nil #6 3703 [cl-struct-js2-name-node 39 0 1 nil #7 "_" nil] [cl-struct-js2-name-node 39 2 4 nil #7 "once" nil]] ([cl-struct-js2-function-node 108 7 91 nil #6 nil nil #0 nil nil nil nil 0 nil nil 0 FUNCTION FUNCTION_EXPRESSION nil nil nil [cl-struct-js2-block-node 128 11 80 nil #8 ...] 8 9 t t nil nil]) 6 98]] "once" nil]]) (self . [cl-struct-js2-symbol 121 "self" [cl-struct-js2-name-node 39 0 4 nil [cl-struct-js2-var-init-node 121 4 11 nil [cl-struct-js2-var-decl-node 121 0 15 nil [cl-struct-js2-expr-stmt-node 132 97 16 nil [cl-struct-js2-block-node 128 3571 1 nil nil ...] #6] (#5) 121] #4 [cl-struct-js2-keyword-node 43 7 4 nil #5]] "self" nil]]) (context . [cl-struct-js2-symbol 86 "context" [cl-struct-js2-name-node 39 25 7 nil #0 "context" nil]]) (callback . [cl-struct-js2-symbol 86 "callback" [cl-struct-js2-name-node 39 15 8 nil #0 "callback" nil]]) (name . [cl-struct-js2-symbol 86 "name" [cl-struct-js2-name-node 39 9 4 nil #0 "name" nil]])) nil nil nil nil nil 0 nil nil 0 FUNCTION FUNCTION_EXPRESSION nil ([cl-struct-js2-name-node 39 9 4 nil #0 "name" nil] [cl-struct-js2-name-node 39 15 8 nil #0 "callback" nil] [cl-struct-js2-name-node 39 25 7 nil #0 "context" nil]) nil nil 8 32 t nil nil nil])
js2-parse-function(FUNCTION_EXPRESSION 3537 nil nil)
js2-parse-function-expr()
js2-parse-primary-expr()
js2-parse-member-expr(t)
js2-parse-unary-expr()
js2-parse-mul-expr()
js2-parse-add-expr()
js2-parse-shift-expr()
js2-parse-rel-expr()
js2-parse-eq-expr()
js2-parse-bit-and-expr()
......
nxml has both input-pending-p and sit-for, see
rng-validate-while-idle-continue-p in rng-valid.el
> Stefan
Is there something better than let-binding buffer-file-name and
buffer-file-truename?
Leo
next prev parent reply other threads:[~2014-02-20 5:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 0:34 bug#16804: 24.3.50; [PATCH] fix with-silent-modifications Leo Liu
2014-02-19 4:39 ` Stefan Monnier
2014-02-19 6:10 ` Leo Liu
2014-02-19 14:28 ` Stefan Monnier
2014-02-19 15:35 ` Leo Liu
2014-02-19 18:30 ` Stefan Monnier
2014-02-20 0:33 ` Leo Liu
2014-02-20 4:57 ` Stefan Monnier
2014-02-20 5:57 ` Leo Liu [this message]
2014-02-20 14:01 ` Stefan Monnier
2014-02-20 14:38 ` Leo Liu
2014-02-20 17:14 ` Stefan Monnier
2014-02-21 0:29 ` Leo Liu
2016-02-24 3:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1iosae36g.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=16804@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).