From: "Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Eshel Yaron <me@eshelyaron.com>, 65387@debbugs.gnu.org
Subject: bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help'
Date: Sun, 20 Aug 2023 11:59:47 +0200 [thread overview]
Message-ID: <m1il9ajap8.fsf@yahoo.es> (raw)
In-Reply-To: <83fs4exn5e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Aug 2023 09:07:09 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Eshel Yaron <me@eshelyaron.com>
>> Cc: 65387@debbugs.gnu.org
>> Date: Sat, 19 Aug 2023 22:56:18 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> This patch adds a user option for disabling the *Patch Help* buffer that
>> >> `submit-emacs-patch` displays.
>> >
>> > Thanks, but why is it important to be able to disable the
>> > instructions, enough to justify this new option? I expect experienced
>> > people not to use this command at all, so its main purpose is for the
>> > newbies.
>>
>> Ah I actually find this command quite convenient, except for that
>> instructions buffer that tends to get in my way. So I guess this option
>> is useful for us semi-newbies :)
>>
>> I don't know if it justifies a new option, as you say, and I don't mind
>> keeping a modified `submit-emacs-patch` in my config.
>>
>> I do wonder, since `(info "(emacs)Sending Patches")` recommends using
>> `submit-emacs-patch` and that always seemed easier than doing `C-x m`
>> and adding the destination address and the attachment patch afterwards,
>> what alternative you'd expect experienced users to go with?
>
> Let's see what others think about this new command.
>
> Would people please voice their opinions about adding it?
Instead of just a toggle, we could make the new option a tristate:
- `nil`: Only displays the buffer to compose the email (what is proposed in
this bug report).
- `help`: Displays instructions on how to send the patch (current
behavior).
- `patch`: Displays the patch that you want to submit in the split
window.
Perhaps this adds useful enough functionality that adding a new
configuration option feels more justified.
next prev parent reply other threads:[~2023-08-20 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 19:33 bug#65387: [PATCH] New user option 'submit-emacs-patch-display-help' Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-19 19:58 ` Eli Zaretskii
2023-08-19 20:56 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-20 6:07 ` Eli Zaretskii
2023-08-20 7:56 ` Visuwesh
2023-08-20 9:59 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-20 11:35 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-20 16:37 ` Juri Linkov
2023-11-16 7:25 ` Juri Linkov
2023-12-15 1:12 ` Stefan Kangas
2023-09-06 17:47 ` Stefan Kangas
2023-09-06 18:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1il9ajap8.fsf@yahoo.es \
--to=bug-gnu-emacs@gnu.org \
--cc=65387@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mardani29@yahoo.es \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).