From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode Date: Sat, 16 Dec 2023 09:37:03 +0100 Message-ID: References: <83fs0o7l6a.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5211"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Daniel Mendler , Eli Zaretskii , 67527@debbugs.gnu.org, Dmitry Gutov To: Eason Huang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 16 09:38:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEQBr-0001AR-3m for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Dec 2023 09:38:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEQBP-0004Uy-Kf; Sat, 16 Dec 2023 03:38:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEQBO-0004U8-5o for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 03:38:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEQBN-0005D4-TM for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 03:38:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEQBO-0006Kf-2Y for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 03:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2023 08:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67527 X-GNU-PR-Package: emacs Original-Received: via spool by 67527-submit@debbugs.gnu.org id=B67527.170271583024279 (code B ref 67527); Sat, 16 Dec 2023 08:38:02 +0000 Original-Received: (at 67527) by debbugs.gnu.org; 16 Dec 2023 08:37:10 +0000 Original-Received: from localhost ([127.0.0.1]:53929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEQAY-0006JW-4x for submit@debbugs.gnu.org; Sat, 16 Dec 2023 03:37:10 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:50742 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEQAV-0006JO-Aj for 67527@debbugs.gnu.org; Sat, 16 Dec 2023 03:37:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1702715826; bh=kZC2TZKHsa64ClvIhDEsuXzzA6qPrSsFvxZ7hlNh+Vs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=n9CUJzGU3fcS5uGl+vNrpC3dJxdzjDVJhqU3HsHrjaHBYpiKBpJq7zGs87nKUQsvf BqxPq2mxkJ0W99nWdisKpEYDU2/+R33yFVEqrufwE2P16SKlhjJloS9jMOTxPNCwux Mf2lDli9Wn/c7fCYLwejqiMR1e9dlMI5nO+8G8CoLufdrU/kQLyyHErY0G7wM86qFf g0/IdKIFIRs8hMdBsej4AoN1lSQYPGRAq9UU63Wdy+HcoWIUVI904Owz6SdRR7VGxJ cOCxzP6DUUXPpweDCqFRCUW5s4tbyNp9dtlb0KXLvrdxLbJQ3VgwJAHiW8agxQG+r7 S2J4VMmEmRfcQ== In-Reply-To: (Eshel Yaron's message of "Thu, 30 Nov 2023 10:01:06 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276301 Archived-At: Eshel Yaron writes: > Eason Huang writes: > >> It's not a good idear to add `ispell-completion-at-point` to >> `completion-at-point-functions` by default. >> ... >> Anyway, I can use the below code to rollback to the behavior before >> the commit. >> >> ``` >> (add-hook 'text-mode-hook >> (lambda () >> (remove-hook 'completion-at-point-functions >> 'ispell-completion-at-point t))) >> ``` > > Indeed, it's easy enough to adapt if you happen not to like this capf. > Which is why I don't think a dedicated user option is in order. > ... > I wonder how others feel about this, though. I surveyed a bunch of user configurations online, and saw that it is not that uncommon for people to globally enable automatic completion pop ups with company and corfu. As Eason Huang reports, the new `ispell-completion-at-point` probably makes such pop ups rather noisy. I see that Dmitry (CC'd) already addressed this in company (by skipping this capf). I suppose corfu could do something along the same lines (CC'ing Daniel as well)... Do you guys think that's a reasonable remedy? Eshel