unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eason Huang <aqua0210@foxmail.com>
Cc: Daniel Mendler <mail@daniel-mendler.de>,
	Eli Zaretskii <eliz@gnu.org>,
	67527@debbugs.gnu.org, Dmitry Gutov <dmitry@gutov.dev>
Subject: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode
Date: Sat, 16 Dec 2023 09:37:03 +0100	[thread overview]
Message-ID: <m1il4ysfv4.fsf@dazzs-mbp.home> (raw)
In-Reply-To: <m1h6l3r4x9.fsf@dazzs-mbp.home> (Eshel Yaron's message of "Thu, 30 Nov 2023 10:01:06 +0100")

Eshel Yaron <me@eshelyaron.com> writes:

> Eason Huang <aqua0210@foxmail.com> writes:
>
>> It's not a good idear to add `ispell-completion-at-point` to
>> `completion-at-point-functions` by default.
>> ...
>> Anyway, I can use the below code to rollback to the behavior before
>> the commit.
>>
>> ```
>> (add-hook 'text-mode-hook
>>           (lambda ()
>>             (remove-hook 'completion-at-point-functions
>>             'ispell-completion-at-point t)))
>> ```
>
> Indeed, it's easy enough to adapt if you happen not to like this capf.
> Which is why I don't think a dedicated user option is in order.
> ...
> I wonder how others feel about this, though.

I surveyed a bunch of user configurations online, and saw that it is not
that uncommon for people to globally enable automatic completion pop ups
with company and corfu.  As Eason Huang reports, the new
`ispell-completion-at-point` probably makes such pop ups rather noisy.

I see that Dmitry (CC'd) already addressed this in company (by skipping
this capf).  I suppose corfu could do something along the same lines
(CC'ing Daniel as well)...  Do you guys think that's a reasonable remedy?


Eshel





  reply	other threads:[~2023-12-16  8:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 10:31 bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode Eason Huang
2023-11-29 13:18 ` Eli Zaretskii
2023-11-29 13:45   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-29 14:03     ` Eason Huang
2023-11-29 14:32       ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-30  7:46         ` Eason Huang
2023-11-30  9:01           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16  8:37             ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-12-16  9:34               ` Daniel Mendler
2023-12-16 12:23                 ` Dmitry Gutov
     [not found] <m2jzq0j1f4.fsf@foxmail.com>
2024-01-08 17:55 ` Simon Manning
2024-01-09 13:33   ` Eli Zaretskii
2024-01-12 12:46     ` Eason Huang
2024-01-12 14:09       ` Eli Zaretskii
2024-01-13  9:03         ` Eason Huang
2024-01-20  9:19           ` Eli Zaretskii
2024-01-20  9:46             ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-20 10:28               ` Eli Zaretskii
2024-01-20 10:33                 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-20 10:56                   ` Eli Zaretskii
2024-01-20 11:33                     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-27  9:56                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1il4ysfv4.fsf@dazzs-mbp.home \
    --to=bug-gnu-emacs@gnu.org \
    --cc=67527@debbugs.gnu.org \
    --cc=aqua0210@foxmail.com \
    --cc=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    --cc=mail@daniel-mendler.de \
    --cc=me@eshelyaron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).