From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Thu, 05 Dec 2024 07:50:38 +0100 Message-ID: References: <86wmgfzhgc.fsf@gnu.org> <86zflay7hh.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34805"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: trevor.m.murphy@gmail.com, 73862@debbugs.gnu.org, Aaron Jensen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 05 07:51:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJ5hr-0008vC-3F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Dec 2024 07:51:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJ5hZ-0002ll-2o; Thu, 05 Dec 2024 01:51:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJ5hW-0002kc-B9 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 01:51:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJ5hW-0001eO-2a for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 01:51:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=KqwtsHUIBuRBxqYT+02Bn/MWd7p7ovxB7YU9LCUJt5k=; b=KyMVd5li/hffVXaotBRPChTobUbSziZXC3RduK2nB/PF9H1HiJ9jkM7up3AAllXLW28jIJ2QHeCxRy+ouWfmRn7dMOCE4eFiHwg+bOVGoiPYEy8R1GBZdvf0hQQJ0EtzuzXuUvBFb+zinT/OvzLUsE5i1D3yIKTBR+DJVN34/Z9QPQWoIwK8yVwha1PP4HLvaxCckPZMlcJh1nS7/MyiQelHyhOFA4hiHC67Yqlf/pWpH2tSUJXV0XdRUVAqOH6K/q/blkCq5bPhntJLc7O0w7AKD6eFvH6vZspdu2npjsoogdLtKRRZPKOW14h4BGkCgkFYx4YtJXo1LcrXd+ar5g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tJ5hV-00030E-Ng for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2024 01:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2024 06:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173338144511517 (code B ref 73862); Thu, 05 Dec 2024 06:51:01 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 5 Dec 2024 06:50:45 +0000 Original-Received: from localhost ([127.0.0.1]:37887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ5hE-0002zg-TJ for submit@debbugs.gnu.org; Thu, 05 Dec 2024 01:50:45 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:41502 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tJ5hC-0002zV-DP for 73862@debbugs.gnu.org; Thu, 05 Dec 2024 01:50:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1733381441; bh=/67HOAtN/MDMkh7QgYKomRRv7cNieVN8m/HmAmUbu7o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BKfn052mZLLePU0Lyp0dYKQ3mLQaAEp7zmgGVvh60HezSf73Zezi1HbdC3uqcuhQ7 /uc5krz4b/K/1Gs/+uTUinaKRXQf3c5SZR3JBnfJnNwuvzj4fK08onWP90HA6pSDEX fhRkjzaDeGC8iFWO2OeDbO1zAUKz0hdrbwy9Y34RS4kWeYi3fm0GiGL4LQcypcDeag OaBpsyBl6t+oHB+2aYsGdpjsr7oyf6tEmHaxru0qjLMCq775jqtS40ya5y3OEKDzCu susGXUklL/kNhlTWrfOVL6aoMNOTHmxg8y0pmKKkI0nfGqvcJaJALHZO8o9BzVhe6a VF84iOyVGM/TA== In-Reply-To: <86zflay7hh.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Dec 2024 08:22:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296442 Archived-At: Hi Eli, Eli Zaretskii writes: >> From: Aaron Jensen >> Date: Wed, 4 Dec 2024 19:06:26 -0800 >> Cc: Trevor Murphy , Eshel Yaron , 73862@debbugs.gnu.org >>=20 >> You were able to reproduce what? I don't think you posted a recipe to r= eproduce the problem. Please >> do, if at all possible, preferably starting from "emacs -Q". >>=20 >> I didn't =E2=80=94 I thought I mentioned that. I had intended to provide= one as soon as I had a chance to, but it turns >> out that Eshel encountered the same issue and provided a recipe (thank y= ou, Eshel). The only difference in >> my case is that face-remap-set-base is used, rather than face-remap-add-= relative. >>=20 >> As far as I can tell, this same bug occurs in the mode-line as well as t= he header-line. I.e., there was an >> existing bug in the mode-line and it was replicated to the header-line a= fter the two new faces were added. > > If what you see is the same as Eshel, I will ask you the same > question: shouldn't you apply face-remapping to the 2 new faces > instead of the 'header-line' face from which they both inherit? > What happens if you do define remapping for those two new faces? At least to me, it's not clear what you mean by "should". Existing code remaps the header-line face with good results (prior to this change), so if we now "should" remap something else instead to get the same results, that means this is a breaking change. Is that intended? If so, OK, if not, shouldn't it be fixed? :) Thanks, Eshel