From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66948: [PATCH] Add Completion Preview mode Date: Mon, 06 Nov 2023 16:37:52 +0100 Message-ID: References: <87lebcqcof.fsf@posteo.net> <878r7b72qf.fsf@posteo.net> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18749"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 66948@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 06 16:38:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r01gT-0004eL-HL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Nov 2023 16:38:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r01gI-00048V-Eu; Mon, 06 Nov 2023 10:38:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r01gG-00047S-GR for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 10:38:24 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r01gG-0005Hh-7p for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 10:38:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r01gr-0008Mn-JU for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2023 10:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Nov 2023 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66948-submit@debbugs.gnu.org id=B66948.169928511932130 (code B ref 66948); Mon, 06 Nov 2023 15:39:01 +0000 Original-Received: (at 66948) by debbugs.gnu.org; 6 Nov 2023 15:38:39 +0000 Original-Received: from localhost ([127.0.0.1]:40402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r01gV-0008MA-6h for submit@debbugs.gnu.org; Mon, 06 Nov 2023 10:38:39 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:51008 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r01gP-0008Lz-Et for 66948@debbugs.gnu.org; Mon, 06 Nov 2023 10:38:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1699285075; bh=BzxRrDZTNDuGhf4rtVUHWdl5f4EWnvcPfT/hmToWi+g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GxELaEQKTU/t/phk4ME+4++P2sx0lNVcouLv+wveKVSXm6/Yk81O/6jJgJhURanWv in3KfUbyko5NZVa1XV9Mf6Slp/UpJ9XifH+paG2FyiR2P5hizrW/l7LkB/2yMC+nBU 5lUJNWokrT6FoSIBkba2a5jfl6v/GDDdTogT+GsUsi1IUH79AyGgFMd7uoGcRzQje2 uQs2OxO6wiV6cpP7n2ZC7CL79njRJFBpYKuc9aEg0vZxcswID4lOp5JZKxej9MOQUq wdUpL3avw9Vgfp4V1gYn0Hj/icST/LWzhasz1AupZ/2pQVdVWbpk/Y31q9ivKsuioI Jwaaug/i7q7DA== In-Reply-To: <878r7b72qf.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 06 Nov 2023 07:36:08 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273877 Archived-At: Hi Philip, Philip Kaludercic writes: >> Thanks for testing. To have DEL not dismiss the completion preview, add >> `delete-backward-char` to `completion-preview-commands`. Actually, >> would it make sense to have that behavior by default? > > I think it would. Done, in the updated patch I've sent in my other message (patch v2). >>> and that there is no option to cycle between inexact completions. >> >> That's interesting, can you elaborate about the use case that you have >> in mind? I thought about adding a command to do that, but I wasn't sure >> there'd be a good use case for it since you can always dismiss the >> preview (e.g. with `C-g`) and say `C-M-i` to pick another candidate. > > Just to use M-n/M-p to cycle through what the different completion > options are, without having to request a window that might mess up my > frame layout. That makes sense, thanks. Done in the updated patch, expect I didn't provide these bindings by default, in benefit for use `M-n`/`M-p` for other stuff that may conflict.