From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#8329: 23.3.50; [PATCH] Get rid of one ido ugliness Date: Thu, 24 Mar 2011 22:34:26 +0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1300977462 4148 80.91.229.12 (24 Mar 2011 14:37:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 24 Mar 2011 14:37:42 +0000 (UTC) Cc: 8329@debbugs.gnu.org, storm@cua.dk To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 24 15:37:33 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2lfI-0007P7-M1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2011 15:37:32 +0100 Original-Received: from localhost ([127.0.0.1]:35833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2lfI-0006OW-2c for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2011 10:37:32 -0400 Original-Received: from [140.186.70.92] (port=40277 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2lex-0006H6-32 for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2011 10:37:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2lev-0005d3-SV for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2011 10:37:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2lev-0005cz-Qx for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2011 10:37:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q2lcs-0000Fg-Au; Thu, 24 Mar 2011 10:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Mar 2011 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 8329-submit@debbugs.gnu.org id=B8329.1300977286947 (code B ref 8329); Thu, 24 Mar 2011 14:35:02 +0000 Original-Received: (at 8329) by debbugs.gnu.org; 24 Mar 2011 14:34:46 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2lcc-0000FD-6k for submit@debbugs.gnu.org; Thu, 24 Mar 2011 10:34:46 -0400 Original-Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2lcb-0000Ez-10 for 8329@debbugs.gnu.org; Thu, 24 Mar 2011 10:34:45 -0400 Original-Received: by iwl42 with SMTP id 42so4505iwl.3 for <8329@debbugs.gnu.org>; Thu, 24 Mar 2011 07:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=92rm8kp2lr/Ehuf/hFAyVJtieGRNtcdO/CeRTU5WLz0=; b=SPfVOfscRbICVWI14e+3uqDiIDCZGgdJrmfCrpkvLQbvg6AnIs7KClcTbGTSRF+KkN 69XviALSFDg8bpCFUs8UyNAfBP/vtJt7Sqt8w+Hdmsejy7+hA6XDQSoSPlcEOyqf/RZ9 ICHrDCavAN91kI41piQb/4NGD126fuHmoaNNk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=Mg/arf0EQGJjliCFBWkVpNEDrS+zVmMXMf655OFSmCV60K2eunx9uQQps3PfjO9X5e 4d4jqgXQSRwtbD6uiRUgw8hp+DBDJREBg1gZOx48vYBjFEARtlAVkY4xtHT33U+gnqbr hyF2nbyJ0t+oygv86Ebgb7r1p5u7W5IkZptMM= Original-Received: by 10.42.159.6 with SMTP id j6mr13152399icx.260.1300977279325; Thu, 24 Mar 2011 07:34:39 -0700 (PDT) Original-Received: from Victoria.local (th041164.ip.tsinghua.edu.cn [59.66.41.164]) by mx.google.com with ESMTPS id g17sm3585656ibb.57.2011.03.24.07.34.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Mar 2011 07:34:37 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 23 Mar 2011 16:27:59 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 24 Mar 2011 10:35:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45317 Archived-At: On 2011-03-24 04:27 +0800, Stefan Monnier wrote: >> The following patch replaces ugly completing-read form with a simpler >> and cleaner read-from-minibuffer. > > Kim, any opinion? Please also review the diff hunk: @@ -4590,17 +4581,13 @@ (defun ido-exhibit () ;; Insert the match-status information: (ido-set-common-completion) - (let ((inf (ido-completions - contents - minibuffer-completion-table - minibuffer-completion-predicate - (not minibuffer-completion-confirm)))) + (let ((inf (ido-completions contents))) (setq ido-show-confirm-message nil) (ido-trace "inf" inf) (insert inf)) )))) -(defun ido-completions (name candidates predicate require-match) +(defun ido-completions (name) ;; Return the string that is displayed after the user's text. ;; Modified from `icomplete-completions'.