From: Leo <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 8329@debbugs.gnu.org, storm@cua.dk
Subject: bug#8329: 23.3.50; [PATCH] Get rid of one ido ugliness
Date: Thu, 24 Mar 2011 22:34:26 +0800 [thread overview]
Message-ID: <m1fwqc8u4t.fsf@gmail.com> (raw)
In-Reply-To: <jwv8vw537mv.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 23 Mar 2011 16:27:59 -0400")
On 2011-03-24 04:27 +0800, Stefan Monnier wrote:
>> The following patch replaces ugly completing-read form with a simpler
>> and cleaner read-from-minibuffer.
>
> Kim, any opinion?
Please also review the diff hunk:
@@ -4590,17 +4581,13 @@ (defun ido-exhibit ()
;; Insert the match-status information:
(ido-set-common-completion)
- (let ((inf (ido-completions
- contents
- minibuffer-completion-table
- minibuffer-completion-predicate
- (not minibuffer-completion-confirm))))
+ (let ((inf (ido-completions contents)))
(setq ido-show-confirm-message nil)
(ido-trace "inf" inf)
(insert inf))
))))
-(defun ido-completions (name candidates predicate require-match)
+(defun ido-completions (name)
;; Return the string that is displayed after the user's text.
;; Modified from `icomplete-completions'.
next prev parent reply other threads:[~2011-03-24 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 16:57 bug#8329: 23.3.50; [PATCH] Get rid of one ido ugliness Leo
2011-03-23 20:27 ` Stefan Monnier
2011-03-24 14:34 ` Leo [this message]
2011-03-25 0:48 ` Leo
2011-03-27 1:28 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fwqc8u4t.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=8329@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).