From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57420: 29.0.50; Failure configuring Emacs with animated WebP support Date: Thu, 25 Aug 2022 23:59:40 +0200 Message-ID: References: Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12205"; mail-complaints-to="usenet@ciao.gmane.io" To: 57420@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 26 00:01:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRKuZ-0002wv-4a for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 00:01:15 +0200 Original-Received: from localhost ([::1]:47184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRKuY-0001Ma-7W for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Aug 2022 18:01:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRKuN-0001M0-4e for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 18:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRKuM-0000Ee-F3 for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 18:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRKuM-0005PV-5n for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 18:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57420 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166146480320624 (code B ref -1); Thu, 25 Aug 2022 22:01:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Aug 2022 22:00:03 +0000 Original-Received: from localhost ([127.0.0.1]:51522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRKtO-0005MX-Ve for submit@debbugs.gnu.org; Thu, 25 Aug 2022 18:00:03 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:55056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRKtK-0005LX-3b for submit@debbugs.gnu.org; Thu, 25 Aug 2022 18:00:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRKtJ-0001I9-Uj for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 17:59:57 -0400 Original-Received: from sonic305-21.consmr.mail.ir2.yahoo.com ([77.238.177.83]:41153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRKtE-0008Jc-P2 for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 17:59:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1661464786; bh=V6Jn5ZcGg9z94DFRdvA7dFtT85W1axp27j1s6YR4CcM=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=UdicAav39ZjXBr62Nj9dWVwcwCsYDYqXcQtWpXhitDz+gZUhjB8FRJq/iLoC9KgJaCBirDh0zEU/wGUfb+NBmRbAxdfPNMlgUuRfCaM+4dOBwTZvaRC3tXZ2Xy2EHeDIhnc1kAyqz8leRlEggYZ2WxR8kTD4QXOZS6fOsE/0A/g1eBI+8Ioh1YnVNQPqwRUktyrLjRw3O8C4hJ86m98ERp0Q9/8jB6JHgMvmmpF0o3qZVmyAYW0c8w8Gk3wKGY5SNDkt3+SiZ5a8qTYpwyD29GRJjS2i99Lb34xtaNX9Opc+xL3oSUX6MFw/lX2mvF9GGlA6kLWwz78seh5dui1xWg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1661464786; bh=jmtpGGlfnWRMyEVTbFw0IoA1I8J8ujEjjc3nnB1W3EX=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=A5kyyKnhX+4T/jvLtCtlDDDahtygnUXVpSR5hTdNlVwfSqmJoPhVIe/RcqlPbbWVw9aXluWKGlUvLq2+EsTQsa2IGY9wUoVfZPjrPgQJft2gpLXp4nupZxWmWrJYD5juVY0iA+Hvi2LOELpscp+BivGzWuo3nxMCsQQymzJnXV+mVcTnBKMCRGH6dZRkUn4nIRqkGRojJ+8RpwvbmMBjs7RE1R9ZuZo2ewVGvSEzG9UMVCIsHF+WWlm2KNBpCJRuzK90/uaDKuEzY7e+I49ERTZewHflx26KaeMHjYsiBXtAOhOCpgpIZEAvBJPU5V98bXaxXVUvXlMmOkQRDp3SXg== X-YMail-OSG: rvepZ1kVM1kyOMU8dCouFHjX.jeRoeacxQeuU7MB2DYjdu.ik7ojGKmYvEtkvt1 RBhJ3B2gXxKmduaSv4OceCJi4qNdb2XwaPo1mI6H9PiFEbDPTqoGhmNouVa5NHDqVOzssAaNHz5a J8ZaET6cih8xTKyU5plEM9HwZ_JBu8ibs836N9oG32TLzcn_8I2cVvsvi1_pOGz9VaxcW08CGEZl Tov1b9jWWOtr36GXPypC01y0VfVr8rhx1JBo.vv2fWhUBUngnyAnfwuC8UExpIv6UwMb14xeLYUX 0QFdIBrBsI48zaaWjjULkN3_64DdRfQC0j0lAKuFBgQs1AMuR2iTcxP6olk1ZR6kekELjchxNUk. N_Eiwi72W6hKIM1imtqxu_dbwkFE79gdnHTQwvZYMiDzfoCV8.iEhWghbFO4tWDzDDJ08O7QJ1ZZ U9o4PiU.0mI1xpfchhyr6z6pWySbMhwRbFMxB50NsiSPO4tXRStXe_0Uoz0HA3swrJm_q6d.jtvy Zj6wsaPcUmy6bP63HjWFQV.cB7DUjB5YFhrQ8zeWeG7dfUHGofVmIZPScvBHOf1KH6KewRcsr_rs Gc4DK06..7yi3NJOxwJOZXROLw_CBqoh7LCjlPGUX_86zER6i_a2pPx8WI5rjp1xkDpn583.EQTY PxINKmiYoRGwEsGBhtIcagcozlcc61fY2R8t.rJW_Mzgqr34XeyAm2.ahrhJEgJsoeBpcX.hW08k ifHDsGxtdB4fgjocBc.yDH384TkJseb6cwyyhsp7zmA3wUpSUpOCIquA6_WPK0XCIUXJ4WV9pZqC fxz8EaG_ue3Scz0Tws89IVFdZZJS0FKxgAnpUvfJ1q X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Thu, 25 Aug 2022 21:59:46 +0000 Original-Received: by hermes--canary-production-ir2-f74ffc99c-pzqbs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a508de23d36acea141dbd9151699a569; Thu, 25 Aug 2022 21:59:41 +0000 (UTC) X-Mailer: WebService/1.1.20560 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=77.238.177.83; envelope-from=mardani29@yahoo.es; helo=sonic305-21.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240752 Archived-At: I have a computer that cannot build Emacs since the animated WebP support was added. Details of the system: aarch64-apple-darwin21.1.0, NS appkit-2113.00 Version 12.0.1 (Build 21A559) Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.4 Library WebP is installed via the Homebrew package manager. $ pkg-config --libs libwebp -L/opt/homebrew/Cellar/webp/1.2.2/lib -lwebp Steps to reproduce the problem: make -j [...] checking for libwebp >= 0.6.0... yes [...] ld: library not found for -lwebp clang: error: linker command failed with exit code 1 (use -v to see invocation) One workaround I've been using to build Emacs is to configure it --with-webp=no I think this is a bug that was introduced when animated WebP support was added. From commit d82e1a873df381b2c35bc9036da5665468bdfd31: diff --git a/configure.ac b/configure.ac index 6b834a2f65..185e4d0862 100644 --- a/configure.ac +++ b/configure.ac @@ -2695,6 +2695,9 @@ AC_DEFUN WEBP_MODULE="libwebp >= $WEBP_REQUIRED" EMACS_CHECK_MODULES([WEBP], [$WEBP_MODULE]) + if test "$HAVE_WEBP" = "yes"; then + WEBP_LIBS="-lwebp -lwebpdemux" + fi AC_SUBST(WEBP_CFLAGS) AC_SUBST(WEBP_LIBS) fi The problem I see with this part of the patch is that, after you call EMACS_CHECK_MODULES, the variable WEBP_LIBS is correctly set to "-L/opt/homebrew/Cellar/webp/1.2.2/lib -lwebp" via pkg-config. However, it is overriden to contain "-lwebp -lwebpdemux", so the library path got removed. If WebP animated support requires -lwebpdemux, I think we could require the libwebpdemux module instead (part of the libwebp package), whose linker flags include "-lwebp -lwebpdemux". The following patch fixes the compilation for me: diff --git a/configure.ac b/configure.ac index 6ca3052ea3..4590ed3506 100644 --- a/configure.ac +++ b/configure.ac @@ -2773,12 +2773,9 @@ AC_DEFUN || test "${HAVE_W32}" = "yes" || test "${HAVE_NS}" = "yes" \ || test "${HAVE_BE_APP}" = "yes" || test "${HAVE_PGTK}" = "yes"; then WEBP_REQUIRED=0.6.0 - WEBP_MODULE="libwebp >= $WEBP_REQUIRED" + WEBP_MODULE="libwebpdemux >= $WEBP_REQUIRED" EMACS_CHECK_MODULES([WEBP], [$WEBP_MODULE]) - if test "$HAVE_WEBP" = "yes"; then - WEBP_LIBS="-lwebp -lwebpdemux" - fi AC_SUBST([WEBP_CFLAGS]) AC_SUBST([WEBP_LIBS]) fi I checked that the built Emacs has WebP support. What do you think? I'd need an build system expert to verify that this is TRT in GNU/Linux, Windows, or when pkg-config is not available.