From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67180: 30.0.50; 'pp-to-string' emits extra newline Date: Wed, 15 Nov 2023 14:10:39 +0100 Message-ID: References: <83il63rzrt.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22764"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67180@debbugs.gnu.org, Eli Zaretskii To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 16:37:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3HxS-0005hK-GY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 16:37:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3HxC-0000Mz-Ow; Wed, 15 Nov 2023 10:37:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3HxB-0000LW-Es for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:37:21 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3HxB-0008G7-7T for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:37:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3Hx8-0000U1-Aa for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 10:37:18 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 15:37:18 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67180 X-GNU-PR-Package: emacs Original-Received: via spool by 67180-submit@debbugs.gnu.org id=B67180.17000626331841 (code B ref 67180); Wed, 15 Nov 2023 15:37:18 +0000 Original-Received: (at 67180) by debbugs.gnu.org; 15 Nov 2023 15:37:13 +0000 Original-Received: from localhost ([127.0.0.1]:52897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Hx0-0000TO-1U for submit@debbugs.gnu.org; Wed, 15 Nov 2023 10:37:11 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:41350 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Hwq-0000Sm-5x for 67180@debbugs.gnu.org; Wed, 15 Nov 2023 10:37:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1700053841; bh=IIfZLLYCcymAO/Ff+LWP1KKCdSWTKczFeRXrNVB31ZI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oG1QUWuV1ohPOaddnKYVyVHrLGNhK/p7BQycMQZvt3cu8uWa/DY4yjgjBuulVDfXX mHBETIhhm4YQhJeZBP8lF9z1Vdd1CQ6Gu6S2ZoC7GhzV8kbwYoYe2N2XRS+Y9+/yiv bGBhMN2IZhNfhQuO4S7X6WKY2Zxvp3RIKaYDIQR5OdPWof852DJP9qVyGFJ9Yi2DNb d3Tt2rnPfqDErIjMOHmADPvwcxNQ2b5fwBdEQAkA9ND7813HjVVyv0xi5nd7BWz8V6 RC3b/0TanRwJw57GjV1r2VZ9c5YrKEFOxlkIZxjhtrgLkQLdAqwICaCYz4Hki+BtQY CdUP4nMdsj2TQ== In-Reply-To: (Stefan Monnier's message of "Wed, 15 Nov 2023 07:52:50 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274344 Archived-At: Stefan Monnier writes: >>> On Emacs 29 and earlier, with `-Q`, we have: >>> >>> (pp-to-string "foo") >>> => "\"foo\"" >>> >>> On master with `-Q`, we get an extra newline at the end of the string: >>> >>> (pp-to-string "foo") >>> => "\"foo\" >>> " > > Is that a problem? FWIW, I think that this change is for the better, but it is incompatible, and sadly it broke `agda2-mode`. (In some sense this probably Agda's "fault", because I don't really understand why they're using `pp-to-string` the way they do.) My suggestion was simply to explicitly mention this new behavior in NEWS or some such. > I also see that the old `pp-to-string` added that same extra newline for > slightly more complex input: > > ELISP> (pp-to-string '("foo")) > "(\"foo\") > " > ELISP> > >> Stefan, is this due to your changes in pp? > > Yes. > > > Stefan