From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69056: 30.0.50; history-add-new-input and recursive minibuffers Date: Sun, 11 Feb 2024 18:42:49 +0100 Message-ID: References: <86il2vrlri.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2734"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69056@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 11 19:03:03 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZEAR-0000VK-33 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Feb 2024 19:03:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZEAC-0001a9-8B; Sun, 11 Feb 2024 13:02:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZEAA-0001Zw-3N for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 13:02:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZEA9-0003Yi-QL for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 13:02:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZEAQ-0002HC-2e for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2024 13:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Feb 2024 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69056 X-GNU-PR-Package: emacs Original-Received: via spool by 69056-submit@debbugs.gnu.org id=B69056.17076745648705 (code B ref 69056); Sun, 11 Feb 2024 18:03:02 +0000 Original-Received: (at 69056) by debbugs.gnu.org; 11 Feb 2024 18:02:44 +0000 Original-Received: from localhost ([127.0.0.1]:36066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZEA7-0002GL-Gt for submit@debbugs.gnu.org; Sun, 11 Feb 2024 13:02:43 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:59668 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZEA5-0002GD-2V for 69056@debbugs.gnu.org; Sun, 11 Feb 2024 13:02:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1707673371; bh=p3Rn0+Xu9RH1of2fAEMWHaPTNyWOhVU6XlX6+jVkGTA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=vhzhEOZAgHp1ceYAAXzMR0dpbpdGY8pzQXXR79K+3LGJ3cVhaA9dLfpqGkQvKopZp BzDhR9WxcyCPqCXR29GlcN9QMfjSPaV4h2HiDZEAKKpwHKcwDHzWi/w30zbxaRFkyw R+OJumii1hbqueq5RU7VdIbNlAq8cXHcYAfjoZSBJiljX20j45e78DdnBFtx2iK263 DHD3y+bMB1n/YCWuOZxpy4iuExmV1A9l0lNPuGfSP+L2uq6mE5T76/BayPOsQRsY6U 4NdRv473LparQfRN6tdxQvPpHH5ZfXsdGYetnjgn/kdurukFVBNAYYq1IQjHNoCwYh dHqFSoY+3ouAA== In-Reply-To: <86il2vrlri.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Feb 2024 18:47:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279864 Archived-At: Eli Zaretskii writes: >> Date: Sun, 11 Feb 2024 16:54:43 +0100 >> From: Eshel Yaron via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> >> 1. emacs -Q >> 2. (setq enable-recursive-minibuffers t) >> 3. M-y >> 4. In the minibuffer (with the prompt "Yank from kill-ring: "), >> type M-x calendar RET (or any other command). >> 5. M-x M-p >> Expected: "calendar" is inserted in the minibuffer. >> Observed: error saying "Beginning of history; no preceding item". >> >> The problem is that the minibuffer history of M-x isn't recorded when >> you invoke M-x from within the minibuffer of read-from-kill-ring (M-y). >> The reason is that read-from-kill-ring let binds history-add-new-input, >> and that affects all recursive minibuffers as well, so no minibuffer >> history is recorded until you exit the first (non-recursive) minibuffer. >> >> AFAICT This issue affects all uses history-add-new-input, unfortunately, >> not only read-from-kill-ring, since it's always used via let-bindings. > > I'm not sure we should be interested in fixing this. Recursive > minibuffers are not supposed to start a completely new command loop > unaffected by whatever was before it, so we shouldn't try. I see that, but the problem, IMO, is that there's nothing telling you that you're in this state of not recording minibuffer history. You likely won't know that you're using a command that let-binds history-add-new-input when you enter a recursive minibuffer, and losing all minibuffer history from commands you invoked in the recursive edit may come as an unpleasant surprise. > Even if this particular case is solved (which I'm not sure we can), > there are a legion of other similar situations, where something > let-bound by a command entering the minibuffer affects all the > recursive minibuffers. Let-binding in commands that prompt users is > ubiquitous in Emacs. Indeed, this issue is possibly broader. Often the solution is to use minibuffer-setup-hook to bind a variable buffer-locally in a minibuffer, rather than let-binding it (affecting all recursive minibuffers). For history-add-new-input this is slightly trickier since read_minibuf checks the value of this variable only after the minibuffer is exited. I'm experimenting with a possible solution where we change read_minibuf to grab the buffer-local value of this variable from the minibuffer, and change all users of history-add-new-input to set it buffer-locally instead of let-binding it. Works pretty well, but it doesn't cover third party code that uses this variable, naturally. > It's easy enough to work around the problem: C-g (perhaps more than > once), then start afresh. > > So I tend to close this as wontfix. All right, fair enough.