From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#3230: 23.0.93; Make dired-actual-switches safe local variable? Date: Thu, 24 Feb 2011 12:46:40 +0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1298524015 11978 80.91.229.12 (24 Feb 2011 05:06:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 24 Feb 2011 05:06:55 +0000 (UTC) Cc: 3230@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 24 06:06:51 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PsTPe-0005n9-PC for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Feb 2011 06:06:50 +0100 Original-Received: from localhost ([127.0.0.1]:47613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsTPd-0005Qc-Sc for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Feb 2011 00:06:49 -0500 Original-Received: from [140.186.70.92] (port=46217 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsTPY-0005QI-W9 for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2011 00:06:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsTPX-00023G-RV for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2011 00:06:44 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsTPX-000234-MA for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2011 00:06:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PsT7S-0000rA-AU; Wed, 23 Feb 2011 23:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Feb 2011 04:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3230-submit@debbugs.gnu.org id=B3230.12985228303234 (code B ref 3230); Thu, 24 Feb 2011 04:48:02 +0000 Original-Received: (at 3230) by debbugs.gnu.org; 24 Feb 2011 04:47:10 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsT6b-0000q6-GH for submit@debbugs.gnu.org; Wed, 23 Feb 2011 23:47:10 -0500 Original-Received: from mail-yi0-f44.google.com ([209.85.218.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsT6Z-0000pl-Jt for 3230@debbugs.gnu.org; Wed, 23 Feb 2011 23:47:08 -0500 Original-Received: by yic13 with SMTP id 13so101009yic.3 for <3230@debbugs.gnu.org>; Wed, 23 Feb 2011 20:47:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=ayaLZUJeiW3VuSgFKuTXx0q0QjcJhwzvvGWXa2et/ZY=; b=FR5e+xp50fX2hJ+A3jsrv0NVGW4j8Od17bAliZbmE8xYm3ZPjMeCwRqYfy/Qu2OdC6 hFEBQIecOZu6xeBDjCrNNdb+M+ziTlKnBAswWnxdopeRjAblnGQyfn7657funYH3Czm9 8X8ia0PMPyjy03TT5E0Nhqzt7g7wF4lUSQrlk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=cZZR9EZa7teGtCFRQFybZGXc3p/lUXpw6K5MJU3Nc4Ra1YBr7c8masWnkTYaHD7axW r/gQ4zQhPCBTz6K3nXfYg9nFQ2hMXx5vfVPdkdj55vd4donTnWNuFN9JCIlFZcTIU+xS g7tKcWMjQyjyMTLmbYXkOVlnJI0cPbu5TqUh4= Original-Received: by 10.101.139.15 with SMTP id r15mr211708ann.63.1298522822175; Wed, 23 Feb 2011 20:47:02 -0800 (PST) Original-Received: from Victoria.local ([59.57.99.84]) by mx.google.com with ESMTPS id b27sm4646617ana.8.2011.02.23.20.46.57 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Feb 2011 20:47:01 -0800 (PST) In-Reply-To: (Glenn Morris's message of "Wed, 23 Feb 2011 21:08:26 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.94 (Mac OS X 10.6.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 23 Feb 2011 23:48:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:44331 Archived-At: On 2011-02-24 10:08 +0800, Glenn Morris wrote: > As it stands, it emphatically should NOT be marked safe. Example: [...] > > Oh dear, arbitrary shell command executed with permissions of the user > running Emacs. Looks like a bug in the way dired-actual-switches is used. Should we devise a function to check every switch in dired-actual-switches is actual a switch? (defun dired-actual-switches-p (switches) (assert (stringp switches)) (mapc (lambda (switch) (assert (eq (aref switch 0) ?-))) (split-string switches nil t))) (put 'dired-actual-switches 'safe-local-variable 'dired-actual-switches-p) Leo