From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58103: [PATCH] docview: imenu access to table of contents Date: Thu, 29 Sep 2022 00:00:54 +0200 Message-ID: References: <87r0zxz85h.fsf@mail.jao.io> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5702"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (darwin) Cc: 58103@debbugs.gnu.org To: Jose A Ortega Ruiz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 29 00:02:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odf8C-0001MM-2R for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Sep 2022 00:02:16 +0200 Original-Received: from localhost ([::1]:50446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odf8B-00088S-1w for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Sep 2022 18:02:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odf7y-00087s-Sx for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2022 18:02:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odf7y-0005Ug-FS for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2022 18:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odf7x-00087A-VM for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2022 18:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Sep 2022 22:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58103 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58103-submit@debbugs.gnu.org id=B58103.166440246931132 (code B ref 58103); Wed, 28 Sep 2022 22:02:01 +0000 Original-Received: (at 58103) by debbugs.gnu.org; 28 Sep 2022 22:01:09 +0000 Original-Received: from localhost ([127.0.0.1]:35085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odf76-000864-Qz for submit@debbugs.gnu.org; Wed, 28 Sep 2022 18:01:09 -0400 Original-Received: from sonic313-21.consmr.mail.ir2.yahoo.com ([77.238.179.188]:46441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odf72-00085Q-1X for 58103@debbugs.gnu.org; Wed, 28 Sep 2022 18:01:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1664402458; bh=DpDf9+z9veX+NxdpaOON37q1sM4trsnxIsuaLdiEdw8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=sjsrxtDjixIc9pYWkVUL/16Zv1JZ5N+MhVZem5vDt8f1eM7ScsnfjY5pFv6mL9MRohfNA1QgGj+ZhbxVcgLdq/p7DZvYEKZBjfXpX3OnyYVKzgh561sLqA+FsgvJwT8g0AcVc8ikzMGvsl1KKdcQ+ia2FHspNtaqm+C5MPu1u7wuhlDlAXHuFnjt35QmYGVQ6ZOlPqGXRdTc0a24LtnNpa8g15zNGkwrpyjFwNKwdhvXCztG6M6eDe8JZqtntsNSK9vNn88QQoqKp1nTKw+N7j7fhE8haNXab2w2HtHAv5gYp7O6HGyqleVmGtFFTAbNmPcxUARzKclI3txehwfJBg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664402458; bh=ATmAzYDdql30wDcSUB8HqYtoi3hFqL36BcV0GlFwNQ7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jH42MkuhVQ+vm3auvHuy2RfViUDoScvaPGqnTaek1G1KSgQ3eGbr6YDcIBjzWl8NKtyhaw3qGaY/L8+EAn0HxbMPbN9bApCCA6stn95Ca0MmvjmDnWoQBzBn8h9dgKhFL6J8guK0GWnItmwq7yMq6w5p7HiqIry0fc5E8eL2DEOqE5/4wS3yFwmHgH36+LGKJcn8TxfmUOWGd1DnhDzLQIqHVhPaEMf8tJ0jsRh4UNJ+CEXAAduweHe9NtIlGf1XU91e3HNULDIMpSz69Nz5+OlRS8h5rNXcXubo4H5AiT/iqwb4fSadeccmglnBw24sNxyQS5RJGMTYzaXVaSOJQA== X-YMail-OSG: wxrZiDwVM1nTENBqjBEXu7yaBu.zFTyK9qDQMRUrHUFOsqOli1ki62gXNE2CJIC oN_8SYCI3V8TKodCgI8ktU8Wkc709hIl_kpi6IYGnVfdvyQrYADT.xj_DxF_BOx1zCts1bkEz7Oe rcwR.xXvkk1lXtxhCLl5ebXO3AR_9x84MOy8jupWX_N6xU0DSeaiR1Ijyrar093lBStwpStRoI2m ZVPujAFrcohJQ12O.vZlVXx1Lo3RIYs7l5OtXTwxrRcRhvBBPmz1Csg0_C_CU__cogxLGhWMirLg CFgMGUdcDSLzcsETdyildSR1jCa9FmnzaiNbL8bs2LfvzvBItBI1XHAv9k63_UPIMi4PPXuUpGis _RfKlGSMQrORQUaRyOdazqNOI1r6jCVneZ5CWI4hzIakvi1baGIePBZ_wl.UARAsMOpR.wfZss3D R._zuCv3YjVbGsGRGrFPM.tX80zceSkUqKDlH4i02Fr71Z53Is5eEKhyurhOkJDAhK1JKvDLAJHu fWT2TRDVUA5d4.GgLwZaYbS6QABQqu3eC0XBo_g8uMFrLo51qL5tAPNAwhCUnhCHJlC4u1_LZoIT hxW.0e1V9D.ICDqRnfBKcIUYHj82D7JJzcBA4n3Gd6a0M54EuCORjsr6G7dt48JuDWDEVXJe1ymm W2zrLJ6uPB_y9SHLTheewz1OKW.1WzEmC1.07c1AOoQivWX14VZy379CmOq5CFlF2Wtas.jlX2MN XRv2YXe4mVq3W237tqdcicddGXZSPk9tTRrbU7GJKn0FsFtskqLx9k.D7qV8J8eadcen5L1Lov6X 1zzM1H0Ox_BGl23yHcs_w9KANadJ3apgkbUO2TAj8S X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Wed, 28 Sep 2022 22:00:58 +0000 Original-Received: by hermes--production-ir2-79cb546688-cg8ng (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e7e13d73abaabc48d56f0e52a967e63e; Wed, 28 Sep 2022 22:00:55 +0000 (UTC) In-Reply-To: <87r0zxz85h.fsf@mail.jao.io> (Jose A. Ortega Ruiz's message of "Tue, 27 Sep 2022 06:41:14 +0100") X-Mailer: WebService/1.1.20715 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243857 Archived-At: Jose A Ortega Ruiz writes: > Tags: patch > > > Hi, > > The patch below provides a quite simple implemetation of an imenu for > doc-view, using mutool. That means of course that is limited to systems > where it's installed, and doesn't try to be too smart, but it's been > working quite well for me. It needs a slight tweak to imenu.el to add a > knob inhibiting it to push all entries with submenus to the top, which > doesn't make sense when those entries represent sections of a TOC. > > If this is acceptable (with any needed modification, of course), i guess > we could also add a bit of further customization, like perhaps a "flat > mode", or whether or not the section titles include page numbers, but > i'm not sure if that's desired (in my usage, i never want either). Thanks for working on this! I've given it a try, and I get the following error when the PDF does not have an outline (starting from emacs -Q): Debugger entered--Lisp error: (wrong-type-argument stringp nil) string-match("\\`%PDF-1\\'" nil) imenu-find-default("%PDF-1" (("*Rescan*" . -99) (nil))) imenu--completion-buffer((("*Rescan*" . -99) nil) nil) imenu-choose-buffer-index() byte-code("\300 C\207" [imenu-choose-buffer-index] 1) call-interactively(imenu record nil) command-execute(imenu record) execute-extended-command(nil "imenu" "imenu") funcall-interactively(execute-extended-command nil "imenu" "imenu") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) Can you reproduce the same issue as well? I'm using mutool version 1.19.0. In GNU Emacs 29.0.50 (build 8, aarch64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.6 (Build 21G115)) of 2022-09-28 built on Daniels-MacBook-Pro.local Repository revision: b6a163ba7cdf57eff5542b4cb6956780ebb2880f Repository branch: master Windowing system distributor 'Apple', version 10.3.2113 System Description: macOS 12.6 Configured using: 'configure CPPFLAGS=-I/opt/homebrew/opt/openjdk@11/include' Configured features: ACL DBUS GLIB GNUTLS JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS WEBP XIM ZLIB