* bug#7718: 23.2.91; Info-isearch-search fails isearch
@ 2010-12-23 10:29 Leo
2010-12-23 19:28 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Leo @ 2010-12-23 10:29 UTC (permalink / raw)
To: 7718
Info-isearch-search returns a function that does not implement the
noerror arg(see Info-search), which means it will err even if
deliberately asked not to.
Leo
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#7718: 23.2.91; Info-isearch-search fails isearch
2010-12-23 10:29 bug#7718: 23.2.91; Info-isearch-search fails isearch Leo
@ 2010-12-23 19:28 ` Juri Linkov
2010-12-23 22:22 ` Leo
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2010-12-23 19:28 UTC (permalink / raw)
To: Leo; +Cc: 7718
> Info-isearch-search returns a function that does not implement the
> noerror arg(see Info-search), which means it will err even if
> deliberately asked not to.
Info-isearch-search does not implement the noerror arg because it just passes it
unchanged to Info-search. Do you mean Info-search should implement noerror for
some non-interactive uses? What it should do when noerror is non-nil?
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#7718: 23.2.91; Info-isearch-search fails isearch
2010-12-23 19:28 ` Juri Linkov
@ 2010-12-23 22:22 ` Leo
2010-12-25 2:28 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Leo @ 2010-12-23 22:22 UTC (permalink / raw)
To: Juri Linkov; +Cc: 7718
On 2010-12-23 19:28 +0000, Juri Linkov wrote:
>> Info-isearch-search returns a function that does not implement the
>> noerror arg(see Info-search), which means it will err even if
>> deliberately asked not to.
>
> Info-isearch-search does not implement the noerror arg because it just passes it
> unchanged to Info-search. Do you mean Info-search should implement noerror for
> some non-interactive uses? What it should do when noerror is non-nil?
That's what I meant. Info-search doesn't implement noerror. I think it
should be like the default isearch search functions:
re-/search-forward/backward: Optional argument, if t, means if fail just
return nil (no error).
Thanks.
Leo
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#7718: 23.2.91; Info-isearch-search fails isearch
2010-12-23 22:22 ` Leo
@ 2010-12-25 2:28 ` Juri Linkov
2010-12-25 8:39 ` Leo
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2010-12-25 2:28 UTC (permalink / raw)
To: Leo; +Cc: 7718
>> Info-isearch-search does not implement the noerror arg because it just passes it
>> unchanged to Info-search. Do you mean Info-search should implement noerror for
>> some non-interactive uses? What it should do when noerror is non-nil?
>
> That's what I meant. Info-search doesn't implement noerror. I think it
> should be like the default isearch search functions:
> re-/search-forward/backward: Optional argument, if t, means if fail just
> return nil (no error).
But the whole logic of Isearch using Info-search is built on the
assumption that Info-search ignores the noerror arg (that is usually t).
This allow Isearch to fail in the initial Info node
and to continue searching through other nodes without failing.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#7718: 23.2.91; Info-isearch-search fails isearch
2010-12-25 2:28 ` Juri Linkov
@ 2010-12-25 8:39 ` Leo
0 siblings, 0 replies; 5+ messages in thread
From: Leo @ 2010-12-25 8:39 UTC (permalink / raw)
To: Juri Linkov; +Cc: 7718
On 2010-12-25 02:28 +0000, Juri Linkov wrote:
>>> Info-isearch-search does not implement the noerror arg because it just passes it
>>> unchanged to Info-search. Do you mean Info-search should implement noerror for
>>> some non-interactive uses? What it should do when noerror is non-nil?
>>
>> That's what I meant. Info-search doesn't implement noerror. I think it
>> should be like the default isearch search functions:
>> re-/search-forward/backward: Optional argument, if t, means if fail just
>> return nil (no error).
>
> But the whole logic of Isearch using Info-search is built on the
> assumption that Info-search ignores the noerror arg (that is usually t).
> This allow Isearch to fail in the initial Info node
> and to continue searching through other nodes without failing.
For users of isearch-search-string with non-nil noerror it will be a
surprise. For example, I use it before actual isearch to see if the
search is to fail (but don't err) and set things up accordingly. I found
it breaks down in info mode due to its ignoring noerror.
But it is fine if it has to remain that way. I will just wrap
isearch-search-string inside ignore-errors.
Leo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-12-25 8:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-23 10:29 bug#7718: 23.2.91; Info-isearch-search fails isearch Leo
2010-12-23 19:28 ` Juri Linkov
2010-12-23 22:22 ` Leo
2010-12-25 2:28 ` Juri Linkov
2010-12-25 8:39 ` Leo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).