From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudolf Schlatte Newsgroups: gmane.emacs.bugs Subject: bug#55149: bug#55161: 29.0.50; [PATCH] oclosure transcription error redux Date: Thu, 28 Apr 2022 15:50:14 +0200 Message-ID: References: <87mtg5zt3a.fsf@dick> <87a6c5pkvr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13903"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (darwin) To: 55149@debbugs.gnu.org Cancel-Lock: sha1:5n8O7OC8wVQ/H1RjuGzTeXHuQ0g= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 15:51:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk4YV-0003Ql-Nu for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 15:51:39 +0200 Original-Received: from localhost ([::1]:58254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk4YU-0001Ga-HP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 09:51:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4Xx-0001E5-Dg for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:51:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk4Xt-0004xY-LL for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:51:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk4Xt-0007by-Io for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:51:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87wnfa3cop.fsf@fastmail.fm> Resent-From: Rudolf Schlatte Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165115383729226 (code B ref -1); Thu, 28 Apr 2022 13:51:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Apr 2022 13:50:37 +0000 Original-Received: from localhost ([127.0.0.1]:45860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4XV-0007bK-71 for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:50:37 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4XT-0007bD-Cb for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:50:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4XT-0000by-5P for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:50:35 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:56536) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4XR-0004oj-8X for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:50:34 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nk4XK-0001jL-Vd for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 15:50:26 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230882 Archived-At: Lars Ingebrigtsen writes: > dick writes: > >> - (:after (apply cdr r) (apply car r)) >> + (:after (prog1 (apply cdr r) (apply car r))) > > I guess this is the same as bug#55149, so I've merged the reports. > > Apparently, returning the value of the :after function is what's > documented to happen (and is what the trunk does now), but it didn't > use to do that, so it's breaking advice that relies on the old > behaviour, if I understand 55149 correctly. This behavior is a bit surprising, since Common Lisp specifies that the return values of :after methods are ignored (“All the after methods are called in most-specific-last order. Their values are ignored.” http://www.lispworks.com/documentation/HyperSpec/Body/07_ffb.htm). To override the return value of a method, :around methods are used. I don't want to argue that CL method combinations and elisp advice are the same thing, or that Emacs Lisp has to necessarily follow CL semantics, but it would be good to have the possibility of inserting a bit of code that should "just run" after a function, without overriding its return value.