From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72437: Unexpected behavior when inserting with prefix arg in electric-pair-mode Date: Sun, 22 Sep 2024 10:21:13 +0200 Message-ID: References: <87le1edqqm.fsf@breatheoutbreathe.in> <86h6c2ug0p.fsf@gnu.org> <86a5htvclm.fsf@gnu.org> <86zfpttpfl.fsf@gnu.org> <20F64DCD-929F-4B4C-BF85-ABE26FC7C995@breatheoutbreathe.in> <87plp0w7g7.fsf@breatheoutbreathe.in> <87o74gsyvq.fsf@breatheoutbreathe.in> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17671"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72437@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 22 10:21:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssHqq-0004TE-6i for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Sep 2024 10:21:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssHqh-0007xN-Sc; Sun, 22 Sep 2024 04:21:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssHqf-0007wC-Q8 for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2024 04:21:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssHqf-0004Sw-GX for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2024 04:21:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=aSWS9Gi38nmG3uMWrGHHkuhNNwJ8w+fQNtxYA4mbW7Y=; b=gYb0iJ31jBW8b2UKNL5bI4V+rKuwfsgH+RzfGxESLQmg/c4feud9sJCDmOWOS1AVJbbRhvrOFeoLcALqI4P0Qyvw12Hp3rPUu/vfmEriDW4YtkKEDvR68RI/FMWOHSf92wmwTTj0vsZMyHYnXP5OCT4Y1nK0vTgZw7qwFHnuitx3cifint9Keq0vNJdvVMzo+Nub6/TJYZSxAd5w2Qr6EfjGsczT3irKhZ2GHfuffHRMqRlKG2leIVagwU2y8ygXgJPiUneHBMBc814LJvdE8B5pplaEhKa5aw3gk4hL4f+q37AQ19BF1UYkVzJSvpxA8Q4M5bbRdGUxSj7rpaziJw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ssHr0-0002oZ-GA for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2024 04:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Sep 2024 08:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72437 X-GNU-PR-Package: emacs Original-Received: via spool by 72437-submit@debbugs.gnu.org id=B72437.172699330110784 (code B ref 72437); Sun, 22 Sep 2024 08:22:02 +0000 Original-Received: (at 72437) by debbugs.gnu.org; 22 Sep 2024 08:21:41 +0000 Original-Received: from localhost ([127.0.0.1]:40841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssHqf-0002nq-Ea for submit@debbugs.gnu.org; Sun, 22 Sep 2024 04:21:41 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:39626 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssHqc-0002nb-6b; Sun, 22 Sep 2024 04:21:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1726993276; bh=sKUA7DlbK8u82dIh2M5l8qRX12Z1dZxGfj/PuFH98kQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tRRz4tyrbRZcKuazUcmP678AOwIEfVWvTTXYuzaMwPaaNCbBzThf33TlWS+CK1+lo U3mRZNk0jRqBN1SKk36f6kgJiLWz1/9bdiGmsjcvpoQoMKnWmYWwo+vsngKTxlReob hL7XOsJetigkfG2qqg4/iao1trADjE5QpYisO/xwOq1XddIq/Bi8pYINiw+txU7Ki8 4tqNqH/O7N2LnKxmkLhk/Ew7mZB7Kzeuai7bRXezU8Ae5j6oXK9WiT77lt4kOLFy3o pfv2gme99aAF+JFxDVAN9UXaTaOlVelGZpCwmpx4ILxtqj0Kgc55Ct/WOVDDwFYAum TZh/Z5R/89S+w== In-Reply-To: <87o74gsyvq.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 21 Sep 2024 10:24:57 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292225 Archived-At: close 72437 31.1 quit Joseph Turner writes: > Eshel Yaron writes: > >> Joseph Turner writes: >> >>> Joseph Turner writes: >>> >>>> On August 13, 2024 10:07:23 PM PDT, Eshel Yaron wrote: >>>>>Hi Stefan, >>>>> >>>>>Stefan Monnier writes: >>>>> >>>>>>> Let's hear what Stefan thinks (and anyone else who has an >>>>>>> opinion or some case other than electric-pair-mode). >>>>>> >>>>>> I think the requested behavior makes a lot of sense, but I lost touch >>>>>> with the way elec-pair works and interacts with other electric modes, so >>>>>> I'm not sure how to make it work without breaking other things. >>>>> >>>>>In case you missed it, the patch I shared upthread might give you >>>>>some ideas. It implements the requested behavior, safely, I think. >>>>>So I would just ask Joseph to try it out for a while and see if it >>>>>works as expected and if any other issues crop up :) >>>> >>>> Thanks for this patch! I am testing it in my daily config. So far >>>> so good, and I'll report back after a few weeks of usage. >>> >>> I have been running this patch for over a month with no issue. >> >> That's great, thanks for testing it and for reporting back! >> >>> I vote to merge it! >> >> Agreed. Here's a full patch with tests, doc updates and a NEWS entry: > > Nice! How about also adding a test like the attached patch? Looks good :) I've now pushed my patch to master as a7192fd7b73 followed by your test addition as 0f4c09d2678. And with that, I'm closing this bug. Best, Eshel