Daniel Martín writes: > >>> +void ns_make_frame_key_window (struct frame *f) >>> +{ >>> + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; >>> +} >> >> Is this new call guaranteed to exist and work well on all the >> supported OS versions where we have the NS build? I wouldn't want to >> fix this on some systems and break it on others at the same time. > > makeKeyWindow is a very old API that should be available on every macOS > and GNUstep we support, AFAIK. I see usages of that API in other parts > of the NS build, in things as central as frame creation, and they are > not protected by any version or system check. > Got a report about some problems closing frames when Emacs runs inside a macOS terminal. So here's a new version of the patch that protects the code that makes the other frame the key window, so that it only runs when the frame is a GUI frame. Kai Ma, could you give it a try and see if everything works well now? Thanks.