From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62234: Toolbar does not work properly (with Emacs 29 or 30) Date: Sat, 18 Mar 2023 11:25:51 +0100 Message-ID: References: <83sfe3eqaf.fsf@gnu.org> <83jzzfegy0.fsf@gnu.org> <87a60a3nrj.fsf@yahoo.com> <871qlm3g9t.fsf@yahoo.com> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16299"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) Cc: Eli Zaretskii , 62234@debbugs.gnu.org, Konrad Podczeck To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 18 11:27:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdTmM-00043U-Uq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Mar 2023 11:27:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdTmE-0005Rd-Qo; Sat, 18 Mar 2023 06:27:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdTmB-0005RB-7J for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 06:27:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdTmA-000163-8z for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 06:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdTmA-0002FV-1C for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 06:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2023 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62234 X-GNU-PR-Package: emacs Original-Received: via spool by 62234-submit@debbugs.gnu.org id=B62234.16791351708567 (code B ref 62234); Sat, 18 Mar 2023 10:27:01 +0000 Original-Received: (at 62234) by debbugs.gnu.org; 18 Mar 2023 10:26:10 +0000 Original-Received: from localhost ([127.0.0.1]:46332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdTlK-0002E7-6c for submit@debbugs.gnu.org; Sat, 18 Mar 2023 06:26:10 -0400 Original-Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:46827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdTlE-0002DU-UJ for 62234@debbugs.gnu.org; Sat, 18 Mar 2023 06:26:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1679135159; bh=NGlCFlVQkuidu4epNsK+d35Iax2d839KrJ2hArT617k=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=j7f2IdWZ+CBxjnDtxkliOquB7Mces54HsL6ARoAJ2eG4snRAMWrNsM8wlAIlx/cjg4MRC0iNVZH7uiUl5L5U2uuMBufb30tqpLMoHDnZACbN4TfCteex7FlOMDe2CFWXq+ftfHXsWwCxIJvI9mnpxs0bb+gqM2m0mBA0Z9O7L5x0m55VJAsohpmbfr8hWAjSiJkF2pUGtIFxEt0l2brqmjLwTyRr45aJnIKKqSO/rQebdyLNvEyEEPc4dTQ7cwsSqgjFFKH4CwCmDKjFTS/Pipd00U8KM84qnvtFpSXYzY53dfxufQ52v5a/Dg5mE5rr7b/K7XhS06mjHoBBKW9p3w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1679135159; bh=CadgMO6ibBJkz6jdRMFSikql3yeU9/PGv7NBw6qRWir=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ae5OVLlXijspoBEr9l+VpZ9CLdb80Xg8E3hMRMkHTvcUb8rltELEYM+h7rNcI0AwV92BEmuhr8zq/4NzSWOLcFfm0TKKINTTURjUX3RXvsS4oM65UNyr6DlQmBK7HKNk3jgBDzrxZZDpdlHUMQdhEhNaJftoCnw/sgU1b+b/08Ucs70KwVDpmIKEx6RGwAB/WKcLRgbHLGum9XSzworbttNKg1qXJcyjjaPfGggj1aX1GdhHEAd6PzFDR5HIVGYRaHZ4gw2zFTNOWXT2hO8XDoRc9ecygc6Bd0u/fM5vGC+K/ZTd0MCDNbr+2stSbGqCB2xW+3IXEuoXwIVz+c+MPw== X-YMail-OSG: giazGbEVM1lmQrfDAVrgI4WaHPR4AzrwXnF8g2ipwfOdKDQF1o9wApXsZy7YTMe jWbbd8LsK6TTBgPpVyw2YXI_QTTr1jfT9flNg20HGwICkN4UQZR.NKmDBMLfcbJ5LJozYWK5kHL1 WBZWR132e03F7x5gl_KmWOCaRL1Jc..liT.dhtzQuP.VaewShCmHRKowfeqf6u2Rh9Y1u8tB.OxX 3W4VcYY2h.qj5Jihg1w91i3HqparoSDskb4sXDr4PoHC7ISz7w7HhAH9h.kCCrFiTaCgvXhM77Q0 hE.ahSJQ.8bvFaXlmc0SMC1XXURGaPe65bQr1xmIjn68LYpCl8l2WZ4NSFSEbe.HC2r.s4ICkOA4 4tUT_9SAIeo1YY.wZjeYkgBJXgE3gMkx.ZOzivU3iIr95Xc8oriyHOwjaaZ.y8a0Kd9KXefI5EkE t8pMRSUmO7HVw.tk_6OJZ1hTZRkO5uo3esGpgOzk1BqgUtMpn0DvE8rXpEtDMqU3CsRnOcA3i0dS 6I2pDi2cz79HGsEBIeuPSaNCAoTtMNRafY_hyNTHk5o2rrCDd5bIM0Nf9XSWbpKMtoTdQMDRSlxd hkNbzfbyCFRa52S_5Xe.izujQVf9T7698qRPATFeculqv0SujNHEUWElYWaiwO3guMXGuvvTjP48 AIiGnSHN.FT6xr915TZmYtsgRObULVmiwMqvea6tialEiyTg0JERXHasYQNJkMKaheChVEvGAtE2 AEkIZoNvD7AaPin5pWIOYXArTxlYBBzqDnbL_vmKLCP5RMuNzvTrmL.CkTMmadvJV2yuMUT7kdNv sb.GdBH61tJROqOTJ4FlotNk4umCHAcfyUbkfxWN7w X-Sonic-MF: X-Sonic-ID: 06625a40-b27b-45b3-abc8-6f7040b68c9a Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Sat, 18 Mar 2023 10:25:59 +0000 Original-Received: by hermes--production-ir2-5b7d458747-lqssg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 521cf3a31c5aed5ba573dced04175ea2; Sat, 18 Mar 2023 10:25:52 +0000 (UTC) In-Reply-To: <871qlm3g9t.fsf@yahoo.com> (Po Lu's message of "Sat, 18 Mar 2023 11:11:26 +0800") X-Mailer: WebService/1.1.21311 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258153 Archived-At: --=-=-= Content-Type: text/plain Po Lu writes: >> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem >> +{ >> + return [toolbarItem isEnabled]; >> +} >> + > > This does no harm on GNUstep. However, please indent with two spaces, > and place spaces after -, :, and ): > > - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem > { > return [toolbarItem isEnabled]; > } > > Otherwise, LGTM. Thanks. OK, I've attached a new version of the patch. Konrad, could you check if with this patch the Emacs toolbar works as you expect? Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-toolbar-item-validation-in-the-NS-port.patch >From b994036d9475e2ae4f4adea8b3a29eff054e354a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Sat, 18 Mar 2023 01:47:32 +0100 Subject: [PATCH] Fix toolbar item validation in the NS port * src/nsterm.m ([EmacsView validateToolbarItem:]): Implement this NSToolbarItemValidation method, which is called by AppKit when it needs to validate an image item in a toolbar. --- src/nsterm.m | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/nsterm.m b/src/nsterm.m index 0e75cbf3f0f..46007ec4fcb 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8573,6 +8573,10 @@ - (instancetype)toolbarClicked: (id)item return self; } +- (BOOL) validateToolbarItem: (NSToolbarItem *) toolbarItem +{ + return [toolbarItem isEnabled]; +} - (instancetype)toggleToolbar: (id)sender { -- 2.34.1 --=-=-=--