Po Lu writes: >> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem >> +{ >> + return [toolbarItem isEnabled]; >> +} >> + > > This does no harm on GNUstep. However, please indent with two spaces, > and place spaces after -, :, and ): > > - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem > { > return [toolbarItem isEnabled]; > } > > Otherwise, LGTM. Thanks. OK, I've attached a new version of the patch. Konrad, could you check if with this patch the Emacs toolbar works as you expect? Thanks.