From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Greg A. Woods" Newsgroups: gmane.emacs.bugs Subject: bug#20539: 24.5; magit-auto-revert-mode broken by 24.5 upgrade with change to behaviour of `let` Date: Sat, 09 May 2015 15:26:55 -0700 Message-ID: References: Reply-To: "Greg A. Woods" NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1431210505 25632 80.91.229.3 (9 May 2015 22:28:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 May 2015 22:28:25 +0000 (UTC) To: 20539@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 10 00:28:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YrDEC-0002x2-An for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 May 2015 00:28:12 +0200 Original-Received: from localhost ([::1]:60621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrDEB-0006RN-JS for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 May 2015 18:28:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrDE7-0006Oq-PE for bug-gnu-emacs@gnu.org; Sat, 09 May 2015 18:28:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrDE2-0002cS-QM for bug-gnu-emacs@gnu.org; Sat, 09 May 2015 18:28:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrDE2-0002cO-Nd for bug-gnu-emacs@gnu.org; Sat, 09 May 2015 18:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YrDE2-0000z8-E2 for bug-gnu-emacs@gnu.org; Sat, 09 May 2015 18:28:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: "Greg A. Woods" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 May 2015 22:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20539 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: GNU Emacs Bugs Original-Received: via spool by submit@debbugs.gnu.org id=B.14312104343727 (code B ref -1); Sat, 09 May 2015 22:28:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 May 2015 22:27:14 +0000 Original-Received: from localhost ([127.0.0.1]:39767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrDDF-0000y2-Kn for submit@debbugs.gnu.org; Sat, 09 May 2015 18:27:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60552) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrDDD-0000xn-Kf for submit@debbugs.gnu.org; Sat, 09 May 2015 18:27:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrDD7-0001yw-GC for submit@debbugs.gnu.org; Sat, 09 May 2015 18:27:06 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrDD7-0001yq-DJ for submit@debbugs.gnu.org; Sat, 09 May 2015 18:27:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrDD6-00069p-E8 for bug-gnu-emacs@gnu.org; Sat, 09 May 2015 18:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrDD1-0001w8-F7 for bug-gnu-emacs@gnu.org; Sat, 09 May 2015 18:27:04 -0400 Original-Received: from centrally.weird.com ([204.92.254.25]:53622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrDD1-0001vp-BW for bug-gnu-emacs@gnu.org; Sat, 09 May 2015 18:26:59 -0400 Original-Received: from (invalid client hostname: bind: DNS error: Unknown host)more.local ((no PTR matching greeting name)S01060026bb6c284e.ok.shawcable.net[24.67.98.78] port=33415) by centrally.weird.com([204.92.254.2] port=587) via TCP with esmtp (2739 bytes) (sender: ) (ident using UNIX) id for ; Sat, 9 May 2015 18:26:58 -0400 (EDT) (Smail-3.2.0.122-Pre 2005-Nov-17 #4 built 2012-Feb-28) Original-Received: from localhost ([127.0.0.1] port=59004) by more.local([127.0.0.1] port=25) via TCP with esmtp (2287 bytes) (sender: ) id for ; Sat, 9 May 2015 15:26:55 -0700 (PDT) (Smail-3.2.0.122-Pre 2005-Nov-17 #1 built 2015-Feb-17) User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Goj ) APEL/10.8 Emacs/23.3 (x86_64--netbsd) MULE/6.0 (HANACHIRUSATO) X-Face: ; j3Eth2XV8h1Yfu*uL{<:dQ$#E[DB0gemGZJ"J#4fH*][ lz; @-iwMv_u\6uIEKR0KY"=MzoQH#CrqBN`nG_5B@rrM8,f~Gr&h5a\= List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102626 Archived-At: So, it appears I (and perhaps edbug) was confused between the function `auto-revert-mode' and the variable of the same name! I should know better! So the problem is more likely just that `auto-revert-handler' is not behaving quite the same way in 24.5 as it did before, specifically with respect to the value of the `auto-revert-mode' variable. Since it is explicitly marked as an internal function I retract my suggestion that the change is in any way a major bug in 24.5. My proposed fix is no doubt wrong too as I think it will just force auto-revert-mode on for each buffer it tries to revert. I've reported the issue to the magit maintainers on github and hopefully someone can find a suitable work-around, though perhaps the real fix will involve enhancing autorevert to make it more amenable to non-interactive interaction with other modules. For my own use I think my hack works anyway because I think I do always want auto-revert-mode for all buffers visiting files in any repository I'm working in. Sorry for any confusion w.r.t. `let'! --=20 Greg A. Woods +1 250 762-7675 RoboHack Planix, Inc. Secrets of the Weird