bug#562: 23.0.60; OSX: make-network-process reuses existing file descriptors

bug#562: 23.0.60; OSX: make-network-process reuses existing file descriptors

[Markus Triska]

When I evaluate the following form in "emacs -Q":

   (progn
     (setq p1 (make-network-process :name "p1" :host "www.fsf.org" :service 80))
     (setq p2 (make-network-process :name "p2" :host "www.fsf.org" :service 80))
     (setq p3 (make-network-process :name "p3" :host "www.fsf.org" :service 80))
     (delete-process p2)
     (process-send-string p3 "there"))

I get:

  Debugger entered--Lisp error: (file-error "writing to process" "bad file descriptor" #<process p3<1>>)
  process-send-string(#<process p3<1>> "hi")

This is because p2 and p3 are both created with infd=outfd=0, thus
closing the channel for p2 also closes that of p3.


In GNU Emacs 23.0.60.1 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-07-13 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
configured using `configure  'CFLAGS=-O0 -g''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

bug#569: 23.0.60; OSX: make-network-process reuses existing file descriptors

[Markus Triska]

> This is because p2 and p3 are both created with infd=outfd=0, thus
> closing the channel for p2 also closes that of p3.

Commenting out a res_init call in process.c makes this go away for me. I
do not know what other consequences this has though:

diff --git a/src/process.c b/src/process.c
index b0bebeb..b5aebdc 100644
--- a/src/process.c
+++ b/src/process.c
@@ -3366,7 +3374,7 @@ usage: (make-network-process &rest ARGS)  */)
       hints.ai_protocol = 0;
 
 #ifdef HAVE_RES_INIT
-      res_init ();
+      /* res_init (); */
 #endif
 
       ret = getaddrinfo (SDATA (host), portstring, &hints, &res);

bug#569: 23.0.60; OSX: make-network-process reuses existing file descriptors

[YAMAMOTO Mitsuharu]

>>>>> On Thu, 17 Jul 2008 16:22:25 +0200, Markus Triska <markus.triska@gmx.at> said:

>> This is because p2 and p3 are both created with infd=outfd=0, thus
>> closing the channel for p2 also closes that of p3.

> Commenting out a res_init call in process.c makes this go away for
> me. I do not know what other consequences this has though:

You can comment it out on Mac OS X, because calling `res_init' does
not make sense at all on that platform.  Neither does linking
libresolv.

  http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg01467.html
  http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg01254.html

So, it turns out to be not only meaningless, but also harmful on a
particular version (10.4) of Mac OS X.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#562: marked as done (23.0.60; OSX: make-network-process reuses existing file descriptors)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]


Your message dated Wed, 13 Aug 2008 20:54:20 -0400
with message-id <87vdy4o1qb.fsf@stupidchicken.com>
and subject line Re: 23.0.60; OSX: make-network-process reuses existing file descriptors
has caused the Emacs bug report #562,
regarding 23.0.60; OSX: make-network-process reuses existing file descriptors
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
562: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=562
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3344 bytes --]

From: Markus Triska <markus.triska@gmx.at>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; OSX: make-network-process reuses existing file descriptors
Date: Tue, 15 Jul 2008 13:33:48 +0200
Message-ID: <m18ww3crfn.fsf@pnsgw3-client030.demo.tuwien.ac.at>

When I evaluate the following form in "emacs -Q":

   (progn
     (setq p1 (make-network-process :name "p1" :host "www.fsf.org" :service 80))
     (setq p2 (make-network-process :name "p2" :host "www.fsf.org" :service 80))
     (setq p3 (make-network-process :name "p3" :host "www.fsf.org" :service 80))
     (delete-process p2)
     (process-send-string p3 "there"))

I get:

  Debugger entered--Lisp error: (file-error "writing to process" "bad file descriptor" #<process p3<1>>)
  process-send-string(#<process p3<1>> "hi")

This is because p2 and p3 are both created with infd=outfd=0, thus
closing the channel for p2 also closes that of p3.


In GNU Emacs 23.0.60.1 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-07-13 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
configured using `configure  'CFLAGS=-O0 -g''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t



[-- Attachment #3: Type: message/rfc822, Size: 1647 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: Markus Triska <markus.triska@gmx.at>, 562-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; OSX: make-network-process reuses existing file descriptors
Date: Wed, 13 Aug 2008 20:54:20 -0400
Message-ID: <87vdy4o1qb.fsf@stupidchicken.com>

> > Commenting out a res_init call in process.c makes this go away for
> > me. I do not know what other consequences this has though:
>
> You can comment it out on Mac OS X, because calling `res_init' does
> not make sense at all on that platform.  Neither does linking
> libresolv.
>
>   http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg01467.html
>   http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg01254.html
>
> So, it turns out to be not only meaningless, but also harmful on a
> particular version (10.4) of Mac OS X.

I've undef'ed HAVE_LIBRESOLV and HAVE_RES_INIT in s/darwin.h, as you
suggested.  Thanks.

bug#569: marked as done (23.0.60; OSX: make-network-process reuses existing file descriptors)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]


Your message dated Wed, 13 Aug 2008 20:54:20 -0400
with message-id <87vdy4o1qb.fsf@stupidchicken.com>
and subject line Re: 23.0.60; OSX: make-network-process reuses existing file descriptors
has caused the Emacs bug report #562,
regarding 23.0.60; OSX: make-network-process reuses existing file descriptors
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
562: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=562
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2867 bytes --]

From: Markus Triska <markus.triska@gmx.at>
To: emacs-pretest-bug@gnu.org
Subject: Re: 23.0.60; OSX: make-network-process reuses existing file descriptors
Date: Thu, 17 Jul 2008 16:22:25 +0200
Message-ID: <m163r4io9q.fsf@gmx.at>


> This is because p2 and p3 are both created with infd=outfd=0, thus
> closing the channel for p2 also closes that of p3.

Commenting out a res_init call in process.c makes this go away for me. I
do not know what other consequences this has though:

diff --git a/src/process.c b/src/process.c
index b0bebeb..b5aebdc 100644
--- a/src/process.c
+++ b/src/process.c
@@ -3366,7 +3374,7 @@ usage: (make-network-process &rest ARGS)  */)
       hints.ai_protocol = 0;
 
 #ifdef HAVE_RES_INIT
-      res_init ();
+      /* res_init (); */
 #endif
 
       ret = getaddrinfo (SDATA (host), portstring, &hints, &res);



[-- Attachment #3: Type: message/rfc822, Size: 1647 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: Markus Triska <markus.triska@gmx.at>, 562-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; OSX: make-network-process reuses existing file descriptors
Date: Wed, 13 Aug 2008 20:54:20 -0400
Message-ID: <87vdy4o1qb.fsf@stupidchicken.com>

> > Commenting out a res_init call in process.c makes this go away for
> > me. I do not know what other consequences this has though:
>
> You can comment it out on Mac OS X, because calling `res_init' does
> not make sense at all on that platform.  Neither does linking
> libresolv.
>
>   http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg01467.html
>   http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg01254.html
>
> So, it turns out to be not only meaningless, but also harmful on a
> particular version (10.4) of Mac OS X.

I've undef'ed HAVE_LIBRESOLV and HAVE_RES_INIT in s/darwin.h, as you
suggested.  Thanks.