bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Sam Steingold]

Gnus has gnus-other-frame.
Now that Emacs has tabs, it would be nice to be able to create a tab
dedicated to Gnus.

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1671
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
http://www.memritv.org http://memri.org http://no2bds.org
He who laughs last thinks slowest.

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Lars Ingebrigtsen]

Sam Steingold <sds@gnu.org> writes:

> Gnus has gnus-other-frame.
> Now that Emacs has tabs, it would be nice to be able to create a tab
> dedicated to Gnus.

Perhaps there should be a more general interface to say "run this
command in a new tab"?  Otherwise we'll end up with a huge bunch of new
foo-other-tab commands.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Sam Steingold]

> * Lars Ingebrigtsen <ynefv@tahf.bet> [2019-10-30 21:58:50 +0100]:
>
> Sam Steingold <sds@gnu.org> writes:
>
>> Gnus has gnus-other-frame.
>> Now that Emacs has tabs, it would be nice to be able to create a tab
>> dedicated to Gnus.
>
> Perhaps there should be a more general interface to say "run this
> command in a new tab"?  Otherwise we'll end up with a huge bunch of
> new foo-other-tab commands.

It is not so much "create a new tab and run gnus there" as the
bookkeeping of having a tab dedicated to gnus.

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1671
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
http://www.memritv.org http://islamexposedonline.com http://camera.org
nobody's life, liberty or property are safe while the legislature is in session

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Lars Ingebrigtsen]

Sam Steingold <sds@gnu.org> writes:

>> Perhaps there should be a more general interface to say "run this
>> command in a new tab"?  Otherwise we'll end up with a huge bunch of
>> new foo-other-tab commands.
>
> It is not so much "create a new tab and run gnus there" as the
> bookkeeping of having a tab dedicated to gnus.

But doesn't that go for all commands?  I guess Gnus is slightly special
in that it uses several windows, but...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Juri Linkov]

>>> Perhaps there should be a more general interface to say "run this
>>> command in a new tab"?  Otherwise we'll end up with a huge bunch of
>>> new foo-other-tab commands.
>>
>> It is not so much "create a new tab and run gnus there" as the
>> bookkeeping of having a tab dedicated to gnus.
>
> But doesn't that go for all commands?  I guess Gnus is slightly special
> in that it uses several windows, but...

I'm not sure if a new command analogous to gnus-other-frame
is needed for tabs.  For a more general interface I believe
we have to rely on display-buffer-alist.

For example, I create a separate tab for each group and
for the group buffer.  Using display-buffer-alist the
rules could look like

  ("\\`\\*Group\\*\\'" .
   (display-buffer-in-tab
    (name . "Gnus")))

  ("\\`\\*Summary \\(.*\\)\\*\\'"
   . (display-buffer-in-tab
      (name . "Group \\1")))

So e.g. the command `M-x gnus RET' will create the tab with the name
"Gnus" automatically, or switch to the existing tab with the name "Gnus".
Opening a summary from the group buffer will either create a new tab
with the name deduced from the summary buffer name, or switch
to the existing tab by name.

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> For example, I create a separate tab for each group and
> for the group buffer.  Using display-buffer-alist the
> rules could look like
>
>   ("\\`\\*Group\\*\\'" .
>    (display-buffer-in-tab
>     (name . "Gnus")))
>
>   ("\\`\\*Summary \\(.*\\)\\*\\'"
>    . (display-buffer-in-tab
>       (name . "Group \\1")))
>
> So e.g. the command `M-x gnus RET' will create the tab with the name
> "Gnus" automatically, or switch to the existing tab with the name "Gnus".
> Opening a summary from the group buffer will either create a new tab
> with the name deduced from the summary buffer name, or switch
> to the existing tab by name.

Yes, that makes more sense than adding a new separate command, so I'm
closing this bug report.  But perhaps an example like this should be
added to the manual?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Sam Steingold]

> * Lars Ingebrigtsen <ynefv@tahf.bet> [2019-11-22 13:10:31 +0100]:
>
> Juri Linkov <juri@linkov.net> writes:
>
>>   ("\\`\\*Group\\*\\'" .
>>    (display-buffer-in-tab
>>     (name . "Gnus")))
>>
>>   ("\\`\\*Summary \\(.*\\)\\*\\'"
>>    . (display-buffer-in-tab
>>       (name . "Group \\1")))

Function `display-buffer-in-tab' is not defined.

> perhaps an example like this should be added to the manual?

+1


-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1671
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
http://americancensorship.org https://jihadwatch.org http://mideasttruth.com
Just because you're paranoid doesn't mean they AREN'T after you.

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Juri Linkov]

>>>   ("\\`\\*Group\\*\\'" .
>>>    (display-buffer-in-tab
>>>     (name . "Gnus")))
>>>
>>>   ("\\`\\*Summary \\(.*\\)\\*\\'"
>>>    . (display-buffer-in-tab
>>>       (name . "Group \\1")))
>
> Function `display-buffer-in-tab' is not defined.

Implementation is left as an exercise for the reader :)

>> perhaps an example like this should be added to the manual?
>
> +1

Ok, will add after implementing it in bug#38354.

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Juri Linkov]

reopen 37998
quit

Sorry, I have to reopen this.  In bug#38354 a new function
display-buffer-in-tab is implemented now, and works fine,
but it doesn't work only in Gnus.

For example, such customization

  (push '("\\`\\*Summary .*\\*\\'" .
          (display-buffer-in-tab
           (name . (lambda (buffer _alist)
                     (setq buffer (buffer-name buffer))
                     (when (string-match "\\`\\*Summary \\(.*\\)\\*\\'" buffer)
                       (format "Group %s" (match-string 1 buffer)))))))
        display-buffer-alist)

fails with the error

  Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 109>)
    select-window(#<window 109>)
    gnus-configure-frame((vertical 1.0 (summary 1.0 point)))
    gnus-configure-windows(summary)
    gnus-summary-read-group-1("nnml:list.emacs-devel" nil t nil nil nil)
    gnus-summary-read-group("nnml:list.emacs-devel" nil t nil nil nil nil)
    gnus-group-read-group(nil t)
    gnus-group-select-group(nil)
    funcall-interactively(gnus-group-select-group nil)
    call-interactively(gnus-group-select-group nil nil)
    command-execute(gnus-group-select-group)

This is because gnus-configure-frame expects an old window to be live,
but it's not, because tabs switch window-configurations in pop-to-buffer
using display-buffer-in-tab.

Maybe gnus-configure-frame should check if an original window is
still alive?

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> This is because gnus-configure-frame expects an old window to be live,
> but it's not, because tabs switch window-configurations in pop-to-buffer
> using display-buffer-in-tab.

Hm, I see.  I haven't used tabs yet myself...

> Maybe gnus-configure-frame should check if an original window is
> still alive?

Possibly?  Could you suggest a patch?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Juri Linkov]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

>> Maybe gnus-configure-frame should check if an original window is
>> still alive?
>
> Possibly?  Could you suggest a patch?

Maybe something like (together with documentation addition):


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-tabs.patch --]
[-- Type: text/x-diff, Size: 2934 bytes --]

diff --git a/lisp/gnus/gnus-win.el b/lisp/gnus/gnus-win.el
index b39c9faab6..bcf90f1d55 100644
--- a/lisp/gnus/gnus-win.el
+++ b/lisp/gnus/gnus-win.el
@@ -367,11 +367,14 @@ gnus-configure-frame
 	    (setq result (or (gnus-configure-frame
 			      (car comp-subs) window)
 			     result))
-	    (select-window new-win)
-	    (setq window new-win)
+            (if (not (window-live-p new-win))
+                ;; pop-to-buffer might have deleted the original window
+                (setq window (selected-window))
+              (select-window new-win)
+	      (setq window new-win))
 	    (setq comp-subs (cdr comp-subs))))
 	;; Return the proper window, if any.
-	(when result
+	(when (window-live-p result)
 	  (select-window result)))))))
 
 (defvar gnus-frame-split-p nil)
diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi
index e43aa92c99..d563d52d58 100644
--- a/doc/misc/gnus.texi
+++ b/doc/misc/gnus.texi
@@ -813,6 +813,7 @@ Top
 * Symbolic Prefixes::           How to supply some Gnus functions with options.
 * Formatting Variables::        You can specify what buffers should look like.
 * Window Layout::               Configuring the Gnus buffer windows.
+* Tabbed Interface::            Configuring the Gnus tabs.
 * Faces and Fonts::             How to change how faces look.
 * Mode Lines::                  Displaying information in the mode lines.
 * Highlighting and Menus::      Making buffers look all nice and cozy.
@@ -22189,6 +22190,7 @@ Various
 * Symbolic Prefixes::           How to supply some Gnus functions with options.
 * Formatting Variables::        You can specify what buffers should look like.
 * Window Layout::               Configuring the Gnus buffer windows.
+* Tabbed Interface::            Configuring the Gnus tabs.
 * Faces and Fonts::             How to change how faces look.
 * Mode Lines::                  Displaying information in the mode lines.
 * Highlighting and Menus::      Making buffers look all nice and cozy.
@@ -22985,6 +22987,36 @@ Window Layout
 @end itemize
 
 
+@node Tabbed Interface
+@section Tabbed Interface
+@cindex tabbed interface
+@cindex tabs
+
+Gnus supports display of different buffers in dedicated tabs
+that you can select using the tab bar.
+
+To open the group buffer in a new tab named @samp{Gnus}, use:
+
+@lisp
+(push '("\\`\\*Group\\*\\'" .
+        (display-buffer-in-tab
+         (name . "Gnus")))
+      display-buffer-alist)
+@end lisp
+
+To read every summary in a separate explicitly named tab, use:
+
+@lisp
+(push '("\\`\\*Summary .*\\*\\'" .
+        (display-buffer-in-tab
+         (name . (lambda (buffer _alist)
+                   (setq buffer (buffer-name buffer))
+                   (when (string-match "\\`\\*Summary \\(.*\\)\\*\\'" buffer)
+                     (format "Group %s" (match-string 1 buffer)))))))
+      display-buffer-alist)
+@end lisp
+
+
 @node Faces and Fonts
 @section Faces and Fonts
 @cindex faces

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Juri Linkov]

>>> Maybe gnus-configure-frame should check if an original window is
>>> still alive?
>>
>> Possibly?  Could you suggest a patch?
>
> Maybe something like (together with documentation addition):

Installed and closed.

bug#37998: 27.0.50; gnus RFE: gnus-other-tab a la gnus-other-frame

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> Maybe something like (together with documentation addition):

That looks good to me (I think), so go ahead and apply.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no