From: Sam Steingold <sds@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 36697@debbugs.gnu.org
Subject: bug#36697: 27.0.50; gnus: some articles with score 0 are killed
Date: Fri, 24 Jul 2020 14:37:32 -0400 [thread overview]
Message-ID: <m18sf8n4ib.fsf@gnu.org> (raw)
In-Reply-To: <87o8o5aq6m.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 24 Jul 2020 17:27:45 +0200")
> * Lars Ingebrigtsen <ynefv@tahf.bet> [2020-07-24 17:27:45 +0200]:
>
> Sam Steingold <sds@gnu.org> writes:
>
>> `gnus-score-string' is called from `gnus-score-headers',
>> `search-func` is `re-search-backward'
>> It is called on line 2148 on `match' which is "[^a-z]\\{50\\}".
>> So, it matches for _all_ subjects - _before_ the last 3 - because it
>> searches _across_ lines!
>
> Oh, yeah, I had forgotten that -- it's a neat hack to speed up the time
> to score big groups: Calling re-search-backward is much, much faster
> than looping over the headers and using string-match. But it does mean
> that if you have regexps like [^a-z], they have to have a \n in them,
> too.
So what's the verdict?
Fix the code or modify my regexp and document the "feature"?
>> PS. The code in gnus-score.el seems to avoid modern Emacs-Lisp features
>> like `dolist' and `when'. Is there a (non-historical) reason for that?
>> Also, the functions are very long and thus hard to edebug.
>
> It's just very, very old code, trying to be maximally fast.
you wrote it over 20 years ago, right?
time flies...
>> I had to extract some loops into separate functions to speed up stepping.
>> Is it okay to commit?
>
> Is there a performance impact?
I have no idea - but a general "code modernization", including a switch
to lexical bindings and using return values instead of global variables
to pass information around - would probably speed up the code.
(and make it thread safe!)
--
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1894
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
https://americancensorship.org https://thereligionofpeace.com
Money does not "play a role", it writes the scenario.
next prev parent reply other threads:[~2020-07-24 18:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 20:51 bug#36697: 27.0.50; gnus: some articles with score 0 are killed Sam Steingold
2019-09-23 23:15 ` Lars Ingebrigtsen
2019-09-23 23:39 ` Sam Steingold
2019-09-24 7:34 ` Lars Ingebrigtsen
2019-09-24 18:24 ` Sam Steingold
2019-09-25 13:07 ` Lars Ingebrigtsen
2020-01-08 17:13 ` Sam Steingold
2020-01-08 17:19 ` Sam Steingold
2020-01-15 16:09 ` Sam Steingold
2020-01-22 12:53 ` Lars Ingebrigtsen
2020-07-19 15:40 ` Lars Ingebrigtsen
2020-07-20 23:11 ` Sam Steingold
2020-07-23 13:56 ` Lars Ingebrigtsen
2020-07-23 20:04 ` Sam Steingold
2020-07-24 15:27 ` Lars Ingebrigtsen
2020-07-24 18:37 ` Sam Steingold [this message]
2020-07-27 21:45 ` Lars Ingebrigtsen
2022-04-17 18:08 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m18sf8n4ib.fsf@gnu.org \
--to=sds@gnu.org \
--cc=36697@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).