From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52170: 29.0.50; [PATCH] Use mupdf in doc-view-mode if gs is not installed Date: Mon, 29 Nov 2021 00:15:40 +0100 Message-ID: References: Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35816"; mail-complaints-to="usenet@ciao.gmane.io" To: 52170@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 29 00:17:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrTQ0-00097j-En for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Nov 2021 00:17:12 +0100 Original-Received: from localhost ([::1]:36354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrTPy-0004hz-Hn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Nov 2021 18:17:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrTPr-0004hk-2R for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2021 18:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrTPq-0004q7-QJ for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2021 18:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrTPq-0007b8-Kk for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2021 18:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Nov 2021 23:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52170 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163814137029137 (code B ref -1); Sun, 28 Nov 2021 23:17:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Nov 2021 23:16:10 +0000 Original-Received: from localhost ([127.0.0.1]:36528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrTOq-0007ZE-KI for submit@debbugs.gnu.org; Sun, 28 Nov 2021 18:16:10 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:38008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrTOl-0007Z3-PF for submit@debbugs.gnu.org; Sun, 28 Nov 2021 18:15:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrTOl-0004fX-6a for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2021 18:15:55 -0500 Original-Received: from sonic306-21.consmr.mail.ir2.yahoo.com ([77.238.176.207]:42416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrTOg-0004lS-Nx for bug-gnu-emacs@gnu.org; Sun, 28 Nov 2021 18:15:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1638141347; bh=Im5WEuuSh21m54aCeMOPj8LpBtjIRtWMYHENCY7g1Ec=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=FOIh9Ixz2EZTQFStn46v1Vut/85jfIjY2ALoFyzYgJ/L0UL6S+zgT1nfJCpQWlRG13X5OrqwzO9cB1qEURU6Tb3P7qZpzxgKL8yzzPmzMBu9BwKc4tIBgy+qb7PCAPcDZhyBOoAjx+cKuheQ9XgTo7dJL3A0xM6Hk3AtnNdHbK/MfLgFAhmWWLIiGm+4/rwYTAhhhjQAfi/IU0xjJwiZgrfBbews0RmBsjPtte1kcR0mdv4iXoeFiP0xRfVfI0Eu0irx3ogv8At6PJxKmKFpFCXMKZQoOG8+tv4Vi8QwGWl5AvNK0jMzFELPvRbnDLt6qv0+gcMjmGkQGpxrAGKokA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1638141347; bh=Ia0qGoBqEfQBt7cQ1pU1WE8GL+YoAFFvl1UsuXawRQC=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=hZ5E7kHI9XsvJWaT1HJWHtE1XZrlNuUSac4VBqxg/eaA8HGgJxhaLCbbI2pPW1JhHwR1XpQ7fPmM9ZslDRafdcnyQtEq/m5WIsmGAGCMkosAgMaZrcnNyds8etbdh4rPB0XZPeo3Sksuqm+Gn7aUYY2KmSiF9NYFdWn/1tc2RustTe+xxgS7n7vPK3kpsjrYDhZy6GkseXsldpjwoHODOhskZdSbwI2vnelg3UP2jrNWTpv68heux7BC6n5OCG4rbvVF20ihRJbxmzaBeMKlxiMQ1473hBoQUBD8J9XvP1HXZwuSV0VW8IJKvHK5TKFSZRyATXD8LHolp9mMjPEOMA== X-YMail-OSG: 7b7eIGEVM1lyb2vi1KCHGKyhAneTQuP1_.JcSaphI.5SBji.FHDOd6Jtk2AaBzr K.t2fB5hZbegHbwrHdzw5_VbEpov8fhKZXoAR25oXcv17lcMYAATo4k6lo904SmE11swD1kBRL6A O0.KkMTOmy5Mk1rc9m9mTQqSknEi3MdNoPkRutmv6VWzNge12qXKCd_M1xARuBexFY5aOE42BL8J Dn.py.eZyd9aOHn_YjMHkp.vqCfuvjxV08i1cf8XBF5AQ8w9yJTADFXiKI08uC.usaVqpH074DWn AZTVHHrVydVYhB_xKdrmMD4s0VQyDJn7I63wnFg0TkdKKt4YrPsdh5Z1ya8dW_xNV8rdLfwOX339 AElWszXiOeQroZwBVT6eKFsgHSTAQie.Q96XX_xxFM1Loq49M6nF7zzGJM28Ca34draoL8s5127x yffvbv3GPFfM38IHb7bF2qN__kZy4vLTkqrNJnfaTY0t1N32ZhXO6TXEKLRhTecfMRoxRDKwIkOi EzR2.Y_qB43KjFfi7ZPCGIXvaxQgcEg_NdlKxGMjPLnMY.uJJN2Ajxj3h4CXPVXcVt5jJ4RhY_lR GDp4DVV2_XyfIFqAQ943iDRU0oNrXf2VlXHY_eZLEl5rMiar1XDDk4U0xv0ks3Teo3PK2Ndec.y4 KFVhIT3a1Oe9HkCnpSr5p3w_hBkczuPofLKnHJ2wNAKNxNijyvgm_x6uVzEns4XfJevJFnwr2TOB f77cuSiR8.eGT4Lw6CjDZqsRkm6q9QpvDSFKMoN1GNMylX3GIDmx32g5zraIJZdJZK1AENa.xA2M Vw9K36dQ9BxPuxO8J9UCw89WmZY9WCtYj5SXS8rRa_ X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ir2.yahoo.com with HTTP; Sun, 28 Nov 2021 23:15:47 +0000 Original-Received: by kubenode520.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 2e5e7193693bf2f94337c17d318d0302; Sun, 28 Nov 2021 23:15:42 +0000 (UTC) X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=77.238.176.207; envelope-from=mardani29@yahoo.es; helo=sonic306-21.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220982 Archived-At: --=-=-= Content-Type: text/plain The Emacs manual says that mupdf (mudraw) can be used to render PDF/PostScript documents in doc-view-mode. However, I couldn't make it work on a macOS system with only mupdf installed (no Ghostscript). The fix seems to be simple, and with the attached patch I'm able to render and browse PDFs correctly. All doc-view features described in the manual seem to work just fine. If you think the patch is a good idea, please install it on my behalf. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-mupdf-in-doc-view-mode-if-gs-is-not-installed.patch >From 3a0fcc8a24923b997d6737082f0125de02778e9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Sun, 28 Nov 2021 23:59:05 +0100 Subject: [PATCH] Use mupdf in doc-view-mode if gs is not installed * lisp/doc-view.el (doc-view-mode-p): Use mupdf to render PDF and related formats if gs is not installed. --- lisp/doc-view.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 7e113e4f34..11559bf2f5 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -811,9 +811,10 @@ doc-view-mode-p (and doc-view-dvipdfm-program (executable-find doc-view-dvipdfm-program))))) ((memq type '(postscript ps eps pdf)) - ;; FIXME: allow mupdf here - (and doc-view-ghostscript-program - (executable-find doc-view-ghostscript-program))) + (or (and doc-view-ghostscript-program + (executable-find doc-view-ghostscript-program)) + (and doc-view-pdfdraw-program + (executable-find doc-view-pdfdraw-program)))) ((eq type 'odf) (and doc-view-odf->pdf-converter-program (executable-find doc-view-odf->pdf-converter-program) -- 2.31.0 --=-=-=--