From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kickingvegas@gmail.com, 71927@debbugs.gnu.org,
"Basil L. Contovounesios" <basil@contovou.net>,
John Paul Wallington <jpw@gnu.org>, Juri Linkov <juri@linkov.net>
Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input
Date: Thu, 04 Jul 2024 09:12:10 +0200 [thread overview]
Message-ID: <m18qyhtyut.fsf@dazzs-mbp.home> (raw)
In-Reply-To: <861q49a8vt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jul 2024 10:55:50 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 71927@debbugs.gnu.org
>> From: Juri Linkov <juri@linkov.net>
>> Date: Thu, 04 Jul 2024 09:58:18 +0300
>>
>> > The commands ibuffer-do-isearch and ibuffer-do-isearch-regexp
>> > do not prompt for an input search string.
>>
>> They should not prompt because Isearch is interactive.
>> But the problem is that they exit Isearch immediately.
>> I tried to Edebug ibuffer-do-isearch, but this is
>> not possible.
>
> So did I, with the same results.
>
> I also see that this didn't work at least as far back as Emacs 25,
> maybe never.
>
> The function ibuffer-do-isearch was added by you, and was never
> changed before. I guess it somehow violates the protocol of
> define-ibuffer-op or something? Admittedly, that protocol is not
> described too well in the doc string.
>
> I have a question: ibuffer-do-isearch just calls
> multi-isearch-buffers. Does multi-isearch-buffers exit immediately,
> or does it exit only when the multi-isearch is done? If the former, I
> guess this is why the problem happens.
>
>> So we need someone who knows ibuffer internals.
>
> I've added two people who might be able to help.
FWIW, AFAICT everything is working correctly, it's just that the
"Operation finished" message hides the prompt. ibuffer-do-isearch
should tell define-ibuffer-op not to display that message, somehow.
Best,
Eshel
next prev parent reply other threads:[~2024-07-04 7:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 21:25 bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Charles Choi
2024-07-04 6:58 ` Juri Linkov
2024-07-04 7:55 ` Eli Zaretskii
2024-07-04 7:12 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-07-04 9:59 ` Eli Zaretskii
2024-07-04 10:06 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 12:50 ` Eli Zaretskii
2024-07-04 13:32 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 14:12 ` Eli Zaretskii
2024-07-04 15:09 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 16:04 ` Juri Linkov
2024-07-04 17:36 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 18:07 ` Eli Zaretskii
2024-07-04 18:29 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 18:46 ` Eli Zaretskii
2024-07-06 21:13 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-07 16:59 ` Juri Linkov
2024-07-12 7:03 ` Eli Zaretskii
2024-07-12 10:20 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-12 17:05 ` Charles Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m18qyhtyut.fsf@dazzs-mbp.home \
--to=bug-gnu-emacs@gnu.org \
--cc=71927@debbugs.gnu.org \
--cc=basil@contovou.net \
--cc=eliz@gnu.org \
--cc=jpw@gnu.org \
--cc=juri@linkov.net \
--cc=kickingvegas@gmail.com \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).