unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Morgan Willcock <morgan@ice9.digital>
Cc: 73234@debbugs.gnu.org
Subject: bug#73234: 30.0.91; completion-preview-mode doesn't trigger for case-insensitive capf
Date: Fri, 20 Sep 2024 11:27:19 +0200	[thread overview]
Message-ID: <m18qvm7k08.fsf@re-byods-146-50-199-107.wireless.uva.nl> (raw)
In-Reply-To: <877cb7sn96.fsf@ice9.digital> (Morgan Willcock's message of "Thu,  19 Sep 2024 15:59:17 +0100")

Hi,

Morgan Willcock <morgan@ice9.digital> writes:

> Eshel Yaron <me@eshelyaron.com> writes:
>
>>> I've been trying to think of a way to get it to work without disturbing
>>> the user interface that already exists.  Maybe it would be possible
>>> fixup the result in a post-insertion hook if one existed - such a hook
>>> might be generally useful anyway.
>>
>> We have the :exit-function (which your capf can provide as an extra
>> property alongside the completion table it returns), and indeed you
>> could use that to "fix" the case of your prefix after completing it.
>
> I don't think it is the responsibility of the completion function
> because it is not the completion function that is modifying the buffer.
>>
>> That's an interesting solution, I think.  Or do you have some other kind
>> of hook in mind?
>
> Just a hook that runs after it was completion-preview-mode that inserted
> a completion.

I'm quite not sure what you mean by responsibility, but in terms of
functionality, :exit-function is the existing interface for doing
something after a completion is inserted, and Completion Preview mode
supports this interface.

If :exit-function doesn't work for your use case, please explain why,
and if there's indeed a need for another hook, it's easy to add one :)


Thanks,

Eshel





  reply	other threads:[~2024-09-20  9:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 19:23 bug#73234: 30.0.91; completion-preview-mode doesn't trigger for case-insensitive capf Morgan Willcock
2024-09-14  6:07 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14  9:53   ` Morgan Willcock
2024-09-14 16:23     ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14 20:46       ` Morgan Willcock
2024-09-15  6:40         ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-17 19:03           ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-18 20:23             ` Morgan Willcock
2024-09-19  5:39               ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-19 14:59                 ` Morgan Willcock
2024-09-20  9:27                   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-20 10:05                     ` Morgan Willcock
2024-09-20 10:34                       ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m18qvm7k08.fsf@re-byods-146-50-199-107.wireless.uva.nl \
    --to=bug-gnu-emacs@gnu.org \
    --cc=73234@debbugs.gnu.org \
    --cc=me@eshelyaron.com \
    --cc=morgan@ice9.digital \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).