From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#24149: 25.1; set-transient-map bug Date: Thu, 04 Aug 2016 20:17:04 +0800 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1470313113 1922 195.159.176.226 (4 Aug 2016 12:18:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 4 Aug 2016 12:18:33 +0000 (UTC) Cc: Stefan Monnier To: 24149@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 04 14:18:25 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVHbR-0007ZD-Iw for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Aug 2016 14:18:21 +0200 Original-Received: from localhost ([::1]:39473 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVHbM-0007uC-Pa for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Aug 2016 08:18:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVHbE-0007sP-CY for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2016 08:18:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVHb8-0005LF-U7 for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2016 08:18:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVHb8-0005L2-RR for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2016 08:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bVHb8-0001y7-Kj; Thu, 04 Aug 2016 08:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Aug 2016 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.14703130587530 (code B ref -1); Thu, 04 Aug 2016 12:18:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Aug 2016 12:17:38 +0000 Original-Received: from localhost ([127.0.0.1]:55285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVHaf-0001xI-Fz for submit@debbugs.gnu.org; Thu, 04 Aug 2016 08:17:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVHaZ-0001x1-NE for submit@debbugs.gnu.org; Thu, 04 Aug 2016 08:17:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVHaT-0005FD-GK for submit@debbugs.gnu.org; Thu, 04 Aug 2016 08:17:22 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVHaT-0005Eq-Cr for submit@debbugs.gnu.org; Thu, 04 Aug 2016 08:17:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVHaR-0007Kx-BM for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2016 08:17:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVHaM-0005D8-5y for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2016 08:17:19 -0400 Original-Received: from mail-pa0-x243.google.com ([2607:f8b0:400e:c03::243]:33091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVHaL-0005Cr-Un for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2016 08:17:14 -0400 Original-Received: by mail-pa0-x243.google.com with SMTP id q2so17160665pap.0 for ; Thu, 04 Aug 2016 05:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=ySQsO/UxfExU27/11PPqwiVr4PRsO5XOReo2xc91WiE=; b=QqLO3hIvSAl2F5l9VjodcAHQ9b0apYG8YXWtEfyAkexE5oPZUkqeB9Tvrlpkzg/lLA qZf17p6zTP2RGhMj1QrSy1SEUKowYygt4SDdwhQCq9+HcknUA1XCSZ3gSXoZsx7qKjJ/ L1PCXAiNmNUIodfp4eki3kaYv8GHVXvgpa+JSYXr+Ny1IrZe3j4x7jJq0IlO3+D2zITG 7/E/EWPj7Mh2qB+hbID8H1/5Ib6Xj3ZvXO2zyDy6yT1/u9n44Vduk7WkvDosDMVtoDyC X6Bde0TZ6Mj945cCUW/jGHGW8Rwm0HztR076xS4jA/1lp6UCHKX/1J5mhLTHmzr3U9+M vVtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=ySQsO/UxfExU27/11PPqwiVr4PRsO5XOReo2xc91WiE=; b=SnI1Dvs5D24Kw1HC4q4DmPQ/wzdn0cyeJkdx9nmJyZpWhMJXmtkeBCuTRp/jUFyPo4 A4V6rSSRiJ0UvY8INWZZgaKmHyLAIV+cOe/SWTg6Don9kVjWOfB4Vocpui9XpTYeL1fr Z33Ks8PC+pSUviSTK0+s3cb7zI0e3R/g4FwT3V85PY9ZpJ5GhM8bYvDKpAWC9hdAeINs sdyFdjtPrBF9bj8SJ4Ddy67r6o3ejfNJZtwn2QUUd+cqPAjxEmnMgEpGrN/dGCi4qVLV MqBmdsc60IX3rYJGzGO8obtIiC3H9JOLX0SRckbCfPFYr0PcMcDl6F11nvWR5ZMBhREr VaOA== X-Gm-Message-State: AEkoouuUqO9F10NmviGGIH4J+8r+RsHJbCzBkrHQMxHE8CMmswgeXpwf5TYcL9jj2dL+gQ== X-Received: by 10.66.155.7 with SMTP id vs7mr100925080pab.154.1470313032669; Thu, 04 Aug 2016 05:17:12 -0700 (PDT) Original-Received: from zeuss-MacBook-Pro.local ([128.199.175.219]) by smtp.gmail.com with ESMTPSA id y2sm20111299pan.31.2016.08.04.05.17.10 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Aug 2016 05:17:11 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121816 Archived-At: 1. Enable temp-buffer-browse-mode 2. (cl-loop repeat 2 do (with-output-to-temp-buffer "*test*" (princ "ok"))) 3. Check pre-command-hook #:clear-transient-map will be there forever. The issue is caused by two identical calls of set-transient-map that share the same keymap. so deactivation of the second call has an side-effect on the first call. Stefan, is the following the right fix? Thanks, Leo diff --git a/lisp/subr.el b/lisp/subr.el index 2c0be204..b6a38778 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -4542,7 +4542,8 @@ to deactivate this transient map, regardless of KEEP-PRED." (with-demoted-errors "set-transient-map PCH: %S" (unless (cond ((null keep-pred) nil) - ((not (eq map (cadr overriding-terminal-local-map))) + ((and (keymapp (cadr overriding-terminal-local-map)) + (not (eq map (cadr overriding-terminal-local-map)))) ;; There's presumably some other transient-map in ;; effect. Wait for that one to terminate before we ;; remove ourselves.