From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74091: 31.0.50; string-pixel-width in mode line disables region Date: Mon, 11 Nov 2024 07:52:32 +0100 Message-ID: References: <86y1254owq.fsf@gnu.org> <86ldy54m2g.fsf@gnu.org> <86ed3w33g1.fsf@gnu.org> <8634k0mkgy.fsf@gnu.org> <86ttcgl1f0.fsf@gnu.org> <86ses0l0g3.fsf@gnu.org> <86o72nljrc.fsf@gnu.org> <86jzdblgza.fsf@gnu.org> <86frnzl68c.fsf@gnu.org> <868qtqlwzk.fsf@gnu.org> <8634jylaj2.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21077"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: monnier@iro.umontreal.ca, 74091@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 11 07:53:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tAOIg-0005Iy-Ef for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Nov 2024 07:53:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAOIN-000467-L4; Mon, 11 Nov 2024 01:53:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAOIJ-00045i-M5 for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2024 01:53:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAOII-0001qB-4r for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2024 01:53:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=zIRtelLI9vEH0ZlcpwuGsQ570qHQFHsSrHbn10389u4=; b=guvnP9S7JP634oRLm1sbqDYWY3CY3Atn1WzQHVUde/x7ro3lQfDUx1ZPD3GRk5Rp+nDwAgwPF1cos1nSmrv8F2TpH6U/iMuBh/YnrVlglQC+87PzhPTbZjByirSzYD3/fn+nMT0qIxtRLGrdG2r6IE1QmHp/7z2bfI7ibgpfwzUTLCXLyU3GpwoUHoJhCQZlA2sEq9XuhKndWUPXBXzZPws4ZaUKJFqyyPtJOEPDSb2Uv/5UIclW1kLeTliBNWzvY5OZ/M+VIhhQHWEl9aPkAu0r3tBmtnGtm84bp9kiVIwLbKBbw97waKWf19BGXZnJpnUdZBYSrt5MVbT6L9d3Kg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAOIH-0007pL-Tq for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2024 01:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Nov 2024 06:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74091 X-GNU-PR-Package: emacs Original-Received: via spool by 74091-submit@debbugs.gnu.org id=B74091.173130795730050 (code B ref 74091); Mon, 11 Nov 2024 06:53:01 +0000 Original-Received: (at 74091) by debbugs.gnu.org; 11 Nov 2024 06:52:37 +0000 Original-Received: from localhost ([127.0.0.1]:57905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAOHs-0007oc-Tc for submit@debbugs.gnu.org; Mon, 11 Nov 2024 01:52:37 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:60816 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAOHr-0007oU-9u for 74091@debbugs.gnu.org; Mon, 11 Nov 2024 01:52:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1731307954; bh=PEMhrcOWnHs70pR+I2QjTrZCyou45QqCiephGYLolJs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=icL0WTQDPg6HsmCzJcoP9apsRWw1HAyJKUCVoXpW01syhZwZ2kaOuZzOnVCMKqkG6 d7gu4CY8toFuKPSQNirq47Tldhc/iw3EvuBuNJI3P4ZqG5Jurq0cmHp+b4XLkMz0sV J5e4VE7C7RH5+isXVUL89w3khY1EsACur4P766mUcUQd0+A1GfA5YqTqB7OYx/fMPm AcE9pDV7BnbBSHpqgBLXaAVHSMNY/1VURPdOtTdssTFoZzx/Gh/Ph+ezF/Q6Ua9KY2 I90WH/Jkr89nCriOaftssS+/KTkeHlSCQaUZiJYXnYSzEFQjO5mBS8efHyk7zdNr3B Cmj/fAfQIcE7Q== In-Reply-To: <8634jylaj2.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Nov 2024 05:22:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295219 Archived-At: Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: Stefan Monnier , 74091@debbugs.gnu.org >> Date: Sun, 10 Nov 2024 21:19:58 +0100 >> >> Eli Zaretskii writes: >> >> >> From: Stefan Monnier >> >> Cc: me@eshelyaron.com, 74091@debbugs.gnu.org >> >> Date: Sun, 10 Nov 2024 11:46:47 -0500 >> >> >> >> > Sorry, here's the correct patch: >> >> >> >> Oh, right, I had !(...||...) >> >> Thanks, LGTM! >> > >> > Thanks, installed on the emacs-30 branch. >> >> Thank you both for getting to the bottom of this issue. Note that once >> this fix lands on master, we should be able to revert 57fe24961fd. >> Works well for me so far. > > I see no need to revert that commit, it doesn't cause any problems > AFAICT. The potential problem is misleading or confusing folks reading this code in the future, since it implies (quite explicitly with the comments) that there's a need to bind deactivate-mark, where in fact there isn't. But OK, it's a small concern, so if you find it harmless I won't insist. Eshel