From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Unknown Newsgroups: gmane.emacs.bugs Subject: bug#45443: 28.0.50; Can't find definition of compilation--message->loc Date: Sun, 27 Dec 2020 20:28:57 +0100 Message-ID: References: > <83a6u0n8y7.fsf@gnu.org>> <83lfdjkuzd.fsf@gnu.org> Reply-To: =?UTF-8?Q?Reply-to=3A_Daniel_Mart=C3=83=C2=ADn_=3Cmardani29=40yahoo=2Ees?= =?UTF-8?Q?=3E=0A?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32716"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: rms@gnu.org, akrl@sdf.org To: 45443@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 27 20:30:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ktbkH-0008QQ-0W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 20:30:25 +0100 Original-Received: from localhost ([::1]:45040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktbkF-0007TR-Uv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Dec 2020 14:30:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktbjw-0007SY-At for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 14:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktbjv-00009W-TV for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 14:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktbju-0001TP-Q6 for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 14:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2020 19:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed X-Debbugs-Original-To: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Eli Zaretskii , 45443@debbugs.gnu.org, rms@gnu.org, Andrea Corallo Original-Received: via spool by submit@debbugs.gnu.org id=B.16090973525582 (code B ref -1); Sun, 27 Dec 2020 19:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Dec 2020 19:29:12 +0000 Original-Received: from localhost ([127.0.0.1]:33546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktbj5-0001Ry-Oq for submit@debbugs.gnu.org; Sun, 27 Dec 2020 14:29:12 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:38992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktbj3-0001Rn-0j for submit@debbugs.gnu.org; Sun, 27 Dec 2020 14:29:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktbj2-0007Ke-Pc for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 14:29:08 -0500 Original-Received: from sonic312-26.consmr.mail.ir2.yahoo.com ([77.238.178.97]:42425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktbiw-0008F6-0D for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2020 14:29:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1609097340; bh=S4OcmgCUhkI5a9PGcmY5qqlYUUJ6u+3s1QMBI1v7pEk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=kK500GSHOJdMJ23h/YjgIjjEoh1pPFzhMPuF11KfQCvodR1Vw81tgyG2kzKaG6VzzNy4Uuv1Cpas52HLGNtBm+NRZxZsJ1rBAU9jPARSFi4QD7p8c36Fhb62IQvueu0aaZhnkznrSXW47d2AAV7UYY2/6/Qm/Wqxre7IE926dFdeiJkTWVGZrjzyS1hY1ocqwEaNmfQB8gNljYhkWAQ2rlwrUY4ZGvB8ItBQo1n38lHqOxI3Y1Pqx7bZwTqxm58/cQq59rbi3B2dxAHGC94z58XhVXDb/UmQN3k48M4+gLVkxT+9BCpa3uh2GDL8r4gcl7S9LqvrpqL64u+7gtiVLA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1609097340; bh=YnrbBeExyo3Z1/dQv+tN8T8aex6W9C03kaiSmM0ev3c=; h=From:To:Subject:Date:From:Subject; b=GOrd9YsqKRcIxJtesxLh3Rpkz2htvMjOkUpBPPjz/NFYbTKz2U4BOwvVqu7+pnFXT0wWsyZvDtvPdROPehLHmZwho1YP2cJ3vRP+7XIuO3G2w9vn84QcfMJETy65flIbDFUKjgEfz/ItjpjlBWY1rrJg81RgNGmSttYFsXT2lJs2LO8BPPxPEA1kJ8NV9I9+LLC6M1CXijp+UD1V9bT1ig9BEPobBc8l9KbYHFknfU864oKvwtX3ZnMsVkE5kbO1oUuQtvY6IZHZdcW38V1lh0xXVtPijHnVuJPzo90EomJuEPLAJ6a/NYn1CF/S244QuFjLOoZQZMKmKXCc8rkpyg== X-YMail-OSG: _64e8IQVM1l3QGbZK6hyi6MHuWHtm5.IUg_6BgC8csK6Lie37A7YhFDCFNcLTt8 19V9lSLvsbsIorldCP9cORRw4C_G3lHtetfkd8kneJy6w1LpadjyWoyuNmXMSBvxaNkqSTIj04ai Tsw3GWGqGoIXevhMSXDdCb3815unKJxz9mn8OrqS8sZy0aOwLW8QkzZEnD2N7yuZM78.3.YNny3D wOvuQgH9V4xl93yfPiOc_6_TfVqYOVJmK_j89lCajl9Ti_dLPFkxF4CK3t49mMT2sp.X1lUf.cGh oJnVZJmdIw436ENImElDzqukQioF3Fjzo3kWaj6lfXIS55cF0mi1CwFQ5ICdEI03_UqT_GpI8uHC fRcDrw4eo_U.OkJ_61GATnzS3ivNUVH8HjIlWpQu7ZbOrl3JR2ta77datBfGXAhEaTWYkL_qt4_m CUDez_Gf2Y8Q9hudCIVaz_SjJh6DyF9ggMtznhCpFb5iKq2i4598IjsZWDpNQIemy_N7oVdk9Xwm GLKOGtVSdheKXsPvfCTBuYr_eLbT2aYnJLWVhHIc.bkaonv2eDXBNIZsMbcRs7GM7PXiTChflckt xkTCU9npDsB0NEZUKIE1E003NCxwcUdvF3Xu4y2TtKGu00g.3UQ1dVYeMeJ917hu9O.X3YfvEYPY z.oNLWWCphsxMsQyaUEs0CXH.4a7QU2jQVA8qqu32Pd0i50XKW5maTeIw1TlWVH6GnN6txXGLiPU aFirKEtQdlqED6p10zlW2uzER715gwlpldbhUfhAmFQfH5s7f.QKpJUnSBjnlQO9q3Tmqgst_IWN 22TABW_04jfZw_ELzgWxLA5VzmeRz_qDepYSra4e7i Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Sun, 27 Dec 2020 19:29:00 +0000 Original-Received: by smtp406.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 57a4ed810b19b9f449fa553014060dc8; Sun, 27 Dec 2020 19:28:58 +0000 (UTC) In-Reply-To: (Andrea Corallo via's message of "Sun, 27 Dec 2020 17:59:09 +0000") X-Mailer: WebService/1.1.17278 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=77.238.178.97; envelope-from=mardani29@yahoo.es; helo=sonic312-26.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Original-From: Xref: news.gmane.io gmane.emacs.bugs:196819 Archived-At: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> >> Why do we need to expand macros? isn't it enough to find the defstruct >> itself, by looking for a partial match? > > I haven't look at the patch, but I think the approach of macro expanding > is more general as should be able to track any function definition that > is synthesized by any macro. > Yes, my patch tried a more general approach, which would not only find function definitions, but also defvars like the hooks that are synthesized by define-major-mode, for example. There's some opportunities to do less work, though. For example, I think it does not make sense to expand defuns because those were handled in a previous step. I think that'd reduce the search space significantly. Another possible approach for this problem is to search textually for just the things that we're typically interested in (like, cl-defstruct or define-derived-mode), and expand only those to see if they synthesize the symbol we are looking for. It will be a less general solution, but it will be faster. We may add more cases in the future, if needed. Thoughts?