From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68875: [PATCH] ; Fix mid-symbol updating/cycling completion preview Date: Wed, 21 Feb 2024 17:59:46 +0100 Message-ID: References: Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22606"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68875@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 21 18:26:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcqM6-0005ci-1Q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Feb 2024 18:26:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcqLq-0007yF-Ve; Wed, 21 Feb 2024 12:25:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcqLk-0007uV-0W for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 12:25:41 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcqLj-0001Af-Lq for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 12:25:39 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcqM5-0000Qy-LX for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 12:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Feb 2024 17:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68875 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68875-submit@debbugs.gnu.org id=B68875.17085363131538 (code B ref 68875); Wed, 21 Feb 2024 17:26:01 +0000 Original-Received: (at 68875) by debbugs.gnu.org; 21 Feb 2024 17:25:13 +0000 Original-Received: from localhost ([127.0.0.1]:56118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcqLI-0000Oi-FR for submit@debbugs.gnu.org; Wed, 21 Feb 2024 12:25:13 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:34928 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcqEv-0008Ui-4W; Wed, 21 Feb 2024 12:18:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1708534788; bh=jbGREnJxzzCwQEJg0GNe8xc8TuyR3g+ed7Bi9YC2Rc8=; h=From:To:Subject:In-Reply-To:References:Date:From; b=C44MNqkh3MTIowhP9BK8tbw3h/v+qS6NFh5V2ncV66IzmIUJCTyh/wLGfLuxzWST4 lb+8cCjCgvtKFLwW/A7LlEgmY1Zyvt63hduN6eG99tI9PDQJTB0PLGvgTlE+E/ePZ+ WqjatEQUt++p3244yfUXo1+QcwtBHeNFgPGBtHJl9f4XeNXUt2Tpov15LlMvGH6Vpg SKcFbKLri6WMr9+hLDBrEiwC1E+C9YuE/fF5PPqYqi+AvC9avpVoahnNbbLclECdBA 03WMb0Jck7dv0BOA923c+TCicUkJzeRvhWFeKp/Ka/9gpFfvJcY6AHOKHUBimXPKEk Xn05O8mOhVYzA== In-Reply-To: (Eshel Yaron's message of "Fri, 02 Feb 2024 13:54:13 +0100") X-Hashcash: 1:20:240221:68875@debbugs.gnu.org::So9h7MH7Ee2/VXcJ:PnH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280407 Archived-At: close 68875 30.1 quit Eshel Yaron writes: >> Tags: patch >> >> The attached patch fixes an issue where the completion preview overlay >> (of Completion Preview mode) could at certain cases appear in the wrong >> place when point is in the middle of a symbol. >> >> To observe the effect of this patch: >> >> 1. emacs -Q >> 2. In the *scratch* buffer, say M-x completion-preview-mode RET >> 3. Type "defaul-di" >> 4. C-3 C-b to place point before the hyphen >> 5. Type "t" >> The completion preview overlay appears after "-di", showing "rectory". >> So far so good. >> 6. M-x completion-preview-next-candidate RET >> Before this patch, the preview now shows "-directory", thus repeating >> the existing suffix "-di". With this patch, the preview shows just >> "rectory", as expected. > > Sorry, that patch contained a thinko (which was caught by one of the > existing tests, fortunately). I'm attaching an updated patch below. Pushed to master, and closing the bug.