From: Leo <sdl.web@gmail.com>
To: 3274@debbugs.gnu.org
Cc: Daniel Colascione <dan.colascione@gmail.com>
Subject: bug#3274: ido-completing-read doesn't work unless ido-mode is executed
Date: Sun, 28 Nov 2010 13:37:41 +0000 [thread overview]
Message-ID: <m14ob1o9ga.fsf@cam.ac.uk> (raw)
In-Reply-To: <E1M4G6i-0001Aq-FS@localhost.localdomain>
I also ran into this bug a while back but didn't stop to fix it.
Could you verify the following patch fixes the bug?
commit 6ca8e9da0d6b61424a4f60073be0d42bd5b23d05
Date: Sun Nov 28 13:32:44 2010 +0000
Fix initialization in ido-completing-read
Modified lisp/ido.el
diff --git a/lisp/ido.el b/lisp/ido.el
index 70d2d98..f1fc323 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -4853,6 +4853,9 @@ DEF, if non-nil, is the default value."
(ido-directory-too-big nil)
(ido-context-switch-command 'ignore)
(ido-choice-list choices))
+ ;; Initialize ido before invoking ido-read-internal
+ (unless (keymapp ido-common-completion-map)
+ (let (ido-mode) (ido-mode 1)))
(ido-read-internal 'list prompt hist def require-match initial-input)))
(defun ido-unload-function ()
next prev parent reply other threads:[~2010-11-28 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 15:10 bug#3274: ido-completing-read doesn't work unless ido-mode is executed Daniel Colascione
2010-11-28 13:37 ` Leo [this message]
2010-11-28 13:53 ` Leo
2010-11-28 20:50 ` Stefan Monnier
2010-12-02 23:05 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14ob1o9ga.fsf@cam.ac.uk \
--to=sdl.web@gmail.com \
--cc=3274@debbugs.gnu.org \
--cc=dan.colascione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).