From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#16920: 24.3; fix eldoc-message to clear own message only Date: Sun, 02 Mar 2014 15:18:10 +0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1393744756 17716 80.91.229.3 (2 Mar 2014 07:19:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Mar 2014 07:19:16 +0000 (UTC) To: 16920@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 02 08:19:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WK0gF-0004B2-Pn for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Mar 2014 08:19:24 +0100 Original-Received: from localhost ([::1]:34666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0gF-00089o-64 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Mar 2014 02:19:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0g3-00089R-7p for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:19:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WK0fu-00009i-Sl for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:19:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0fu-00009c-Pq for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WK0fu-0006Ze-Br; Sun, 02 Mar 2014 02:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Mar 2014 07:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16920 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.139374473025252 (code B ref -1); Sun, 02 Mar 2014 07:19:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Mar 2014 07:18:50 +0000 Original-Received: from localhost ([127.0.0.1]:47317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK0fi-0006ZD-0U for submit@debbugs.gnu.org; Sun, 02 Mar 2014 02:18:50 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37044) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK0ff-0006Z3-Ka for submit@debbugs.gnu.org; Sun, 02 Mar 2014 02:18:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WK0fW-0008C0-Rp for submit@debbugs.gnu.org; Sun, 02 Mar 2014 02:18:47 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0fW-0008Bw-Oq for submit@debbugs.gnu.org; Sun, 02 Mar 2014 02:18:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0fO-000873-6f for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:18:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WK0fF-00088H-8V for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:18:30 -0500 Original-Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:55110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0fF-00088C-12 for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:18:21 -0500 Original-Received: by mail-pa0-f52.google.com with SMTP id rd3so987217pab.25 for ; Sat, 01 Mar 2014 23:18:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=hE9FpTBJcfh2qS8/xRJeCqV2rSESJ9SqKGmo8dYRoxg=; b=fyS+yY2GXYSESRICnCwClBA5D5pIsbnQbhCyPjUI7wFFltQS9eDvf0aNRj4WnRJT4H FJlawRjPnAR2vmd9xEcJXVZc8d/+ak510WnGnm88XT9gvH26UuyyLuugVTIiRi54B0DQ cS0r7gpmcD2QpSq9/+DP58c411dHm+rl/6FoUul2RW6BKnkUFoXs/ITAk1E5Eov0OINT xIvcbwyuP4Hvzx+VIncqIlc/VCnHpT9FQqdZUaoYnMFbhXz7Vb6I2KdqdY5etuKYwA9h TT0TW7zwEppHOS2QojlISf54FbmpJwYtH5rRL13/Ux1Bb4L9okufTgGLphC2350XL+Gh Z6aw== X-Received: by 10.68.138.227 with SMTP id qt3mr13179917pbb.6.1393744699295; Sat, 01 Mar 2014 23:18:19 -0800 (PST) Original-Received: from Zeuss-MacBook.local ([222.130.182.111]) by mx.google.com with ESMTPSA id nv7sm22799402pbc.31.2014.03.01.23.18.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Mar 2014 23:18:18 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86470 Archived-At: I would like to fix eldoc-message for the upcoming release. Now that eldoc can be used in the minibuffer there is one issue that can be really annoying. 1. M-x eval-expression 2. type in (+ 1 1 |) ; | is the cursor 3. quickly pressing SPC repeatedly and then RET The value 2 is shown and then cleared by eldoc (when eldoc-idle-delay is short enough one may not see the value at all). The proposed fix is in the following patch. Comments or objections? === modified file 'lisp/emacs-lisp/eldoc.el' --- lisp/emacs-lisp/eldoc.el 2014-01-30 07:54:28 +0000 +++ lisp/emacs-lisp/eldoc.el 2014-03-02 07:14:45 +0000 @@ -255,7 +255,8 @@ (let ((message-log-max nil)) (cond (eldoc-last-message (funcall eldoc-message-function "%s" eldoc-last-message)) - (omessage (funcall eldoc-message-function nil))))) + (omessage (and (equal omessage (current-message)) + (funcall eldoc-message-function nil)))))) eldoc-last-message) (defun eldoc--message-command-p (command)