From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61647: edit-kbd-macro: Wrong type argument: characterp, 134217785 Date: Mon, 20 Feb 2023 12:39:25 +0100 Message-ID: References: Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15010"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) Cc: mattiase@acm.org, 61647@debbugs.gnu.org To: Eduardo Ochs Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 20 12:40:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pU4Wx-0003i6-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Feb 2023 12:40:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pU4WZ-0007fC-AX; Mon, 20 Feb 2023 06:40:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU4WY-0007ex-9b for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2023 06:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pU4WX-00035y-Vw for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2023 06:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pU4WX-0005nA-Re for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2023 06:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Feb 2023 11:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61647 X-GNU-PR-Package: emacs Original-Received: via spool by 61647-submit@debbugs.gnu.org id=B61647.167689317822222 (code B ref 61647); Mon, 20 Feb 2023 11:40:01 +0000 Original-Received: (at 61647) by debbugs.gnu.org; 20 Feb 2023 11:39:38 +0000 Original-Received: from localhost ([127.0.0.1]:50699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU4WA-0005mJ-2r for submit@debbugs.gnu.org; Mon, 20 Feb 2023 06:39:38 -0500 Original-Received: from sonic310-57.consmr.mail.ir2.yahoo.com ([77.238.177.30]:35172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pU4W7-0005m4-FW for 61647@debbugs.gnu.org; Mon, 20 Feb 2023 06:39:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1676893168; bh=DqiVOYrCbwAqVvhk1a1HoNVuuTKPUOPATRw9JaDfM/U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=L/0mlzwS2ZnT0HJOs3oCcazdR/FWnofWbMPRN7Ufaq6+DLOCrwb6/Tt/HF9D/2hUippgNi8pN4V6QMJKXspDEooq2VksOeBQ/TCy8EY6zMUa03pvubdiSrIoC2jwIaAUhtCUiZ0gZkKQMaNjam2xsmubpWZnw4uYFu434qhtQrovEUNi+WSOjr3kH4jNatNKsgLzhiGt5dEjwgGDTzk4FnGcTbVu0bJ8XzXmsTbNmDsZjoJDNfuLZu5wIZMfz6FauSpD6tXvxIGgMWKrAZQaDK8XMNT7QL5OiyZZqmsjsxs6IqQHnWOmdBOl6GXv/EhsHncJ0ZMAmKWZaosqHKm9mw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676893169; bh=bEGKuEhGGyxDmNdmtw95GZOQnI8UPAKhoZvz1T95Z3F=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Jpxeby2jb2YURPaUXiknLqs7s+b7IpgzvGS93R3zWJwePQSkMSbKXpZyULPdgGMVlJa8v+5KEVGbXNy0ZpCVoYWIdVfLa+Nb6UaYZgSKU1IiFZZo2NplCEyUHqsetv7nF/25qO1epMhhxOSgtrNn+cFrAN+qs+S3oEZLqQRdnZZNScPtNxjw5IwcXQAZDoZo3BjvymGtilrpSMJYqLlpzNeyyhOuei7l9MV2NzB+oACBr6H7CMR5Kjf46L00DtBpJAdm+Lrn06hKzfD9tWUiHyTIOs7Oo3tPvqRJq3vEeF4St1l405orSs4xBi2n7N6wU8yS0YOrUop+4NsY2YY2nQ== X-YMail-OSG: x1Hx8WEVM1krABtqWTv1mJdiQyUer5jeska.yNWEHf8C3dlzwke_F9D6ujKRMRM wOtmv_7kWCIViQmhfBGkxtdut2fKp0duKSIADchKVf9CuDTxi8GI_PozICcTLsxpi4thtr7i3YDc _hLzcXvRNbVfpmy04srmyersajFirTC843a5FZh6oLXTaUy3wWg1hiwg6qJRvXmDaSz.Lr7AEuyQ MTs1z1fxZNfUiHV_.YOseUjkC_.NYgw6F3E43DoaGZ8lMLLHrj1PyNyOBtl32r6wVXG6jcG9Hvm8 D45qguHYho2mRRnacgtqjGuEUQubCPNysvcbs.9K6NGMYeCBKc_T0nxJuW9tzEyPAMKW.cgKOogv vqCIi8GhhxuJE7Z3AMfD8GOenEeuQW9ttNF_45Y5XKpiFpdN.ErbFlSHU73rLP1X_40fqOECvjfv sVAmKyXCe__8_hRUk3LO5ZNa3FazVnXe7Xq4DSUZ1S3yvsYJjLDE88qSYGgQDC7Uhvf2DkMqZOA6 54J3bEd_1tE15pTK.O8UcomeHnLbuL9icpO9MdqR16SoM3DhJMbl9gd11PvjbGSQATTwdbCbjstC B.9FjqS85ZaqEwRIEdFThqUkOwWFLjxEDDXh40huk.xdHRp4rKLrSPVDug65mzkHvV86TzI.DE4X kKHblr0KiCXer4VRF_U4ClkDdFJCGfsBZpFmriACypT4yjc5TnnwEcQLis0nmaN4HpQKUrqaYu9I imxnKezXsjESfT7rMjCLspCWo2pxS4rBFxg.2YPJksPfpZEkS4qs_R49rp9y.4VfDGtUmhaanZLB GPga_wBJ3JWGj10sY6BkebRq0G6nQLUiFuJ4wHESfi X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Mon, 20 Feb 2023 11:39:28 +0000 Original-Received: by hermes--production-ir2-65c64dfd66-mp9nb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f142a3f470774a7f3d7e9c0e34627e2d; Mon, 20 Feb 2023 11:39:26 +0000 (UTC) In-Reply-To: (Eduardo Ochs's message of "Mon, 20 Feb 2023 02:31:25 -0300") X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256141 Archived-At: Eduardo Ochs writes: > Hi all, I found a keyboard macro on which edit-kbd-macro fails with > this error: > > edit-kbd-macro: Wrong type argument: characterp, 134217785 > > To reproduce the error run any of these two setqs - they should be > equivalent - > > (setq last-kbd-macro [134217847 134217785 134217785 134217834 5 32 > 25 1 67108896 down 134217847 134217777 134217834 return 25 > 134217803 134217803]) > > (setq last-kbd-macro (kbd "M-w M-99 M-j C-e SPC C-y C-a C-SPC > M-w M-1 M-j RET C-y 2*M-K")) > > and then run `M-x edit-kbd-macro C-x e'. > This is the commit that introduced this regression: commit e5695faec4a43f10be3b56fa7fd436d5f54a5761 Author: Mattias Engdeg=C3=A5rd Date: Fri Aug 19 13:27:53 2022 +0200 * lisp/edmacro.el (edmacro-sanitize-for-string): Fix condition. =20=20=20=20 This is of little consequence in practice since the input is always a vector of keys representing a prefix, where bit 7 isn't likely to be set when higher bits are set, but it silences a (justified) warning. diff --git a/lisp/edmacro.el b/lisp/edmacro.el index efffab9b30b..26a5d2347f0 100644 --- a/lisp/edmacro.el +++ b/lisp/edmacro.el @@ -626,7 +626,7 @@ edmacro-sanitize-for-string This function assumes that the events can be stored in a string." (setq seq (copy-sequence seq)) (cl-loop for i below (length seq) do - (when (logand (aref seq i) 128) + (when (/=3D (logand (aref seq i) 128) 0) (setf (aref seq i) (logand (aref seq i) 127)))) seq) =20 Adding Mattias to the CC.