From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#16023: 24.3; [PATCH] process-live-p tweak Date: Mon, 02 Dec 2013 09:32:54 +0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385948064 2357 80.91.229.3 (2 Dec 2013 01:34:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Dec 2013 01:34:24 +0000 (UTC) Cc: Lars Magne Ingebrigtsen To: 16023@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 02 02:34:25 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VnIP2-0005RJ-WF for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2013 02:34:25 +0100 Original-Received: from localhost ([::1]:33394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnIP2-00043H-H5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Dec 2013 20:34:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnIOr-00041c-8g for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:34:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnIOi-0008C3-Fd for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:34:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnIOi-0008Bz-C2 for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:34:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VnIOg-0003er-D9; Sun, 01 Dec 2013 20:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2013 01:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16023 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Magne Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.138594801614025 (code B ref -1); Mon, 02 Dec 2013 01:34:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Dec 2013 01:33:36 +0000 Original-Received: from localhost ([127.0.0.1]:53703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnIOF-0003e9-Pp for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47720) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnIOD-0003dv-AU for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnINz-0007kX-JZ for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:27 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:32947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINz-0007kT-GA for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINq-0003oI-Ta for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnINi-0007jc-Fv for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:10 -0500 Original-Received: from mail-pb0-x22f.google.com ([2607:f8b0:400e:c01::22f]:39163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINi-0007jX-7n for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:02 -0500 Original-Received: by mail-pb0-f47.google.com with SMTP id um1so17806573pbc.34 for ; Sun, 01 Dec 2013 17:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=xCyLKxEx2ADQicY9rLUwPuy/DoEgo1S7xvxLvnPZDBA=; b=ZVTe1NaL4cICHBgYl39Tm/y/pHbJHV0zHIorolBElY4Hv4uyhfIB89MNESLiHaBCgj k4RVGp3QvGBF1pisHpmV/r6xb9iWFmQxU3f9Af3iXAJBg9cOBbJdw469LOJNGJjUlb1G ZqcC1m+K8hFvCGsrHtYKc0FspTs8e8QqP52duJXtQI5lkUFQRs7Iw0dgH3xMtunTpMIY 8SvE1Fq934m1lE0pOjNaI+9+BxDtAOYeOLAEihR3rTIRmAOKBosHUqz9tFsrYgfA5nze nymuKDW45XsutvM31sZnm9g/OsZ+0IQAlwCU2qeLhXEu/I5Geuwtnk6mN4CMk48g9cAa 05Yg== X-Received: by 10.68.225.9 with SMTP id rg9mr28573345pbc.122.1385947980503; Sun, 01 Dec 2013 17:33:00 -0800 (PST) Original-Received: from Zeuss-MacBook.local ([123.119.93.169]) by mx.google.com with ESMTPSA id ka3sm118304034pbc.32.2013.12.01.17.32.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Dec 2013 17:32:59 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81223 Archived-At: It seems inconvenient for a predicate to throw type error. I have used process-live-p a few times and was always surprised. It seems better to simply return nil for non-process arg. buffer-live-p does something similar. In octave.el, I have to use another one-liner (defun inferior-octave-process-live-p () (and inferior-octave-process (process-live-p inferior-octave-process))) to mitigate this problem which would be redundant if process-live-p doesn't throw error for non-process arg. So I wonder if you object to the following tweak: === modified file 'lisp/subr.el' --- lisp/subr.el 2013-11-24 08:49:44 +0000 +++ lisp/subr.el 2013-12-02 01:30:08 +0000 @@ -1885,9 +1885,11 @@ (defun process-live-p (process) "Returns non-nil if PROCESS is alive. A process is considered alive if its status is `run', `open', -`listen', `connect' or `stop'." - (memq (process-status process) - '(run open listen connect stop))) +`listen', `connect' or `stop'. Value is nil if PROCESS is not a +process." + (and (processp process) + (memq (process-status process) + '(run open listen connect stop)))) ;; compatibility Thanks, Leo