From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#24213: 25.1.50; Fishy use of delete-window in register.el Date: Sat, 13 Aug 2016 10:39:49 +0800 Message-ID: References: <87mvkhivpu.fsf@hochschule-trier.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1471056079 26171 195.159.176.226 (13 Aug 2016 02:41:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Aug 2016 02:41:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (OS X 10.11.6) Cc: 24213@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 13 04:41:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYOst-0006cV-52 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Aug 2016 04:41:15 +0200 Original-Received: from localhost ([::1]:55655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYOsp-0006p4-UN for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Aug 2016 22:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYOsk-0006oz-Rs for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2016 22:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYOsg-0006ho-No for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2016 22:41:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYOsg-0006hk-JO for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2016 22:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bYOsg-0000bx-Gb for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2016 22:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Aug 2016 02:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24213-submit@debbugs.gnu.org id=B24213.14710560042277 (code B ref 24213); Sat, 13 Aug 2016 02:41:02 +0000 Original-Received: (at 24213) by debbugs.gnu.org; 13 Aug 2016 02:40:04 +0000 Original-Received: from localhost ([127.0.0.1]:55618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYOrk-0000ae-JW for submit@debbugs.gnu.org; Fri, 12 Aug 2016 22:40:04 -0400 Original-Received: from mail-wm0-f47.google.com ([74.125.82.47]:37146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYOri-0000a4-Sd for 24213@debbugs.gnu.org; Fri, 12 Aug 2016 22:40:03 -0400 Original-Received: by mail-wm0-f47.google.com with SMTP id i5so6090697wmg.0 for <24213@debbugs.gnu.org>; Fri, 12 Aug 2016 19:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=CY6E8YxDberqoHNwS3X0v+QjPRyrkaceyOK4KB+Yebw=; b=szxX+ADMRv9MtbQXQ4RmlTvThokJ0t/M8xn/iR0+nZk8jTvt7RrASjalQoyn2JRL2W k2T9fvZQJlFSASOet7qgcfcwo1lB2cd5rRWM2t8o0wpSW926bNDNl9u9zyUuuSuBrUfn UEhvxMVFQl5Xa5d7e0vBpDYhNKovl3MoFUSW3cTR6IRk988GofTOGjR2WjT0f5/5CuMd EGDnLtqMSHh3gJCzqVljlt5kNQPVLW4ZV2p5VPqCPvXxjXlAg0ae+09cnvnZi4ztHJNU WCpY1ojyZbxmY2SbiH4yRJrJhIquUCkYd0uP2u/+tcy70dkRVaK9Z0fq9mJGogsTC25V Xrlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=CY6E8YxDberqoHNwS3X0v+QjPRyrkaceyOK4KB+Yebw=; b=djLOPInVO5vpLJDBlEzG7nL46nOhzK900EttKv283q2W9TIgxk1kORN2hRKtr+us+i JPqq1IMcbq4esH1DlyrFHMUXX2P5ULNrrBnC0eiw0iR2Yug379pmQYQsWOZFlxphvLcE 6x10YA1jMVXg0sagJtHFPoNeWVajWXj8eeFy+WmKs4T6fR+EMjjSo2ALemIxF8WllDQp Nip2mcYzioH0BYCfIsHO9UQWIPmSXtHqo8vF/TTQdocxnk5UzttKX/1Q+5fglX3QEdBQ C3+bavOELkk1gOZC/GzBBlpj3LErEzhyev8Apr4gF6IP0UF896z55frCUSVzUQkmiI51 lbnw== X-Gm-Message-State: AEkoousFHp1hHKzVIORSueynVYxGawgeSePwfwVjCSfdOLEPNeIyJA8mDAki85DhQcJ0cw== X-Received: by 10.28.223.9 with SMTP id w9mr1626129wmg.65.1471055996848; Fri, 12 Aug 2016 19:39:56 -0700 (PDT) Original-Received: from zeuss-MacBook-Pro.local ([46.101.90.246]) by smtp.gmail.com with ESMTPSA id gg10sm10008533wjd.4.2016.08.12.19.39.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Aug 2016 19:39:56 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= In-Reply-To: <87mvkhivpu.fsf@hochschule-trier.de> (Andreas Politz's message of "Fri, 12 Aug 2016 22:22:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122146 Archived-At: On 2016-08-12 22:22 +0200, Andreas Politz wrote: > The register.el commands display a preview of register contents, using > display-buffer in register-preview. Later, when some register was > chosen by the user, the window showing this preview is closed via > delete-window. The window is created by `display-buffer-below-selected' so we know its ours and thus delete-window is technically safe here. Use quit-window/quit-windows-on is ok as well for being defensive. Martin, it seems the documentation of display-buffer-below-selected isn't clear that it only reuses a window if it displays BUFFER already. Leo